public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jason Merrill <jason@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [C++ PATCH] Optimize C++ comdat ctors/dtors in classes without  virtual bases (PR c++/3187, take 3)
Date: Tue, 01 Dec 2009 03:53:00 -0000	[thread overview]
Message-ID: <4B149197.4040304@redhat.com> (raw)
In-Reply-To: <20091130223653.GO22813@hs20-bc2-1.build.redhat.com>

On 11/30/2009 05:36 PM, Jakub Jelinek wrote:
> 	* config/abi/pre/gnu.ver: Don't export certain base dtors that
> 	weren't previously exported.

Is this necessary?  I thought it was OK to add new exported symbols, but 
you'd know better than I.

> +	  && (SUPPORTS_ONE_ONLY || !DECL_WEAK (fns[0]))

This test seems unnecessary; I don't see the problem with using aliases 
on targets with weak symbols but no one-only support.

Jason

  reply	other threads:[~2009-12-01  3:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-30 22:38 Jakub Jelinek
2009-12-01  3:53 ` Jason Merrill [this message]
2009-12-01  8:07   ` Jakub Jelinek
2009-12-01 15:39     ` Jason Merrill
2009-12-01  9:52 ` [C++ PATCH] Optimize C++ comdat ctors/dtors in classes without virtual bases (PR c++/3187, take 4) Jakub Jelinek
2009-12-01 15:40   ` Jakub Jelinek
2009-12-01 16:38     ` Dave Korn
2009-12-01 19:35   ` [C++ PATCH] Optimize C++ comdat ctors/dtors in classes without virtual bases (PR c++/3187, take 5) Jakub Jelinek
2009-12-01 20:14     ` Jason Merrill
2009-12-01 21:03     ` Dave Korn
2009-12-04 18:19       ` Dave Korn
2009-12-04 18:29         ` Jakub Jelinek
2009-12-04 18:46           ` Dave Korn
2009-12-27 13:36     ` H.J. Lu
2009-12-01 21:15 ` [C++ PATCH] Optimize C++ comdat ctors/dtors in classes without virtual bases (PR c++/3187, take 3) Daniel Jacobowitz
2009-12-01 21:20   ` Jakub Jelinek
2009-12-01 21:50     ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B149197.4040304@redhat.com \
    --to=jason@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).