From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16352 invoked by alias); 2 Dec 2009 21:22:47 -0000 Received: (qmail 16343 invoked by uid 22791); 2 Dec 2009 21:22:46 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Dec 2009 21:22:43 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nB2LMfD6026888 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 2 Dec 2009 16:22:41 -0500 Received: from stone.twiddle.home (vpn-229-66.phx2.redhat.com [10.3.229.66]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nB2LMfRO006706; Wed, 2 Dec 2009 16:22:41 -0500 Message-ID: <4B16DA9C.3050809@redhat.com> Date: Wed, 02 Dec 2009 21:46:00 -0000 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-3.9.b4.fc12 Thunderbird/3.0b4 MIME-Version: 1.0 To: Richard Guenther , GCC Patches , Jan Hubicka Subject: Re: [PATCH] Reorder fields in struct cgraph_edge et al References: <20091130204143.GF12510@virgil.suse.cz> <20091201105627.GA4389@virgil.suse.cz> <20091201112900.GB4389@virgil.suse.cz> <20091202120029.GA32385@virgil.suse.cz> In-Reply-To: <20091202120029.GA32385@virgil.suse.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2009-12/txt/msg00156.txt.bz2 On 12/02/2009 04:00 AM, Martin Jambor wrote: > + /* Expected number of executions: calculated in profile.c. This field should > + be aligned to 64 bits on all targets. */ > + gcov_type count; Comment is wrong. The field is 64-bits *wide* on all targets. But on 32-bit targets, 64-bit types are often 32-bit aligned. r~