From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18933 invoked by alias); 14 Dec 2009 19:38:33 -0000 Received: (qmail 18916 invoked by uid 22791); 14 Dec 2009 19:38:31 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from fg-out-1718.google.com (HELO fg-out-1718.google.com) (72.14.220.155) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Dec 2009 19:38:26 +0000 Received: by fg-out-1718.google.com with SMTP id e12so89251fga.8 for ; Mon, 14 Dec 2009 11:38:24 -0800 (PST) Received: by 10.87.73.2 with SMTP id a2mr6652791fgl.34.1260819504177; Mon, 14 Dec 2009 11:38:24 -0800 (PST) Received: from 93-103-18-160.static.t-2.net (93-103-18-160.static.t-2.net [93.103.18.160]) by mx.google.com with ESMTPS id l19sm6389599fgb.13.2009.12.14.11.38.21 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 14 Dec 2009 11:38:22 -0800 (PST) Message-ID: <4B26942C.7010101@gmail.com> Date: Mon, 14 Dec 2009 20:14:00 -0000 From: Uros Bizjak User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Thunderbird/3.0b4 MIME-Version: 1.0 To: Sebastian Pop CC: Jakub Jelinek , Richard Henderson , gcc-patches@gcc.gnu.org Subject: Re: PATCH: Add LWP support for upcoming AMD Orochi processor. References: <20091009003847.13926.38424.sendpatchset@tilapia-05.site> <20091106101131.GW14664@tyan-ft48-01.lab.bos.redhat.com> <20091210200641.GE22813@hs20-bc2-1.build.redhat.com> <20091210210945.GF22813@hs20-bc2-1.build.redhat.com> <20091211145001.GI22813@hs20-bc2-1.build.redhat.com> <20091211213422.GJ22813@hs20-bc2-1.build.redhat.com> In-Reply-To: Content-Type: multipart/mixed; boundary="------------090606070906020208020001" Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2009-12/txt/msg00737.txt.bz2 This is a multi-part message in MIME format. --------------090606070906020208020001 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 3103 On 12/12/2009 08:24 AM, Sebastian Pop wrote: > >>> If you are ok with these, can you combine the 3 patches posted today, >>> write ChangeLog, test it and submit? >>> >>> >> Yes, I will do this. >> > Here is the patch that fixes the support for LWP. > > 2009-12-11 Jakub Jelinek > Sebastian Pop > ... > > testsuite/ > * gcc.target/i386/sse-12.c: Add -mpopcnt and -mlwp. > * gcc.target/i386/sse-13.c: Same. > (__builtin_ia32_lwpval32, __builtin_ia32_lwpval64, > __builtin_ia32_lwpins32, __builtin_ia32_lwpins64): Added testcases. > * gcc.target/i386/sse-14.c: Add -mpopcnt -mabm -mlwp. > Added tests for __lwpval32, __lwpins32, __lwpval64, and __lwpins64. > * gcc.target/i386/sse-22.c: Added tests for popcnt, abm, and lwp. > * gcc.target/i386/sse-23.c: Same. > > Passed bootstrap and test on amd64-linux. Ok for trunk? > You forgot to change/add intrinsics tests to g++.dg/other/sse-{2,3}.C, like in attached patch (sse-5.C and sse-6.C can be deleted, since all headers play nicely with each other. Strangely, with attached patch, I got a couple of errors: In file included from /home/uros/gcc-build/gcc/testsuite/g++/../../include/x86intrin.h:77:0, from /home/uros/gcc-svn/trunk/gcc/testsuite/g++.dg/other/i386-2.C:8: : In function 'void* __slwpcb()': :0:0: error: too few arguments to function 'void* __builtin_ia32_slwpcb(void)' /home/uros/gcc-build/gcc/testsuite/g++/../../include/lwpintrin.h:44:33: error: at this point in file compiler exited with status 1 output is: In file included from /home/uros/gcc-build/gcc/testsuite/g++/../../include/x86intrin.h:77:0, from /home/uros/gcc-svn/trunk/gcc/testsuite/g++.dg/other/i386-2.C:8: : In function 'void* __slwpcb()': :0:0: error: too few arguments to function 'void* __builtin_ia32_slwpcb(void)' /home/uros/gcc-build/gcc/testsuite/g++/../../include/lwpintrin.h:44:33: error: at this point in file FAIL: g++.dg/other/i386-2.C (test for excess errors) and: In file included from /home/uros/gcc-build/gcc/testsuite/g++/../../include/x86intrin.h:77:0, from /home/uros/gcc-svn/trunk/gcc/testsuite/g++.dg/other/i386-3.C:8: : In function 'void* __slwpcb()': :0:0: error: too few arguments to function 'void* __builtin_ia32_slwpcb(void)' /home/uros/gcc-build/gcc/testsuite/g++/../../include/lwpintrin.h:44:33: error: at this point in file compiler exited with status 1 output is: In file included from /home/uros/gcc-build/gcc/testsuite/g++/../../include/x86intrin.h:77:0, from /home/uros/gcc-svn/trunk/gcc/testsuite/g++.dg/other/i386-3.C:8: : In function 'void* __slwpcb()': :0:0: error: too few arguments to function 'void* __builtin_ia32_slwpcb(void)' /home/uros/gcc-build/gcc/testsuite/g++/../../include/lwpintrin.h:44:33: error: at this point in file FAIL: g++.dg/other/i386-3.C (test for excess errors) Uros. > Thanks, > Sebastian Pop > -- > AMD / Open Source Compiler Engineering / GNU Tools > --------------090606070906020208020001 Content-Type: text/plain; name="s.diff.txt" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="s.diff.txt" Content-length: 3697 SW5kZXg6IGcrKy5kZy9vdGhlci9pMzg2LTIuQwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBnKysuZGcvb3RoZXIvaTM4Ni0yLkMJKHJldmlzaW9uIDE1 NTIyNikKKysrIGcrKy5kZy9vdGhlci9pMzg2LTIuQwkod29ya2luZyBjb3B5 KQpAQCAtMSw4ICsxLDEwIEBACi0vKiBUZXN0IHRoYXQgeyx4LGUscCx0LHMs dyxhLGl9bW1pbnRyaW4uaCwgZm1hNGludHJpbi5oLCB4b3BpbnRyaW4uaCwg bW0zZG5vdy5oIGFuZAotICAgbW1fbWFsbG9jLmggYXJlIHVzYWJsZSB3aXRo IC1PIC1wZWRhbnRpYy1lcnJvcnMuICAqLwogLyogeyBkZy1kbyBjb21waWxl IHsgdGFyZ2V0IGk/ODYtKi0qIHg4Nl82NC0qLSogfSB9ICovCi0vKiB7IGRn LW9wdGlvbnMgIi1PIC1wZWRhbnRpYy1lcnJvcnMgLW1hcmNoPWs4IC1tM2Ru b3cgLW1hdnggLW1zc2U0YSAtbWZtYTQgLW14b3AgLW1hZXMgLW1wY2xtdWwi IH0gKi8KKy8qIHsgZGctb3B0aW9ucyAiLU8gLXBlZGFudGljLWVycm9ycyAt bWFyY2g9azggLW0zZG5vdyAtbWF2eCAtbXhvcCAtbWFlcyAtbXBjbG11bCAt bXBvcGNudCAtbWFibSAtbWx3cCIgfSAqLwogCisvKiBUZXN0IHRoYXQgeyx4 LGUscCx0LHMsdyxhLGIsaX1tbWludHJpbi5oLCB4b3BpbnRyaW4uaCwgYWJt aW50cmluLmgsCisgICBsd3BpbnRyaW4uaCwgcG9wY250aW50cmluLmggYW5k IG1tM2Rub3cuaCBhcmUgdXNhYmxlIHdpdGgKKyAgIC1PIC1wZWRhbnRpYy1l cnJvcnMuICAqLworCiAjaW5jbHVkZSA8eDg2aW50cmluLmg+CiAKIGludCBk dW1teTsKSW5kZXg6IGcrKy5kZy9vdGhlci9pMzg2LTYuQwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBnKysuZGcvb3RoZXIvaTM4Ni02LkMJKHJldmlz aW9uIDE1NTIyNikKKysrIGcrKy5kZy9vdGhlci9pMzg2LTYuQwkod29ya2lu ZyBjb3B5KQpAQCAtMSw4ICswLDAgQEAKLS8qIFRlc3QgdGhhdCB7LHgsZSxw LHQscyx3LGEsaX1tbWludHJpbi5oLCBmbWE0aW50cmluLmgsIHhvcGludHJp bi5oLCBtbTNkbm93LmggYW5kCi0gICBtbV9tYWxsb2MuaCBhcmUgdXNhYmxl IHdpdGggLU8gLXBlZGFudGljLWVycm9ycy4gICovCi0vKiB7IGRnLWRvIGNv bXBpbGUgeyB0YXJnZXQgaT84Ni0qLSogeDg2XzY0LSotKiB9IH0gKi8KLS8q IHsgZGctb3B0aW9ucyAiLU8gLXBlZGFudGljLWVycm9ycyAtbWFyY2g9azgg LW0zZG5vdyAtbWF2eCAtbXNzZTRhIC1tZm1hNCAtbXhvcCAtbWFlcyAtbXBj bG11bCIgfSAqLwotCi0jaW5jbHVkZSA8eDg2aW50cmluLmg+Ci0KLWludCBk dW1teTsKSW5kZXg6IGcrKy5kZy9vdGhlci9pMzg2LTMuQwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBnKysuZGcvb3RoZXIvaTM4Ni0zLkMJKHJldmlz aW9uIDE1NTIyNikKKysrIGcrKy5kZy9vdGhlci9pMzg2LTMuQwkod29ya2lu ZyBjb3B5KQpAQCAtMSw2ICsxLDggQEAKLS8qIFRlc3QgdGhhdCB7LHgsZSxw LHQscyx3LGEsaX1tbWludHJpbi5oLCBmbWE0aW50cmluLmgsIG1tM2Rub3cu aCwgeG9waW50cmluLmggYW5kCi0gICAgbW1fbWFsbG9jLmggYXJlIHVzYWJs ZSB3aXRoIC1PIC1ma2VlcC1pbmxpbmUtZnVuY3Rpb25zLiAgKi8KIC8qIHsg ZGctZG8gY29tcGlsZSB7IHRhcmdldCBpPzg2LSotKiB4ODZfNjQtKi0qIH0g fSAqLwotLyogeyBkZy1vcHRpb25zICItTyAtZmtlZXAtaW5saW5lLWZ1bmN0 aW9ucyAtbWFyY2g9azggLW0zZG5vdyAtbWF2eCAtbXNzZTRhIC1tZm1hNCAt bXhvcCAtbWFlcyAtbXBjbG11bCIgfSAqLworLyogeyBkZy1vcHRpb25zICIt TyAtZmtlZXAtaW5saW5lLWZ1bmN0aW9ucyAtbWFyY2g9azggLW0zZG5vdyAt bWF2eCAtbXhvcCAtbWFlcyAtbXBjbG11bCAtbXBvcGNudCAtbWFibSAtbWx3 cCIgfSAqLwogCisvKiBUZXN0IHRoYXQgeyx4LGUscCx0LHMsdyxhLGIsaX1t bWludHJpbi5oLCB4b3BpbnRyaW4uaCwgYWJtaW50cmluLmgsCisgICBsd3Bp bnRyaW4uaCwgcG9wY250aW50cmluLmggYW5kIG1tM2Rub3cuaCBhcmUgdXNh YmxlIHdpdGgKKyAgIC1PIC1ma2VlcC1pbmxpbmUtZnVuY3Rpb25zLiAgKi8K KwogI2luY2x1ZGUgPHg4NmludHJpbi5oPgpJbmRleDogZysrLmRnL290aGVy L2kzODYtNS5DCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGcrKy5kZy9v dGhlci9pMzg2LTUuQwkocmV2aXNpb24gMTU1MjI2KQorKysgZysrLmRnL290 aGVyL2kzODYtNS5DCSh3b3JraW5nIGNvcHkpCkBAIC0xLDYgKzAsMCBAQAot LyogVGVzdCB0aGF0IHsseCxlLHAsdCxzLHcsYSxpfW1taW50cmluLmgsIGZt YTRpbnRyaW4uaCwgeG9waW50cmluLmgsIG1tM2Rub3cuaCBhbmQKLSAgIG1t X21hbGxvYy5oIGFyZSB1c2FibGUgd2l0aCAtTyAtZmtlZXAtaW5saW5lLWZ1 bmN0aW9ucy4gICovCi0vKiB7IGRnLWRvIGNvbXBpbGUgeyB0YXJnZXQgaT84 Ni0qLSogeDg2XzY0LSotKiB9IH0gKi8KLS8qIHsgZGctb3B0aW9ucyAiLU8g LWZrZWVwLWlubGluZS1mdW5jdGlvbnMgLW1hcmNoPWs4IC1tM2Rub3cgLW1h dnggLW1zc2U0YSAtbWZtYTQgLW14b3AgLW1hZXMgLW1wY2xtdWwiIH0gKi8K LQotI2luY2x1ZGUgPHg4NmludHJpbi5oPgo= --------------090606070906020208020001--