From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12593 invoked by alias); 24 Feb 2010 06:47:13 -0000 Received: (qmail 12566 invoked by uid 22791); 24 Feb 2010 06:47:11 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_SORBS_WEB X-Spam-Check-By: sourceware.org Received: from mail-bw0-f214.google.com (HELO mail-bw0-f214.google.com) (209.85.218.214) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 24 Feb 2010 06:47:06 +0000 Received: by bwz6 with SMTP id 6so3589720bwz.16 for ; Tue, 23 Feb 2010 22:47:04 -0800 (PST) Received: by 10.204.140.197 with SMTP id j5mr3136269bku.68.1266994024224; Tue, 23 Feb 2010 22:47:04 -0800 (PST) Received: from yakj.usersys.redhat.com (93-34-208-53.ip51.fastwebnet.it [93.34.208.53]) by mx.google.com with ESMTPS id 13sm2407952bwz.3.2010.02.23.22.47.02 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 23 Feb 2010 22:47:02 -0800 (PST) Message-ID: <4B84CB65.6080907@gnu.org> Date: Wed, 24 Feb 2010 06:57:00 -0000 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.1 MIME-Version: 1.0 To: Shujing Zhao CC: Marco Poletti , Jakub Jelinek , "Joseph S. Myers" , gdr@integrable-solutions.net, Gabriel Dos Reis , gcc-patches@gcc.gnu.org, Paolo Carlini Subject: Re: gcc/cp/pt.c: use ngettext() when needed References: <206fcf961002170906l1bdca005h3833890d35d7db5c@mail.gmail.com> <4B7C3571.60808@gnu.org> <20100218144545.GV2817@tyan-ft48-01.lab.bos.redhat.com> <4B84A60B.5020709@oracle.com> In-Reply-To: <4B84A60B.5020709@oracle.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-02/txt/msg00959.txt.bz2 > Marco, xgettext can't accept the --flag argument that have more than one > argnums. It will have the argnums like 2,3 if the above code added. Not true: If KEYWORDSPEC is of the form `ID:ARGNUM1,ARGNUM2', `xgettext' looks for strings in the ARGNUM1st argument and in the ARGNUM2nd argument of the call, and treats them as singular/plural variants for a message with plural handling. > How about to only use the conditional expression like > > error (TREE_VEC_LENGTH (parms) > 1 > ? G_("redeclared with %d template parameters") > : G_("redeclared with %d template parameter"), > TREE_VEC_LENGTH (parms)); > > it changed less to fix this problem. It wouldn't work for all Slavic and Baltic languages (and a few others), where you have multiple plural forms. Paolo