public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Shujing Zhao <pearly.zhao@oracle.com>
To: Gabriel Dos Reis <gdr@integrable-solutions.net>
Cc: Jakub Jelinek <jakub@redhat.com>, Paolo Bonzini <bonzini@gnu.org>,
	        Marco Poletti <poletti.marco@gmail.com>,
	        "Joseph S. Myers" <joseph@codesourcery.com>,
	gcc-patches@gcc.gnu.org,
	        Paolo Carlini <paolo.carlini@oracle.com>
Subject: Re: gcc/cp/pt.c: use ngettext() when needed
Date: Fri, 26 Feb 2010 10:09:00 -0000	[thread overview]
Message-ID: <4B879A27.4010002@oracle.com> (raw)
In-Reply-To: <206fcf961002260143v334a4206gc045d9a7b8eb3887@mail.gmail.com>

On 02/26/2010 05:43 PM, Gabriel Dos Reis wrote:
> On Fri, Feb 26, 2010 at 3:39 AM, Jakub Jelinek <jakub@redhat.com> wrote:
>> On Fri, Feb 26, 2010 at 03:32:27AM -0600, Gabriel Dos Reis wrote:
>>>> No, that (as I already said upthread) will not work for Baltic and Slavic
>>>> languages.  A Czech example:
>>>>
>>>>   1 kandidát
>>>>   2-3-4 kandidáti
>>>>   5+ kandidátů
>>>>
>>>> Paolo
>>>>
>>> yes, but if you want me to review a new version of your patch
>>> based on feedbacks, don't hesitate to be more specific about
>>> what "this" refers to.
>> http://gcc.gnu.org/ml/gcc-patches/2010-02/msg00719.html
>> with
>> http://gcc.gnu.org/ml/gcc-patches/2010-02/msg00961.html
>> changes for exgettext instead of the original one.
>>
>>        Jakub
>>
> 
> The patch is OK.  Thanks.
I viewed the new generated gcc.pot by this patch, the changed parts are the 
following:

#: cp/pt.c:4667
#, gcc-internal-format
msgid "redeclared with %d template parameter"
msgid_plural "redeclared with %d template parameters"
msgstr[0] ""
msgstr[1] ""

#: cp/pt.c:4671
#, gcc-internal-format
msgid "previous declaration %q+D used %d template parameter"
msgid_plural "previous declaration %q+D used %d template parameters"
msgstr[0] ""
msgstr[1] ""

Just be curious, how the msgstr will be set at the above example Paolo indicated.

Thanks
Pearly

  reply	other threads:[~2010-02-26  9:56 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-17 15:23 Marco Poletti
2010-02-17 15:25 ` Marco Poletti
2010-02-17 17:06 ` Gabriel Dos Reis
2010-02-17 18:02   ` Marco Poletti
2010-02-17 18:29   ` Paolo Bonzini
2010-02-17 20:07     ` Marco Poletti
2010-02-17 21:26     ` Joseph S. Myers
2010-02-17 21:32       ` Marco Poletti
2010-02-17 23:23         ` Paolo Bonzini
2010-02-18 14:33           ` Marco Poletti
2010-02-18 14:40             ` Jakub Jelinek
2010-02-18 14:49               ` Marco Poletti
2010-02-22  9:38                 ` Marco Poletti
2010-02-24  6:47                   ` Shujing Zhao
2010-02-24  6:57                     ` Paolo Bonzini
2010-02-24  8:55                       ` Shujing Zhao
2010-02-24 10:22                         ` Paolo Bonzini
2010-02-26  7:30                     ` Gabriel Dos Reis
2010-02-26  7:31                       ` Marco Poletti
2010-02-26  9:32                         ` Gabriel Dos Reis
2010-02-26  9:43                           ` Paolo Bonzini
2010-02-26  9:56                             ` Gabriel Dos Reis
2010-02-26 10:03                               ` Jakub Jelinek
2010-02-26 10:04                                 ` Gabriel Dos Reis
2010-02-26 10:09                                   ` Shujing Zhao [this message]
2010-02-26 10:42                                     ` Paolo Bonzini
2010-02-26 10:43                                       ` Jakub Jelinek
2010-03-01 10:00                                         ` Shujing Zhao
2010-03-01 10:16                                           ` Shujing Zhao
2010-03-01 15:12                                             ` Gabriel Dos Reis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B879A27.4010002@oracle.com \
    --to=pearly.zhao@oracle.com \
    --cc=bonzini@gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdr@integrable-solutions.net \
    --cc=jakub@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=paolo.carlini@oracle.com \
    --cc=poletti.marco@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).