From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15185 invoked by alias); 26 Feb 2010 09:56:21 -0000 Received: (qmail 15171 invoked by uid 22791); 26 Feb 2010 09:56:20 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from acsinet11.oracle.com (HELO acsinet11.oracle.com) (141.146.126.233) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 26 Feb 2010 09:56:14 +0000 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by acsinet11.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id o1Q9u8LL012410 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 26 Feb 2010 09:56:09 GMT Received: from acsmt354.oracle.com (acsmt354.oracle.com [141.146.40.154]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o1P4dAJ2007904; Fri, 26 Feb 2010 09:56:05 GMT Received: from abhmt014.oracle.com by acsmt353.oracle.com with ESMTP id 52031371267178062; Fri, 26 Feb 2010 01:54:22 -0800 Received: from [10.182.121.28] (/10.182.121.28) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 26 Feb 2010 01:54:21 -0800 Message-ID: <4B879A27.4010002@oracle.com> Date: Fri, 26 Feb 2010 10:09:00 -0000 From: Shujing Zhao User-Agent: Thunderbird 2.0.0.23 (X11/20090812) MIME-Version: 1.0 To: Gabriel Dos Reis CC: Jakub Jelinek , Paolo Bonzini , Marco Poletti , "Joseph S. Myers" , gcc-patches@gcc.gnu.org, Paolo Carlini Subject: Re: gcc/cp/pt.c: use ngettext() when needed References: <4B84A60B.5020709@oracle.com> <206fcf961002252308t3883270bpb5d7cd0fd02bf2d@mail.gmail.com> <206fcf961002252331k7f390be1jc96a7025bc34d410@mail.gmail.com> <4B8793BA.8050201@gnu.org> <206fcf961002260132q4aa22a7ep2ff42d145442a971@mail.gmail.com> <20100226093904.GT2817@tyan-ft48-01.lab.bos.redhat.com> <206fcf961002260143v334a4206gc045d9a7b8eb3887@mail.gmail.com> In-Reply-To: <206fcf961002260143v334a4206gc045d9a7b8eb3887@mail.gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-02/txt/msg01127.txt.bz2 On 02/26/2010 05:43 PM, Gabriel Dos Reis wrote: > On Fri, Feb 26, 2010 at 3:39 AM, Jakub Jelinek wrote: >> On Fri, Feb 26, 2010 at 03:32:27AM -0600, Gabriel Dos Reis wrote: >>>> No, that (as I already said upthread) will not work for Baltic and Slavic >>>> languages. A Czech example: >>>> >>>> 1 kandidát >>>> 2-3-4 kandidáti >>>> 5+ kandidátů >>>> >>>> Paolo >>>> >>> yes, but if you want me to review a new version of your patch >>> based on feedbacks, don't hesitate to be more specific about >>> what "this" refers to. >> http://gcc.gnu.org/ml/gcc-patches/2010-02/msg00719.html >> with >> http://gcc.gnu.org/ml/gcc-patches/2010-02/msg00961.html >> changes for exgettext instead of the original one. >> >> Jakub >> > > The patch is OK. Thanks. I viewed the new generated gcc.pot by this patch, the changed parts are the following: #: cp/pt.c:4667 #, gcc-internal-format msgid "redeclared with %d template parameter" msgid_plural "redeclared with %d template parameters" msgstr[0] "" msgstr[1] "" #: cp/pt.c:4671 #, gcc-internal-format msgid "previous declaration %q+D used %d template parameter" msgid_plural "previous declaration %q+D used %d template parameters" msgstr[0] "" msgstr[1] "" Just be curious, how the msgstr will be set at the above example Paolo indicated. Thanks Pearly