From: Paolo Carlini <paolo.carlini@oracle.com>
To: Sebastian Pop <sebpop@gmail.com>
Cc: "Yazdani, Reza" <Reza.Yazdani@amd.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"mmitchel@gcc.gnu.org" <mmitchel@gcc.gnu.org>,
"janis@gcc.gnu.org" <janis@gcc.gnu.org>,
Richard Guenther <rguenther@suse.de>
Subject: Re: patch for bug 42640
Date: Mon, 01 Mar 2010 19:11:00 -0000 [thread overview]
Message-ID: <4B8C115B.5060301@oracle.com> (raw)
In-Reply-To: <cb9d34b21003011054g2e5ed92chf7fff3eee1013766@mail.gmail.com>
On 03/01/2010 07:54 PM, Sebastian Pop wrote:
> This looks good to me, but I cannot approve it.
> Richi, could you also have a look at this patch?
>
Well, for sure you don't want a testcase printfs-based like that... ;)
Also, the ChangeLog entry needs some trivial stylistic tweaks, I think.
Paolo.
next prev parent reply other threads:[~2010-03-01 19:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-01 18:46 Yazdani, Reza
2010-03-01 18:54 ` Sebastian Pop
2010-03-01 19:11 ` Paolo Carlini [this message]
2010-03-01 20:18 ` Sebastian Pop
2010-03-02 10:07 ` Richard Guenther
2010-03-02 10:23 ` Sebastian Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8C115B.5060301@oracle.com \
--to=paolo.carlini@oracle.com \
--cc=Reza.Yazdani@amd.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=janis@gcc.gnu.org \
--cc=mmitchel@gcc.gnu.org \
--cc=rguenther@suse.de \
--cc=sebpop@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).