From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32518 invoked by alias); 12 Mar 2010 10:23:47 -0000 Received: (qmail 32506 invoked by uid 22791); 12 Mar 2010 10:23:47 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mail-ww0-f47.google.com (HELO mail-ww0-f47.google.com) (74.125.82.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 12 Mar 2010 10:23:42 +0000 Received: by wwg30 with SMTP id 30so696800wwg.20 for ; Fri, 12 Mar 2010 02:23:40 -0800 (PST) Received: by 10.216.171.138 with SMTP id r10mr697280wel.153.1268389420326; Fri, 12 Mar 2010 02:23:40 -0800 (PST) Received: from yakj.usersys.redhat.com (nat-pool-brq-t.redhat.com [209.132.186.34]) by mx.google.com with ESMTPS id u14sm4194722gvf.2.2010.03.12.02.23.38 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 12 Mar 2010 02:23:39 -0800 (PST) Message-ID: <4B9A1629.20900@gnu.org> Date: Fri, 12 Mar 2010 10:44:00 -0000 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.1 MIME-Version: 1.0 To: Chris Demetriou CC: gcc-patches@gcc.gnu.org Subject: Re: [obvious patch] add missing chmod to when copying headers References: <2e7be40c1003111231u30e5a84fxb23393dcc4fab84c@mail.gmail.com> In-Reply-To: <2e7be40c1003111231u30e5a84fxb23393dcc4fab84c@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-03/txt/msg00476.txt.bz2 On 03/11/2010 09:31 PM, Chris Demetriou wrote: > odd corner case when making/installing: if sources were checked out > with umask that denies group or other read (e.g. 077 or 027), most of > the installed gcc includes would come out group/other-readable but a > few wouldn't. > problem: missing chmods after copying the headers, in stmp-int-headers. > Since all of the rest of the headers are chmodded after copy, the > solution is obvious. > > > bootstrapped, verified permissions manually, committed as obvious. ... but why didn't you use $(INSTALL_DATA)? :-) Paolo