From: Mike Stump <mikestump@comcast.net>
To: Andrew MacLeod <amacleod@redhat.com>
Cc: Bernd Schmidt <bschmidt@redhat.com>,
Iain Sandoe <iain@codesourcery.com>, Jeff Law <law@redhat.com>,
gcc-patches List <gcc-patches@gcc.gnu.org>,
Dominique Dhumieres <dominiq@lps.ens.fr>
Subject: Re: config header file reduction patch checked in.
Date: Fri, 23 Oct 2015 17:49:00 -0000 [thread overview]
Message-ID: <4BC7897B-269E-4CE4-BC4C-F1F83975B8ED@comcast.net> (raw)
In-Reply-To: <562A701E.5080400@redhat.com>
On Oct 23, 2015, at 10:36 AM, Andrew MacLeod <amacleod@redhat.com> wrote:
>
> darwin-driver.c had some code that depended on one of the include files, bit no other part of the file needed it, so that was the issue there. The only other place it seems could be an issue is with collect2.c... so I'll monitor that one closely before checking anything in.. and get the darwin guys to test it for me before committing.
I’m fine with checking it in on the assumption darwin won’t break here. If it does, I think it will be trivial to clean it up. Just watch out for any darwin doesn’t build due to missing decls or some such and let them know what header needs to be included in darwin.h based upon the missing decls. I faced one of these recently with my port as the headers flexed. Annoying, but not too hard to recover from.
next prev parent reply other threads:[~2015-10-23 17:47 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 2:22 [patch 0/3] Header file reduction Andrew MacLeod
2015-10-02 2:33 ` [patch 1/3] Header file reduction - backend files Andrew MacLeod
2015-10-07 22:02 ` Jeff Law
2015-10-07 23:09 ` Andrew MacLeod
2015-10-08 13:37 ` [patch] header file re-ordering Andrew MacLeod
2015-10-08 15:29 ` Jeff Law
2015-10-11 20:58 ` [BUILDROBOT] Bootstrap broken in Ada (was: [patch] header file re-ordering.) Jan-Benedict Glaw
2015-10-11 22:27 ` [BUILDROBOT] Bootstrap broken in Ada Jeff Law
2015-10-11 22:35 ` Jan Hubicka
2015-10-12 8:04 ` [patch] header file re-ordering Jeff Law
2015-10-14 14:05 ` Andrew MacLeod
2015-10-19 21:05 ` Jeff Law
2015-10-16 19:52 ` config header file reduction patch checked in Andrew MacLeod
2015-10-16 20:17 ` Andrew MacLeod
2015-10-18 9:34 ` Iain Sandoe
2015-10-19 15:55 ` Andrew MacLeod
2015-10-23 17:02 ` Bernd Schmidt
2015-10-23 17:22 ` Mike Stump
2015-10-23 17:26 ` Bernd Schmidt
2015-10-23 17:36 ` Andrew MacLeod
2015-10-23 17:49 ` Mike Stump [this message]
2015-10-23 17:39 ` Mike Stump
2015-10-22 21:07 ` [patch] header file re-ordering Jeff Law
2015-10-22 21:21 ` Andrew MacLeod
2015-10-22 22:25 ` Jeff Law
2015-10-23 19:14 ` Jeff Law
2015-10-23 19:28 ` Andrew MacLeod
2015-10-22 22:33 ` [patch 1/3] Header file reduction - backend files Jeff Law
2015-10-22 22:36 ` Andrew MacLeod
2015-10-23 6:22 ` Jeff Law
2015-10-23 12:26 ` Andrew MacLeod
2015-10-23 15:15 ` Jeff Law
2015-10-23 16:30 ` Andrew MacLeod
2015-10-02 2:33 ` [patch 2/3] Header file reduction - config files Andrew MacLeod
2015-10-02 2:33 ` [patch 3/3] Header file reduction - FE files Andrew MacLeod
2015-10-05 13:55 ` [patch 0/3] Header file reduction Bernd Schmidt
2015-10-05 14:10 ` Richard Biener
2015-10-05 20:10 ` Andrew MacLeod
2015-10-05 20:37 ` Bernd Schmidt
2015-10-05 21:11 ` Andrew MacLeod
2015-10-06 3:03 ` [patch 0/3] Header file reduction. - unified patches Andrew MacLeod
2015-10-06 21:55 ` [patch 0/3] Header file reduction Jeff Law
2015-10-06 21:44 ` Jeff Law
2015-10-07 8:16 ` Richard Biener
2015-10-08 15:48 ` Michael Matz
2015-10-05 21:18 ` [patch 4/3] Header file reduction - Tools for contrib Andrew MacLeod
2015-10-06 10:27 ` Bernd Schmidt
2015-10-06 12:02 ` Bernd Schmidt
2015-10-06 14:04 ` Andrew MacLeod
2015-10-06 14:57 ` Bernd Schmidt
2015-10-06 19:19 ` Andrew MacLeod
2015-10-06 20:37 ` Bernd Schmidt
2015-10-06 21:30 ` Jeff Law
2015-10-06 22:43 ` Andrew MacLeod
2015-10-06 21:27 ` Jeff Law
2015-10-06 16:32 ` Joseph Myers
2015-10-06 19:18 ` Andrew MacLeod
2015-10-07 16:35 ` Andrew MacLeod
2015-10-14 15:14 ` [patch 4/3] Header file reduction - Tools for contrib - second cut Andrew MacLeod
2015-11-03 6:06 ` Jeff Law
2015-11-03 13:24 ` Andrew MacLeod
2015-11-03 14:00 ` Jeff Law
2015-11-03 14:19 ` Andrew MacLeod
2015-11-10 21:16 ` Jeff Law
2015-10-08 16:31 ` [patch 4/3] Header file reduction - Tools for contrib David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC7897B-269E-4CE4-BC4C-F1F83975B8ED@comcast.net \
--to=mikestump@comcast.net \
--cc=amacleod@redhat.com \
--cc=bschmidt@redhat.com \
--cc=dominiq@lps.ens.fr \
--cc=gcc-patches@gcc.gnu.org \
--cc=iain@codesourcery.com \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).