On 05/05/2010 02:11 PM, Richard Earnshaw wrote:
> 
> On Wed, 2010-05-05 at 13:44 +0200, Bernd Schmidt wrote:
>> In the hope of moving this along, here's a smaller patch with pieces
>> that do not introduce functional changes, but reorganize the code a
>> little in preparation for the full patch.  I hope this will make review
>> easier.
>>
>> Tested on
>> arm-linux-gnueabi(qemu-system-armv7{arch=armv7-a/thumb,thumb,}).  Ok?
>>
>>
>> Bernd
>>
> 
> Rather than need_add, I think it would be better to pass the offset.
> There are times when the offset can't be done with a single add insn,
> and we can't tell that if this is just a boolean (but it might still be
> profitable in those cases).
> 
> Ok apart from that.

Thanks.  Here's what I committed after some sanity tests.


Bernd