Re: [PATCH C/C++] Fix some diagnostics problems

[Shujing Zhao <pearly.zhao@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 2233 bytes --]

On 06/05/2010 09:18 PM, Joseph S. Myers wrote:
> On Fri, 4 Jun 2010, Shujing Zhao wrote:
> 
>> Hi,
>>
>> This patch is to cleanup the codes that pass ("%s", message) to diagnostic
>> functions, such as error, warning etc. If there some format specifiers in
>> 'message', they would not be recognized. If it need be translated, 'message'
>> need be wrapped with _() explicitly, while 'message' could be translated in
>> diagnostic functions. I thinks pass the 'message' directly to those functions
>> would be better.
> 
> The Ubuntu etc. people enabling -Wformat-security by default will dislike 
> this sort of change.  I disagree with their choice, but it should be 
> possible to fix i18n issues in a way that is simultaneously friendly to 
> -Wformat-security - in particular, including strings directly in 
> diagnostic function calls whenever possible so that they can actually be 
> checked at compile time.
> 
> This patch suffers from doing far too many things at once.  Some bits 
> might be OK, but various parts are wrong, meaning the whole patch has to 
> be rejected.  Please submit patches that do just one thing and cannot 
> sensibly be subdivided into smaller patches.
> 
> As examples of the things done wrong, strsignal returns a *string* that is 
> not a *format string* and that it is definitely incorrect to treat as a 
> format string.  %e and %n specs are not documented (in the comment in 
> gcc.c that documents specs, or in the unfortunate duplicate documentation 
> in invoke.texi) as taking format strings; if you change the 
> implementation, you must change the interface documentation.  Likewise for 
> other cases of action at a distance in this patch: if you change something 
> from a verbatim string to a format string at the site where the string is 
> called, you must make sure the interface documentation describes this 
> change, and that the relevant strings are marked as gcc-internal-format in 
> gcc.pot to indicate this to translators, and confirm that you have checked 
> that this is appropriate for all callers.
> 
Ok. Since there is no obvious requirement to change them, I only take out the 
part that fixes the existing 18n problems.
The following is the patch for C frontend.




[-- Attachment #2: ChangeLog1 --]
[-- Type: text/plain, Size: 241 bytes --]

2010-06-07  Shujing Zhao  <pearly.zhao@oracle.com>

	* fold-const.c (fold_comparison): Remove redundant parenthesis.
	* tree-inline.c (expand_call_inline): Pass translated return value of
	cgraph_inline_failed_string to diagnostic function.

[-- Attachment #3: part1.patch --]
[-- Type: text/x-patch, Size: 1472 bytes --]

Index: tree-inline.c
===================================================================
--- tree-inline.c	(revision 160130)
+++ tree-inline.c	(working copy)
@@ -3774,7 +3774,7 @@ expand_call_inline (basic_block bb, gimp
 	  && cgraph_global_info_ready)
 	{
 	  sorry ("inlining failed in call to %q+F: %s", fn,
-		 cgraph_inline_failed_string (reason));
+		 _(cgraph_inline_failed_string (reason)));
 	  sorry ("called from here");
 	}
       else if (warn_inline && DECL_DECLARED_INLINE_P (fn)
@@ -3785,7 +3785,7 @@ expand_call_inline (basic_block bb, gimp
 	       && cgraph_global_info_ready)
 	{
 	  warning (OPT_Winline, "inlining failed in call to %q+F: %s",
-		   fn, cgraph_inline_failed_string (reason));
+		   fn, _(cgraph_inline_failed_string (reason)));
 	  warning (OPT_Winline, "called from here");
 	}
       goto egress;
Index: fold-const.c
===================================================================
--- fold-const.c	(revision 160130)
+++ fold-const.c	(working copy)
@@ -8651,9 +8651,9 @@ fold_comparison (location_t loc, enum tr
 	  && (TREE_CODE (lhs) != INTEGER_CST
 	      || !TREE_OVERFLOW (lhs)))
 	{
-	  fold_overflow_warning (("assuming signed overflow does not occur "
+	  fold_overflow_warning ("assuming signed overflow does not occur "
 				  "when changing X +- C1 cmp C2 to "
-				  "X cmp C1 +- C2"),
+				  "X cmp C1 +- C2",
 				 WARN_STRICT_OVERFLOW_COMPARISON);
 	  return fold_build2_loc (loc, code, type, variable, lhs);
 	}