From: Jason Merrill <jason@redhat.com>
To: IainS <developer@sandoe-acoustics.co.uk>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
"Joseph S. Myers" <joseph@codesourcery.com>
Subject: Re: [Patch c++] (__attribute__((deprecated)), part a) Fix PR17729
Date: Tue, 08 Jun 2010 23:12:00 -0000 [thread overview]
Message-ID: <4C0EC931.6010106@redhat.com> (raw)
In-Reply-To: <8E1F6759-A426-494D-8B3B-58FDF04BFB1A@sandoe-acoustics.co.uk>
On 04/17/2010 07:16 AM, IainS wrote:
> PR c++/17729
> * typeck.c(build_class_member_access_expr): Don't check for deprecation
> here.
I believe this will cause false negatives on template code.
> * call.c(build_call_a): Ditto.
> (build_over_call): Ditto.
> (convert_like_real): Check for deprecation here instead.
> (build_new_method_call): Ditto.
And these cause false negatives on overloaded functions. We really need
to handle functions in build_call_a and build_over_call, since that's
when we know which function we're actually calling in the case of
function overloading. In the testcase, if you add a non-deprecated
func(int), you get no warning about calling the deprecated func(void).
The testcase also doesn't test member functions at all.
Sorry for the slow review; please feel free to ping me directly on C++
patches.
Jason
next prev parent reply other threads:[~2010-06-08 22:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-17 12:47 IainS
2010-06-08 23:12 ` Jason Merrill [this message]
2010-06-09 0:26 ` IainS
2010-06-09 3:29 ` Jason Merrill
2010-07-19 17:11 ` IainS
2010-07-19 17:59 ` Jason Merrill
2010-07-21 13:43 ` IainS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C0EC931.6010106@redhat.com \
--to=jason@redhat.com \
--cc=developer@sandoe-acoustics.co.uk \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).