From: Paolo Bonzini <bonzini@gnu.org>
To: Jan Hubicka <hubicka@ucw.cz>
Cc: gcc-patches@gcc.gnu.org, rguenther@suse.de,
Laurynas Biveinis <laurynas.biveinis@gmail.com>
Subject: Re: Make gimple.h checks conditional with ENABLE_GIMPLE_CHECKING
Date: Wed, 09 Jun 2010 10:05:00 -0000 [thread overview]
Message-ID: <4C0F63E6.4020709@gnu.org> (raw)
In-Reply-To: <20100608225711.GA15770@kam.mff.cuni.cz>
On 06/09/2010 12:57 AM, Jan Hubicka wrote:
> Hi,
> this patch conditionalize the sanity checks in gimple accessor functions.
> I originally intended to go through my list of most frequent aborts remianing
> in the code, but it seems now to me that it would cause just maintenance
> problems since it would be difficult to decide what to check and what not.
>
> The nature of the checks is very similar to the tree/rtl and gimple checking
> so I think we should just handle them same way and put them all into
> ENABLE_GIMPLE_CHECKING
>
> Bootstrapped/regtested x86_64-linux. My build time test actually regressed
> to 11m16s (it used to be 10m19s), but I am quite convinced it is due to
> merge of df-improv branch
> OK?
Laurynas, can you check? I understood the gc-improv branch was basically
just cleanup, instead Jan's numbers say we're regressing 10%?
Paolo
next prev parent reply other threads:[~2010-06-09 9:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 23:13 Jan Hubicka
2010-06-09 6:13 ` Basile Starynkevitch
2010-06-09 8:37 ` Manuel López-Ibáñez
2010-06-09 9:31 ` Richard Guenther
2010-06-09 9:29 ` Richard Guenther
2010-06-09 9:47 ` Jakub Jelinek
2010-06-09 11:15 ` Jan Hubicka
2010-06-09 11:25 ` Jakub Jelinek
2010-06-09 11:30 ` Richard Guenther
2010-06-09 10:05 ` Paolo Bonzini [this message]
2010-06-09 10:05 ` Laurynas Biveinis
2010-06-09 10:12 ` Paolo Bonzini
2010-06-09 10:50 ` Jan Hubicka
2010-06-09 11:14 ` Paolo Bonzini
2010-06-09 19:11 ` Jan Hubicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C0F63E6.4020709@gnu.org \
--to=bonzini@gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=laurynas.biveinis@gmail.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).