From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-264950-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 2141 invoked by alias); 11 Jun 2010 04:01:35 -0000
Received: (qmail 2057 invoked by uid 22791); 11 Jun 2010 04:01:34 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY
X-Spam-Check-By: sourceware.org
Received: from rcsinet10.oracle.com (HELO rcsinet10.oracle.com) (148.87.113.121)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Jun 2010 04:01:29 +0000
Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227])	by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o5B41Oit008645	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 11 Jun 2010 04:01:25 GMT
Received: from acsmt353.oracle.com (acsmt353.oracle.com [141.146.40.153])	by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o5B1NM1A005756;	Fri, 11 Jun 2010 04:01:23 GMT
Received: from abhmt013.oracle.com by acsmt354.oracle.com	with ESMTP id 316089661276228778; Thu, 10 Jun 2010 20:59:38 -0700
Received: from dhcp-beijing-cdc-10-182-121-28.cn.oracle.com (/10.182.121.28)	by default (Oracle Beehive Gateway v4.0)	with ESMTP ; Thu, 10 Jun 2010 20:59:38 -0700
Message-ID: <4C11B4BB.5060102@oracle.com>
Date: Fri, 11 Jun 2010 06:02:00 -0000
From: Shujing Zhao <pearly.zhao@oracle.com>
User-Agent: Thunderbird 2.0.0.24 (X11/20100228)
MIME-Version: 1.0
To: Jason Merrill <jason@redhat.com>
CC: Joseph <joseph@codesourcery.com>, Gcc-Patches <gcc-patches@gcc.gnu.org>,        Paolo Carlini <paolo.carlini@oracle.com>
Subject: Re: [PATCH C/C++] Fix some diagnostics problems
References: <4C0DC2B4.3080200@oracle.com> <4C0E94C8.4070807@redhat.com> <4C0F4D3A.6010207@oracle.com> <4C0F8F5B.9000208@redhat.com> <4C10874E.9030400@oracle.com> <4C10DED2.7060600@redhat.com>
In-Reply-To: <4C10DED2.7060600@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2010-06/txt/msg01173.txt.bz2

On 06/10/2010 08:47 PM, Jason Merrill wrote:
> On 06/10/2010 02:33 AM, Shujing Zhao wrote:
>> +        permerror (input_location, "member initializer expression "
>> +                           "list treated as compound expression");
> 
> expression list treated as compound expression in mem-initializer
> 
>> +      case ELK_FUNC_CAST:
>> +        permerror (input_location, "functional cast expression "
>> +                           "list treated as compound expression");
> 
> expression list treated as compound expression in functional cast
> 
Ok.
>> +        warning (OPT_Wmissing_format_attribute,
>> +             "target of argument passing might be a candidate "
>> +             "for a format attribute");
> 
> parameter might be...
> 
>> +        warning (OPT_Wmissing_format_attribute,
>> +             "default argument might be a candidate "
>> +             "for a format attribute");
> 
> parameter might be...

Ok. Fix this part to

+           case ICR_ARGPASS:
+           case ICR_DEFAULT_ARGUMENT:
+             if (fndecl)
+               warning (OPT_Wmissing_format_attribute,
+                        "parameter %d of %qD might be a candidate "
+                        "for a format attribute", parmnum, fndecl);
+             else
+               warning (OPT_Wmissing_format_attribute,
+                        "parameter might be a candidate "
+                        "for a format attribute");
+             break;


Committed to trunk at revision 160591.

Thanks
Pearly