From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14361 invoked by alias); 17 Jun 2010 15:51:23 -0000 Received: (qmail 14353 invoked by uid 22791); 17 Jun 2010 15:51:21 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 17 Jun 2010 15:51:17 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5HFpFkL005732 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 17 Jun 2010 11:51:16 -0400 Received: from stone.twiddle.home (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o5HFpFA5001790; Thu, 17 Jun 2010 11:51:15 -0400 Message-ID: <4C1A4460.7@redhat.com> Date: Thu, 17 Jun 2010 16:19:00 -0000 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-3.fc13 Thunderbird/3.0.4 MIME-Version: 1.0 To: Aldy Hernandez CC: Pascal Felber , MARLIER Patrick , gcc-patches@gcc.gnu.org Subject: Re: [trans-mem] verify_ssa failed with noreturn attribute function References: <4C0CD1FF.3080601@unine.ch> <20100608134559.GA3066@redhat.com> <4C0E690C.8010005@redhat.com> <2AD1C955-250B-44D6-87CD-0B1B72CAB7E6@unine.ch> <20100609202831.GA12470@redhat.com> <20100610111211.GB15138@redhat.com> In-Reply-To: <20100610111211.GB15138@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-06/txt/msg01799.txt.bz2 On 06/10/2010 04:12 AM, Aldy Hernandez wrote: >> I don't understand why we only update the SSA on safe function calls in >> ipa_tm_insert_gettmclone_call(), especially since >> ipa_tm_insert_gettmclone_call() calls update_stmt() at the end, which >> may possibly dirty the SSA web. IMO, we should always return true, >> which is the approach I take below. I don't recall the logic behind only updating if safe. It does look wrong now though. >> Another option is returning need_ssa_update_p(), or better yet, just >> call update_ssa() only if need_ssa_update_p() returns true and get rid >> of keeping track of need_ssa_rename altogether. Those do look like attractive options. >> * trans-mem.c (ipa_tm_insert_gettmclone_call): Always return true. Ok. r~