From: Shujing Zhao <pearly.zhao@oracle.com>
To: "Manuel López-Ibáñez" <lopezibanez@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
"Joseph S. Myers" <joseph@codesourcery.com>,
Paolo Carlini <paolo.carlini@oracle.com>
Subject: Re: [PATCH C] Fix pr44517
Date: Tue, 22 Jun 2010 09:57:00 -0000 [thread overview]
Message-ID: <4C207C95.8040309@oracle.com> (raw)
In-Reply-To: <AANLkTik-Awt-Hx2p9gAzaslgpyAswbkRBLIZDooIcRRL@mail.gmail.com>
On 06/22/2010 03:40 PM, Manuel López-Ibáñez wrote:
> On 22 June 2010 09:05, Shujing Zhao <pearly.zhao@oracle.com> wrote:
>> Hi,
>>
>> This patch tries to improve diagnostic for wrong type name in function
>> declaration. It also changes the algorithm of function
>> c_parser_parms_list_declarator. If one of parameter declaration is wrong,
>> c_parser_parms_list_declarator would return NULL, not an empty parameter
>> information struct. A test case is added to test this change.
>>
>
> Great! One minor nit:
>
> - }
> + return false;
> }
>
> This should be return NULL.
>
> Don't need to send a new patch for this. Just wait for approval.
Oops, sorry. Gcc didn't detect it, is it because both 'false' and 'NULL' are 0?
is it a bug?
Thanks
Pearly
next prev parent reply other threads:[~2010-06-22 9:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-22 8:14 Shujing Zhao
2010-06-22 8:49 ` Manuel López-Ibáñez
2010-06-22 9:57 ` Shujing Zhao [this message]
2010-06-22 10:00 ` Manuel López-Ibáñez
2010-06-22 13:36 ` Joseph S. Myers
2010-06-23 9:17 ` Shujing Zhao
2010-06-23 9:31 ` Manuel López-Ibáñez
2010-06-23 9:55 ` Shujing Zhao
2010-06-23 12:24 ` Joseph S. Myers
2010-06-23 12:28 ` Manuel López-Ibáñez
2010-06-23 12:41 ` Joseph S. Myers
2010-06-24 10:50 ` Shujing Zhao
2010-06-24 11:56 ` Joseph S. Myers
2010-06-25 10:02 ` Shujing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C207C95.8040309@oracle.com \
--to=pearly.zhao@oracle.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=lopezibanez@gmail.com \
--cc=paolo.carlini@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).