From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-265909-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 2340 invoked by alias); 22 Jun 2010 09:05:11 -0000
Received: (qmail 2251 invoked by uid 22791); 22 Jun 2010 09:05:10 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY
X-Spam-Check-By: sourceware.org
Received: from rcsinet10.oracle.com (HELO rcsinet10.oracle.com) (148.87.113.121)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Jun 2010 09:05:02 +0000
Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227])	by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id o5M94seW004710	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 22 Jun 2010 09:04:56 GMT
Received: from acsmt353.oracle.com (acsmt353.oracle.com [141.146.40.153])	by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o5M4L9cF001851;	Tue, 22 Jun 2010 09:04:54 GMT
Received: from abhmt006.oracle.com by acsmt354.oracle.com	with ESMTP id 362922141277197462; Tue, 22 Jun 2010 02:04:22 -0700
Received: from dhcp-beijing-cdc-10-182-121-28.cn.oracle.com (/10.182.121.28)	by default (Oracle Beehive Gateway v4.0)	with ESMTP ; Tue, 22 Jun 2010 02:04:19 -0700
Message-ID: <4C207C95.8040309@oracle.com>
Date: Tue, 22 Jun 2010 09:57:00 -0000
From: Shujing Zhao <pearly.zhao@oracle.com>
User-Agent: Thunderbird 2.0.0.24 (X11/20100228)
MIME-Version: 1.0
To: =?ISO-8859-1?Q?Manuel_L=F3pez-Ib=E1=F1ez?= <lopezibanez@gmail.com>
CC: GCC Patches <gcc-patches@gcc.gnu.org>,        "Joseph S. Myers" <joseph@codesourcery.com>,        Paolo Carlini <paolo.carlini@oracle.com>
Subject: Re: [PATCH C] Fix pr44517
References: <4C2060CC.3040401@oracle.com> <AANLkTik-Awt-Hx2p9gAzaslgpyAswbkRBLIZDooIcRRL@mail.gmail.com>
In-Reply-To: <AANLkTik-Awt-Hx2p9gAzaslgpyAswbkRBLIZDooIcRRL@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2010-06/txt/msg02132.txt.bz2

On 06/22/2010 03:40 PM, Manuel López-Ibáñez wrote:
> On 22 June 2010 09:05, Shujing Zhao <pearly.zhao@oracle.com> wrote:
>> Hi,
>>
>> This patch tries to improve diagnostic for wrong type name in function
>> declaration. It also changes the algorithm of function
>> c_parser_parms_list_declarator. If one of parameter declaration is wrong,
>> c_parser_parms_list_declarator would return NULL, not an empty parameter
>> information struct. A test case is added to test this change.
>>
> 
> Great! One minor nit:
> 
> -		}
> +		return false;
>  	    }
> 
> This should be return NULL.
> 
> Don't need to send a new patch for this. Just wait for approval.

Oops, sorry. Gcc didn't detect it, is it because both 'false' and 'NULL' are 0? 
is it a bug?

Thanks
Pearly