From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30857 invoked by alias); 22 Jun 2010 10:00:15 -0000 Received: (qmail 30835 invoked by uid 22791); 22 Jun 2010 10:00:14 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from vsmtp14.tin.it (HELO vsmtp14.tin.it) (212.216.176.118) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Jun 2010 10:00:06 +0000 Received: from [192.168.0.4] (79.53.234.73) by vsmtp14.tin.it (8.5.113) id 4BCE303705F0E2FB; Tue, 22 Jun 2010 11:59:58 +0200 Message-ID: <4C20899B.7020205@oracle.com> Date: Tue, 22 Jun 2010 10:19:00 -0000 From: Paolo Carlini User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100317 SUSE/3.0.4-1.1.1 Thunderbird/3.0.4 MIME-Version: 1.0 To: stephen.webb@bregmasoft.ca CC: "Stephen M. Webb" , gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Subject: Re: [v3] implementation foundation, version 2 References: <201006211458.23787.stephenw.webb@bregmasoft.ca> In-Reply-To: <201006211458.23787.stephenw.webb@bregmasoft.ca> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-06/txt/msg02139.txt.bz2 On 06/21/2010 08:58 PM, Stephen M. Webb wrote: > Version 2 of , now with the following: > > o long lines have been fixed > o everything is now in headers (no ABI failures from library) > o more test cases > Thanks. Please add definiitions for those const static data members, I'm not comfortable with playing such undefined behavior tricks just to spare a few lines, in these times of whole program optimization, etc. It's risky. I may bu guilty myself of some in the past, that's not an excuse. Another change we should make, *.tcc files, by definition host *out of line* functions: thus, the functions which we decided, for now at least, to have inline in headers, should be simply defined in the class body, in the *.h file. In any case, stuff like the _State constructors should be inline anyway. I'm also seeing _M_lookup_classname, for example, out of line, and it's also tiny. In general, remember, in our library *tiny* functions are inline, and defined in the class body itself, in the *.h file. Thanks, Paolo.