From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-265922-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 27223 invoked by alias); 22 Jun 2010 10:19:01 -0000
Received: (qmail 27203 invoked by uid 22791); 22 Jun 2010 10:19:01 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE
X-Spam-Check-By: sourceware.org
Received: from vsmtp14.tin.it (HELO vsmtp14.tin.it) (212.216.176.118)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Jun 2010 10:18:58 +0000
Received: from [192.168.0.4] (79.53.234.73) by vsmtp14.tin.it (8.5.113)        id 4BCE303705F1360B; Tue, 22 Jun 2010 12:18:51 +0200
Message-ID: <4C208E02.4040008@oracle.com>
Date: Tue, 22 Jun 2010 11:17:00 -0000
From: Paolo Carlini <paolo.carlini@oracle.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100317 SUSE/3.0.4-1.1.1 Thunderbird/3.0.4
MIME-Version: 1.0
To: stephen.webb@bregmasoft.ca
CC: "Stephen M. Webb" <stephenw.webb@bregmasoft.ca>,  gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [v3] <regex> implementation foundation, version 2
References: <201006211458.23787.stephenw.webb@bregmasoft.ca> <4C20899B.7020205@oracle.com>
In-Reply-To: <4C20899B.7020205@oracle.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2010-06/txt/msg02145.txt.bz2

... stylistically, SMW_IMPLEMENT_LATER should be uglified as
_SMW_IMPLEMENT_LATER; more important, never a comma at the beginning of
a line, I see that problem quite a few times in constructors, for the
commas separating the initializers.

Paolo.