From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp001-out.apm-internet.net (smtp001-out.apm-internet.net [85.119.248.222]) by sourceware.org (Postfix) with ESMTPS id E88373858402 for ; Mon, 13 Sep 2021 19:04:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E88373858402 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sandoe.co.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=sandoe.co.uk Received: (qmail 70429 invoked from network); 13 Sep 2021 19:04:21 -0000 X-APM-Out-ID: 16315598607042 X-APM-Authkey: 257869/1(257869/1) 5 Received: from unknown (HELO ?192.168.1.214?) (81.138.1.83) by smtp001.apm-internet.net with SMTP; 13 Sep 2021 19:04:21 -0000 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: [PATCH] Remove DARWIN_PREFER_DWARF and dead code From: Iain Sandoe In-Reply-To: Date: Mon, 13 Sep 2021 20:04:17 +0100 Cc: Richard Biener , gcc-patches@gcc.gnu.org Content-Transfer-Encoding: quoted-printable Message-Id: <4C33D1BA-2ACC-4846-AABD-1353D22B5BC0@sandoe.co.uk> References: <56ros87-62r2-rsr0-8p73-56r6265q6261@fhfr.qr> To: Jeff Law X-Mailer: Apple Mail (2.3445.104.21) X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00, KAM_COUK, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Sep 2021 19:04:24 -0000 Hi Folks > On 10 Sep 2021, at 16:16, Jeff Law wrote: > On 9/10/2021 1:19 AM, Richard Biener via Gcc-patches wrote: >> This removes the always defined DARWIN_PREFER_DWARF and the code >> guarded by it being not defined, removing the possibility to >> default some i386 darwin configurations to STABS when it would >> not be defined. >>=20 >> OK for trunk? >>=20 >> Thanks, >> Richard. >>=20 >> 2021-09-10 Richard Biener >>=20 >> * config/darwin.h (DARWIN_PREFER_DWARF): Do not define. >> * config/i386/darwin.h (PREFERRED_DEBUGGING_TYPE): Do not >> change based on DARWIN_PREFER_DWARF not being defined. Sorry, was OOO and without sensible connection. As you saw I was part way through ripping out stabs for Darwin (I = disabled it on the last cycle, but with an easy route to re-enabling = should there be any fallout) - no one has complained - so the patch = ought to be fine. > OK. I'm not too worried about supporting 32bit darwin 8 and earlier. = That's got to be at least a decade out of service at this point The Darwin maintainers have had a policy of not breaking older versions = on purpose (and I have gone along with that for now) - but if you want = to build on anything older than Darwin8 expect to have to build a whole = bunch of supporting tools first to support the bootstrap=E2=80=A6 For the record, Darwin8 works fine for GCC11 - and I=E2=80=99d not = expect a problem with GCC12 (so far) - there will come a point that we = want to default to using embedded rpaths, which it doesn=E2=80=99t = support so we shall see what options there are then. Iain