From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23451 invoked by alias); 8 Jul 2010 17:15:40 -0000 Received: (qmail 23442 invoked by uid 22791); 8 Jul 2010 17:15:39 -0000 X-SWARE-Spam-Status: No, hits=-5.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Jul 2010 17:15:28 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o68HFQr3023608 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 8 Jul 2010 13:15:26 -0400 Received: from anchor.twiddle.home (vpn-227-19.phx2.redhat.com [10.3.227.19]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o68HFPIQ012673; Thu, 8 Jul 2010 13:15:26 -0400 Message-ID: <4C3607AD.50406@redhat.com> Date: Thu, 08 Jul 2010 17:15:00 -0000 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Thunderbird/3.0.5 MIME-Version: 1.0 To: Ira Rosen CC: gcc-patches@gcc.gnu.org Subject: Re: [RFC] [patch] Support vectorization of min/max location pattern References: <4C34E6CF.4030608@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-07/txt/msg00695.txt.bz2 On 07/08/2010 12:33 AM, Ira Rosen wrote: >> (1) The documentation should go into the DEFHOOK. > > I am sorry, but I don't understand what you mean. DEFHOOK (builtin_vect_compare, "This hook returns a target builtin..." tree, (unsigned code, tree type, tree *return_type), NULL) For new code, the only thing that goes in tm.texi.in is @hook TARGET_VECTORIZE_BUILTIN_VECT_COMPARE > BUILTIN_VECT_COMPARE is used for location and not for MIN/MAX. There > are two statements to vectorize: min/max and location computation. > And min/max is vectorized as you described. Location has different > types in condition (float) and then/else (integer). Ah, well it seems I didn't really know what I was reviewing. What is "location computation" in this context? r~