From: Richard Henderson <rth@redhat.com>
To: Joern Rennecke <amylaar@spamcop.net>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: RFA: Fix rtl-optimization/44752
Date: Mon, 12 Jul 2010 15:48:00 -0000 [thread overview]
Message-ID: <4C3B3921.5000908@redhat.com> (raw)
In-Reply-To: <20100712025447.bk905yd5u8cww40c-nzlynne@webmail.spamcop.net>
> PR rtl-optimization/44752
> * genautomata.c (main): Don't emit an empty file even if there
> is no automaton.
Ok, but ...
> + else
> + puts ("/* Generated automatically by the program `genautomata'\n"
> + " from the machine description file `md'. */\n\n"
> + "/* There is no automaton, but ISO C forbids empty\n"
> + " translation units, so include a header file with some\n"
> + " declarations, and the its pre-requisite header file. */\n"
> + "#include \"config.h\"\n"
> + "#include \"system.h\"\n");
... I'd prefer { } around this large multi-line statement.
r~
prev parent reply other threads:[~2010-07-12 15:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 6:54 Joern Rennecke
2010-07-12 15:48 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3B3921.5000908@redhat.com \
--to=rth@redhat.com \
--cc=amylaar@spamcop.net \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).