From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-268147-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 1553 invoked by alias); 14 Jul 2010 11:49:20 -0000
Received: (qmail 1544 invoked by uid 22791); 14 Jul 2010 11:49:19 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE
X-Spam-Check-By: sourceware.org
Received: from mail-ww0-f51.google.com (HELO mail-ww0-f51.google.com) (74.125.82.51)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Jul 2010 11:49:15 +0000
Received: by wwb13 with SMTP id 13so1557130wwb.8        for <gcc-patches@gcc.gnu.org>; Wed, 14 Jul 2010 04:49:12 -0700 (PDT)
Received: by 10.216.231.26 with SMTP id k26mr6832209weq.3.1279108152685;        Wed, 14 Jul 2010 04:49:12 -0700 (PDT)
Received: from [192.168.2.99] (cpc2-cmbg8-0-0-cust61.cmbg.cable.ntl.com [82.6.108.62])        by mx.google.com with ESMTPS id m24sm3065364wej.23.2010.07.14.04.49.11        (version=SSLv3 cipher=RC4-MD5);        Wed, 14 Jul 2010 04:49:11 -0700 (PDT)
Message-ID: <4C3DA923.8030509@gmail.com>
Date: Wed, 14 Jul 2010 11:49:00 -0000
From: Dave Korn <dave.korn.cygwin@gmail.com>
User-Agent: Thunderbird 2.0.0.17 (Windows/20080914)
MIME-Version: 1.0
To: Kai Tietz <ktietz70@googlemail.com>
CC: Richard Henderson <rth@redhat.com>,  GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch i386]: Add for win32 targets pre-prologue profiling 	feature
References: <AANLkTimkEGrAkpdvwlTFV-Ad1wBUIQ02PV_8VG5BBRM9@mail.gmail.com>	<4C3C942D.3010101@redhat.com> <AANLkTincDxzbxpCAMMiBbv52X2G3tE5lgortV820BqVq@mail.gmail.com>
In-Reply-To: <AANLkTincDxzbxpCAMMiBbv52X2G3tE5lgortV820BqVq@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2010-07/txt/msg01143.txt.bz2

On 14/07/2010 11:20, Kai Tietz wrote:

> 	* config/i386/cygming.h (PROFILE_SUPPORT_BEFORE_PROLOGUE): New.
> 	(MCOUNT_NAME): Win32 specific version.

> +
> +/* Choose the correct profiler mcount name. For checking we are using the
> +   ix86_profile_before_prologue function as flag_profile_top is tri-state.  */
> +#undef MCOUNT_NAME
> +#define MCOUNT_NAME (ix86_profile_before_prologue () ? "_mcount_top" : "_mcount")
> +
>  #if ! defined (USE_MINGW64_LEADING_UNDERSCORES)
>  #undef USER_LABEL_PREFIX
>  #define USER_LABEL_PREFIX (TARGET_64BIT ? "" : "_")


  Shouldn't MCOUNT_NAME take USER_LABEL_PREFIX into account?

    cheers,
      DaveK