From: Richard Henderson <rth@redhat.com>
To: IainS <developer@sandoe-acoustics.co.uk>
Cc: gcc-patches List <gcc-patches@gcc.gnu.org>,
mrs@gcc.gnu.org, Uros Bizjak <ubizjak@gmail.com>,
David Edelsohn <dje.gcc@gmail.com>
Subject: Re: [Patch, darwin] do not generate branch islands when the linker can do it.
Date: Thu, 15 Jul 2010 17:38:00 -0000 [thread overview]
Message-ID: <4C3F478D.4060405@redhat.com> (raw)
In-Reply-To: <01CDBBB5-4E03-4483-ADCC-454819159375@sandoe-acoustics.co.uk>
On 07/15/2010 10:10 AM, IainS wrote:
> - if (! TARGET_MACHO || TARGET_64BIT)
> + if (! TARGET_MACHO ||
> +#if TARGET_MACHO
> + ! darwin_emit_branch_islands ||
> +#endif
> + TARGET_64BIT)
I'd really like to avoid the #if mid if. Perhaps
if (TARGET_64BIT || !TARGET_MACHO_BRANCH_ISLANDS)
with
#if TARGET_MACHO
#define TARGET_MACHO_BRANCH_ISLANDS darwin_emit_branch_islands
#else
#define TARGET_MACHO_BRANCH_ISLANDS 0
#endif
or similar via #undef.
r~
next prev parent reply other threads:[~2010-07-15 17:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 17:10 IainS
2010-07-15 17:38 ` Richard Henderson [this message]
2010-07-15 18:27 ` IainS
2010-07-15 18:44 ` Richard Henderson
2010-07-15 19:34 ` IainS
2010-07-17 18:10 ` IainS
2010-07-18 13:08 ` David Edelsohn
2010-07-18 13:20 ` Iain Sandoe
2010-07-18 18:18 ` Mike Stump
2010-07-19 9:13 ` IainS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3F478D.4060405@redhat.com \
--to=rth@redhat.com \
--cc=developer@sandoe-acoustics.co.uk \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mrs@gcc.gnu.org \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).