From: Richard Henderson <rth@redhat.com>
To: Kai Tietz <ktietz70@googlemail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
NightStrike <nightstrike@gmail.com>
Subject: Re: [RFA patch i386]: Prepare x64 prologue using positive offsets for frame-pointer
Date: Tue, 20 Jul 2010 22:57:00 -0000 [thread overview]
Message-ID: <4C4629D2.1050303@redhat.com> (raw)
In-Reply-To: <AANLkTimlHjLUm2w21EU0IP-wHz_jBA0kqchU6cgH4TNX@mail.gmail.com>
On 07/18/2010 03:42 AM, Kai Tietz wrote:
> +mframe-x64
> +Target Report Var(flag_framex64) Init(0)
> +Set the frame-pointer to the stack location at the end of prologue for 64-bit.
Modulo testing purposes, a command-line switch makes no sense. We'll want to
key this off SEH enabled, or at least TARGET_64BIT_MS_ABI.
The state of ix86_expand_prologue/epilogue is... what's a kind word... chaotic?
This isn't your fault, but your patch doesn't help either. It's extremely
difficult to tell if your patch is correct. I'm pretty sure it isn't correct
for any case of stack re-alignment, for instance.
I spent an hour or three attempting to tidy up these functions and handle the
frame pointer at the bottom of the frame. I have some ideas now for how to
clean things up, but I think they'll really need to be staged in in phases.
One big patch would simply be too unwieldy.
I'll work on this cleanup over the next couple of days.
r~
next prev parent reply other threads:[~2010-07-20 22:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-04 21:06 Kai Tietz
2010-07-05 6:18 ` Kai Tietz
2010-07-14 19:29 ` NightStrike
2010-07-18 10:42 ` Kai Tietz
2010-07-20 22:57 ` Richard Henderson [this message]
2010-07-21 7:43 ` Kai Tietz
2010-07-21 17:36 ` Richard Henderson
2010-07-21 18:06 ` Kai Tietz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C4629D2.1050303@redhat.com \
--to=rth@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ktietz70@googlemail.com \
--cc=nightstrike@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).