From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by sourceware.org (Postfix) with ESMTPS id 084E33858038; Wed, 18 Aug 2021 16:12:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 084E33858038 Received: by mail-wm1-x32d.google.com with SMTP id g138so1957108wmg.4; Wed, 18 Aug 2021 09:12:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:user-agent:in-reply-to :references:message-id:mime-version:content-transfer-encoding; bh=iobJHrNTR0KtcmpjLoFM66P4NYmx8a7X6SM7hjVziXY=; b=uhgW4B8Av1uE4xGm9gWJ+ftC2zfl4ve9OKmzYqJW5IC7Pissw0m9RyULDgmqVxShsX NHU17E3tx3vxszeohWN6IqvXMpLJjpA91t8nAU3vFfBWNNDmpHhD7C27erRubYsDIoic Y8/uJACjsLwZJdSHzBPQKPM8vURwprKBU/7J6tCjALj2S/KNQNs2XjCkDKxDCn1lBc+7 6GwYweeT9lcmFCQqI/xuVwJ/ayt275c3QvV9HrdBY1GKAe94P+cya4CeRNklJbXKGv4W NOAQvHYq53MmyPysEsF3W1x2wvFnKRBwgQwpq43wd3m+EOyMKW2L4OG4w20AhbdtTHdc jTfA== X-Gm-Message-State: AOAM532cRszTK4JbUARmSN8qVSSUGWEb/w/wSUBGlPMZeERSZcezIFW0 rGS6PREbATFHSHol9qb637Y= X-Google-Smtp-Source: ABdhPJzUE7pGGUIqYVXJQ/5yPBsBesL/KrhM+7TrBHUQ1Xmdg+hxi8l1I4u7OE5pB+Vp9crq/GwgCQ== X-Received: by 2002:a1c:27c5:: with SMTP id n188mr6720095wmn.126.1629303128932; Wed, 18 Aug 2021 09:12:08 -0700 (PDT) Received: from [127.0.0.1] (dynamic-077-004-063-243.77.4.pool.telefonica.de. [77.4.63.243]) by smtp.gmail.com with ESMTPSA id c25sm258749wmr.15.2021.08.18.09.12.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Aug 2021 09:12:08 -0700 (PDT) Date: Wed, 18 Aug 2021 18:12:07 +0200 From: Richard Biener To: Thomas Schwinge , David Edelsohn , gcc-patches@gcc.gnu.org CC: gcc@gcc.gnu.org, Martin Sebor , David Malcolm , Jonathan Wakely Subject: =?US-ASCII?Q?Re=3A_Make_=27gcc/hash-map-tests?= =?US-ASCII?Q?=2Ec=3Atest=5Fmap=5Fof=5Ftype=5Fwith=5Fctor?= =?US-ASCII?Q?=5Fand=5Fdtor=5Fexpand=27_work_on_32?= =?US-ASCII?Q?-bit_architectures_=5BPR101959=5D?= User-Agent: K-9 Mail for Android In-Reply-To: <87r1eqojgb.fsf@euler.schwinge.homeip.net> References: <87r1f6qzmx.fsf@euler.schwinge.homeip.net> <87czqd7e4k.fsf@euler.schwinge.homeip.net> <55126f14-dda1-2040-0976-70b89582a60c@gmail.com> <874kbopoah.fsf@euler.schwinge.homeip.net> <87r1eqojgb.fsf@euler.schwinge.homeip.net> Message-ID: <4C63D901-0719-4776-9B52-E29E054A257C@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Aug 2021 16:12:11 -0000 On August 18, 2021 5:34:28 PM GMT+02:00, Thomas Schwinge wrote: >Hi! > >On 2021-08-18T09:35:25-0400, David Edelsohn wrote= : >> This causes a bootstrap failure for me=2E >> >> PR/101959 > >Sorry for that; "details"=2E ;-| OK to push the attached >"Make 'gcc/hash-map-tests=2Ec:test_map_of_type_with_ctor_and_dtor_expand' >work on 32-bit architectures [PR101959]", which does resolve the issue >for a '-m32' i686-pc-linux-gnu build? Ok=2E=20 Richard=2E=20 > >Gr=C3=BC=C3=9Fe > Thomas > > >> On Tue, Aug 17, 2021 at 5:00 AM Richard Biener via Gcc wrote: >>> >>> On Tue, Aug 17, 2021 at 8:40 AM Thomas Schwinge wrote: >>> > >>> > Hi! >>> > >>> > On 2021-08-16T14:10:00-0600, Martin Sebor wrote= : >>> > > On 8/16/21 6:44 AM, Thomas Schwinge wrote: >>> > >> [=2E=2E=2E], to document the current behavior, I propose to >>> > >> "Add more self-tests for 'hash_map' with Value type with non-triv= ial >>> > >> constructor/destructor", see attached=2E OK to push to master br= anch? >>> > >> (Also cherry-pick into release branches, eventually?) >>> > >>> > (Attached again, for easy reference=2E) >>> > >>> > > Adding more tests sounds like an excellent idea=2E I'm not sure a= bout >>> > > the idea of adding loopy selftests that iterate as many times as i= n >>> > > the patch (looks like 1234 times two?) >>> > >>> > Correct, and I agree it's a sensible concern, generally=2E >>> > >>> > The current 1234 times two iterations is really arbitrary (should >>> > document that in the test case), just so that we trigger a few hash = table >>> > expansions=2E >>> >>> You could lower N_init (the default init is just 13!), >>> even with just 128 inserted elements you'll trigger >>> expansions to 31, 61 and 127 elements=2E >>> >>> > For 'selftest-c', we've got originally: >>> > >>> > -fself-test: 74775 pass(es) in 0=2E309299 seconds >>> > -fself-test: 74775 pass(es) in 0=2E366041 seconds >>> > -fself-test: 74775 pass(es) in 0=2E356663 seconds >>> > -fself-test: 74775 pass(es) in 0=2E355009 seconds >>> > -fself-test: 74775 pass(es) in 0=2E367575 seconds >>> > -fself-test: 74775 pass(es) in 0=2E320406 seconds >>> > >>> > =2E=2E=2E, and with my changes we've got: >>> > >>> > -fself-test: 94519 pass(es) in 0=2E327755 seconds >>> > -fself-test: 94519 pass(es) in 0=2E369522 seconds >>> > -fself-test: 94519 pass(es) in 0=2E355531 seconds >>> > -fself-test: 94519 pass(es) in 0=2E362179 seconds >>> > -fself-test: 94519 pass(es) in 0=2E363176 seconds >>> > -fself-test: 94519 pass(es) in 0=2E318930 seconds >>> > >>> > So it really seems to be all in the noise? >>> >>> Yes=2E I think the test is OK but it's also reasonable to lower >>> the '1234' times and add a comment as to the count should >>> trigger hashtable expansions "a few times"=2E >>> >>> Richard=2E >>> >>> > Yet: >>> > >>> > > Selftests run each time GCC >>> > > builds (i=2Ee=2E, even during day to day development)=2E It seems= to me >>> > > that it might be better to run such selftests only as part of >>> > > the bootstrap process=2E >>> > >>> > I'd rather have thought about a '--param self-test-expensive' (or >>> > similar), and then invoke the selftests via a new >>> > 'gcc/testsuite/selftests/expensive=2Eexp' (or similar)=2E >>> > >>> > Or, adapt 'gcc/testsuite/gcc=2Edg/plugin/expensive_selftests_plugin= =2Ec', >>> > that is, invoke them via the GCC plugin mechanism, which also seems = to be >>> > easy enough? >>> > >>> > I don't have a strong opinion about where/when these tests get run, = so >>> > will happily take any suggestions=2E >>> > >>> > >>> > Gr=C3=BC=C3=9Fe >>> > Thomas >>> > >>> > >>> > ----------------- >>> > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3= =9Fe 201, 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; G= esch=C3=A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gese= llschaft: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 > > >----------------- >Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 2= 01, 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch= =C3=A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellsc= haft: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955