From: Vladimir Makarov <vmakarov@redhat.com>
To: Andrey Belevantsev <abel@ispras.ru>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix PR 44691
Date: Wed, 18 Aug 2010 16:34:00 -0000 [thread overview]
Message-ID: <4C6C0A3C.9080703@redhat.com> (raw)
In-Reply-To: <4C6B9A2F.4090805@ispras.ru>
On 08/18/2010 04:30 AM, Andrey Belevantsev wrote:
> Hello,
>
> As explained in the audit trail, the problem was that in the selective
> scheduler I assumed that SUBREG_REG will always be a REG, which seems
> to be not the case. This is not quite in line with what documentation
> says, if I read it correctly, but it seems to be used in a number of
> backends, so the below patch just gives up substitution also when
> SUBREG_REG is not a register. Bootstrapped and tested on ia64, and
> verified that the test is fixed on x86_64.
>
> I think that this qualifies as obvious, so unless Vlad or other people
> have any comments, I'll commit it tomorrow.
>
Yes, it is obvious.
> Yours, Andrey
>
> 2010-08-18 Andrey Belevantsev <abel@ispras.ru>
>
> PR rtl-optimization/44691
>
> * sel-sched.c (count_occurrences_1): Also punt when SUBREG_REG
> is not a register.
>
Ok to commit. Thanks.
next prev parent reply other threads:[~2010-08-18 16:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 8:53 Andrey Belevantsev
2010-08-18 16:34 ` Vladimir Makarov [this message]
2010-08-19 14:11 ` H.J. Lu
2010-08-19 14:14 ` Andrey Belevantsev
2010-08-19 14:24 ` H.J. Lu
2010-08-19 14:37 ` Andrey Belevantsev
2010-08-19 15:53 ` Andrey Belevantsev
2010-08-19 16:03 ` H.J. Lu
2010-08-20 8:42 ` Andrey Belevantsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6C0A3C.9080703@redhat.com \
--to=vmakarov@redhat.com \
--cc=abel@ispras.ru \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).