From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31623 invoked by alias); 18 Aug 2010 16:28:54 -0000 Received: (qmail 31614 invoked by uid 22791); 18 Aug 2010 16:28:52 -0000 X-SWARE-Spam-Status: No, hits=-6.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Aug 2010 16:28:47 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7IGSkGq007747 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 18 Aug 2010 12:28:46 -0400 Received: from toll.yyz.redhat.com (toll.yyz.redhat.com [10.15.16.165]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7IGSjwn030314; Wed, 18 Aug 2010 12:28:45 -0400 Message-ID: <4C6C0A3C.9080703@redhat.com> Date: Wed, 18 Aug 2010 16:34:00 -0000 From: Vladimir Makarov User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.7) Gecko/20100720 Fedora/3.1.1-1.fc13 Thunderbird/3.1.1 MIME-Version: 1.0 To: Andrey Belevantsev CC: GCC Patches Subject: Re: [PATCH] Fix PR 44691 References: <4C6B9A2F.4090805@ispras.ru> In-Reply-To: <4C6B9A2F.4090805@ispras.ru> Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-08/txt/msg01379.txt.bz2 On 08/18/2010 04:30 AM, Andrey Belevantsev wrote: > Hello, > > As explained in the audit trail, the problem was that in the selective > scheduler I assumed that SUBREG_REG will always be a REG, which seems > to be not the case. This is not quite in line with what documentation > says, if I read it correctly, but it seems to be used in a number of > backends, so the below patch just gives up substitution also when > SUBREG_REG is not a register. Bootstrapped and tested on ia64, and > verified that the test is fixed on x86_64. > > I think that this qualifies as obvious, so unless Vlad or other people > have any comments, I'll commit it tomorrow. > Yes, it is obvious. > Yours, Andrey > > 2010-08-18 Andrey Belevantsev > > PR rtl-optimization/44691 > > * sel-sched.c (count_occurrences_1): Also punt when SUBREG_REG > is not a register. > Ok to commit. Thanks.