From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1239 invoked by alias); 19 Aug 2010 14:04:20 -0000 Received: (qmail 1048 invoked by uid 22791); 19 Aug 2010 14:04:18 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.ispras.ru (HELO smtp.ispras.ru) (83.149.198.201) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 Aug 2010 14:04:10 +0000 Received: from [10.10.3.52] (winnie.ispras.ru [83.149.198.236]) by smtp.ispras.ru (Postfix) with ESMTP id 9EA995D40FA; Thu, 19 Aug 2010 16:19:46 +0400 (MSD) Message-ID: <4C6D39D7.3090709@ispras.ru> Date: Thu, 19 Aug 2010 14:14:00 -0000 From: Andrey Belevantsev User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.8) Gecko/20100802 Thunderbird/3.1.2 MIME-Version: 1.0 To: "H.J. Lu" CC: GCC Patches , "Vladimir N. Makarov" Subject: Re: [PATCH] Fix PR 44691 References: <4C6B9A2F.4090805@ispras.ru> In-Reply-To: Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-08/txt/msg01446.txt.bz2 On 19.08.2010 17:28, H.J. Lu wrote: > 2010/8/18 Andrey Belevantsev: >> Hello, >> >> As explained in the audit trail, the problem was that in the selective >> scheduler I assumed that SUBREG_REG will always be a REG, which seems to be >> not the case. This is not quite in line with what documentation says, if I >> read it correctly, but it seems to be used in a number of backends, so the >> below patch just gives up substitution also when SUBREG_REG is not a >> register. Bootstrapped and tested on ia64, and verified that the test is >> fixed on x86_64. >> >> I think that this qualifies as obvious, so unless Vlad or other people have >> any comments, I'll commit it tomorrow. >> >> Yours, Andrey >> >> 2010-08-18 Andrey Belevantsev >> >> PR rtl-optimization/44691 >> >> * sel-sched.c (count_occurrences_1): Also punt when SUBREG_REG >> is not a register. >> > > Shouldn't we add the testcase? The test is fortran.dg/pr42294.f which is actually mentioned in the bug report. Sorry for not saying this explicitly in the mail. Andrey