[PATCH] Allow decimal floats for mingw-w64

[PATCH] Allow decimal floats for mingw-w64

[JonY]

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

Hi,

Attached patch enables i?86-w64-mingw32 and x86_64-w64-mingw32 decimal 
float support with bid.

Tested with x86_64-w64-mingw32. Is attached patch OK for trunk?



2010-08-24  Jonathan Yong <jon_y@users.sourceforge.net>

	* configure.ac: Allow w64 targets to use bid decimal floats.
	* configure: Regenerated.


[-- Attachment #2: bid.patch --]
[-- Type: text/plain, Size: 1338 bytes --]

Index: gcc/configure.ac
===================================================================
--- gcc/configure.ac	(revision 163517)
+++ gcc/configure.ac	(working copy)
@@ -620,7 +620,7 @@
 ],
 [
   case $target in
-    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux*)
+    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*)
       enable_decimal_float=yes
       ;;
     *)
@@ -638,7 +638,7 @@
 case x$enable_decimal_float in
   xyes)
     case $target in
-      i?86*-*-linux* | x86_64*-*-linux*)
+      i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*)
 	enable_decimal_float=bid
 	;;
       *)
Index: gcc/configure
===================================================================
--- gcc/configure	(revision 163517)
+++ gcc/configure	(working copy)
@@ -6661,7 +6661,7 @@
 else
 
   case $target in
-    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux*)
+    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*)
       enable_decimal_float=yes
       ;;
     *)
@@ -6685,7 +6685,7 @@
 case x$enable_decimal_float in
   xyes)
     case $target in
-      i?86*-*-linux* | x86_64*-*-linux*)
+      i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*)
 	enable_decimal_float=bid
 	;;
       *)

Re: [PATCH] Allow decimal floats for mingw-w64

[Joseph S. Myers]

On Tue, 24 Aug 2010, JonY wrote:

> Hi,
> 
> Attached patch enables i?86-w64-mingw32 and x86_64-w64-mingw32 decimal float
> support with bid.

My previous comments about the several places to keep in sync 
<http://gcc.gnu.org/ml/gcc-patches/2010-02/msg00933.html> apply equally to 
this patch (see also followups to the previous comments).

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: [PATCH] Allow decimal floats for mingw-w64

[Kai Tietz]

2010/8/24 JonY <jon_y@users.sourceforge.net>:
> Hi,
>
> Attached patch enables i?86-w64-mingw32 and x86_64-w64-mingw32 decimal float
> support with bid.
>
> Tested with x86_64-w64-mingw32. Is attached patch OK for trunk?
>
>
>
> 2010-08-24  Jonathan Yong <jon_y@users.sourceforge.net>
>
>        * configure.ac: Allow w64 targets to use bid decimal floats.
>        * configure: Regenerated.
>
>

Patch is from my side ok. I added Dave to CC. Maybe he wants that it
gets added for cygwin, too?

I tried to find out more detail about the specification MS used for
the #C implementation of __decimal128, but sadly I didn't got any
reply here. Some users were asking us some time ago, if we couldn't
enable decimal float support for mingw-w64. So I assume it is up to us
to decided, which standard to follow here, and bid is ok.

Kai

-- 
|  (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination

Re: [PATCH] Allow decimal floats for mingw-w64

[JonY]

[-- Attachment #1: Type: text/plain, Size: 522 bytes --]

On 8/24/2010 23:05, Joseph S. Myers wrote:
> On Tue, 24 Aug 2010, JonY wrote:
>
>> Hi,
>>
>> Attached patch enables i?86-w64-mingw32 and x86_64-w64-mingw32 decimal float
>> support with bid.
>
> My previous comments about the several places to keep in sync
> <http://gcc.gnu.org/ml/gcc-patches/2010-02/msg00933.html>  apply equally to
> this patch (see also followups to the previous comments).
>

Thanks for the heads up. New patch with quick fixes attached.

Do you want the GCC_AC_ENABLE_DECIMAL_FLOAT version instead?

[-- Attachment #2: bid.patch --]
[-- Type: text/plain, Size: 3675 bytes --]

Index: gcc/configure.ac
===================================================================
--- gcc/configure.ac	(revision 163517)
+++ gcc/configure.ac	(working copy)
@@ -620,7 +620,7 @@
 ],
 [
   case $target in
-    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux*)
+    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*)
       enable_decimal_float=yes
       ;;
     *)
@@ -638,7 +638,7 @@
 case x$enable_decimal_float in
   xyes)
     case $target in
-      i?86*-*-linux* | x86_64*-*-linux*)
+      i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*)
 	enable_decimal_float=bid
 	;;
       *)
Index: gcc/configure
===================================================================
--- gcc/configure	(revision 163517)
+++ gcc/configure	(working copy)
@@ -6661,7 +6661,7 @@
 else
 
   case $target in
-    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux*)
+    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*)
       enable_decimal_float=yes
       ;;
     *)
@@ -6685,7 +6685,7 @@
 case x$enable_decimal_float in
   xyes)
     case $target in
-      i?86*-*-linux* | x86_64*-*-linux*)
+      i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*)
 	enable_decimal_float=bid
 	;;
       *)
Index: libdecnumber/configure.ac
===================================================================
--- libdecnumber/configure.ac	(revision 163517)
+++ libdecnumber/configure.ac	(working copy)
@@ -89,7 +89,7 @@
 ],
 [
   case $target in
-    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux*)
+    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*)
       enable_decimal_float=yes
       ;;
     *)
@@ -103,7 +103,7 @@
 # For the sake of simplicity, just use the default format in this directory
 if test x$enable_decimal_float = xyes -o x$enable_decimal_float = xno; then
   case $target in
-    i?86*-*-linux* | x86_64*-*-linux*)
+    i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*)
       enable_decimal_float=bid
       ;;
     *)
Index: libdecnumber/configure
===================================================================
--- libdecnumber/configure	(revision 163517)
+++ libdecnumber/configure	(working copy)
@@ -4600,7 +4600,7 @@
 else
 
   case $target in
-    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux*)
+    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*)
       enable_decimal_float=yes
       ;;
     *)
@@ -4616,7 +4616,7 @@
 # For the sake of simplicity, just use the default format in this directory
 if test x$enable_decimal_float = xyes -o x$enable_decimal_float = xno; then
   case $target in
-    i?86*-*-linux* | x86_64*-*-linux*)
+    i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*)
       enable_decimal_float=bid
       ;;
     *)
Index: libgcc/configure
===================================================================
--- libgcc/configure	(revision 163517)
+++ libgcc/configure	(working copy)
@@ -3646,7 +3646,7 @@
 else
 
   case $host in
-    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux*)
+    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*)
       enable_decimal_float=yes
       ;;
     *)
@@ -3660,7 +3660,7 @@
 # x86's use BID format instead of DPD
 if test x$enable_decimal_float = xyes; then
   case $host in
-    i?86*-*-linux* | x86_64*-*-linux*)
+    i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*)
       enable_decimal_float=bid
       ;;
     *)

Re: [PATCH] Allow decimal floats for mingw-w64

[Ralf Wildenhues]

* JonY wrote on Tue, Aug 24, 2010 at 04:57:46PM CEST:
> Thanks for the heads up. New patch with quick fixes attached.

Not sure if you're posting a full or a partial patch, but while it
contained libgcc/configure, it didn't contain changes to
libgcc/configure.ac which is the source to the former file.

Cheers,
Ralf

> Index: libgcc/configure
> ===================================================================
> --- libgcc/configure	(revision 163517)
> +++ libgcc/configure	(working copy)
> @@ -3646,7 +3646,7 @@
>  else
>  
>    case $host in
> -    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux*)
> +    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*)
>        enable_decimal_float=yes
>        ;;
>      *)
> @@ -3660,7 +3660,7 @@
>  # x86's use BID format instead of DPD
>  if test x$enable_decimal_float = xyes; then
>    case $host in
> -    i?86*-*-linux* | x86_64*-*-linux*)
> +    i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*)

Re: [PATCH] Allow decimal floats for mingw-w64

[JonY]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

On 8/25/2010 01:25, Ralf Wildenhues wrote:
> * JonY wrote on Tue, Aug 24, 2010 at 04:57:46PM CEST:
>> Thanks for the heads up. New patch with quick fixes attached.
>
> Not sure if you're posting a full or a partial patch, but while it
> contained libgcc/configure, it didn't contain changes to
> libgcc/configure.ac which is the source to the former file.
>

You're right, I missed them. Attached is a new copy.

[-- Attachment #2: bid.patch --]
[-- Type: text/plain, Size: 4396 bytes --]

Index: gcc/configure.ac
===================================================================
--- gcc/configure.ac	(revision 163517)
+++ gcc/configure.ac	(working copy)
@@ -620,7 +620,7 @@
 ],
 [
   case $target in
-    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux*)
+    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*)
       enable_decimal_float=yes
       ;;
     *)
@@ -638,7 +638,7 @@
 case x$enable_decimal_float in
   xyes)
     case $target in
-      i?86*-*-linux* | x86_64*-*-linux*)
+      i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*)
 	enable_decimal_float=bid
 	;;
       *)
Index: gcc/configure
===================================================================
--- gcc/configure	(revision 163517)
+++ gcc/configure	(working copy)
@@ -6661,7 +6661,7 @@
 else
 
   case $target in
-    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux*)
+    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*)
       enable_decimal_float=yes
       ;;
     *)
@@ -6685,7 +6685,7 @@
 case x$enable_decimal_float in
   xyes)
     case $target in
-      i?86*-*-linux* | x86_64*-*-linux*)
+      i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*)
 	enable_decimal_float=bid
 	;;
       *)
Index: libdecnumber/configure.ac
===================================================================
--- libdecnumber/configure.ac	(revision 163517)
+++ libdecnumber/configure.ac	(working copy)
@@ -89,7 +89,7 @@
 ],
 [
   case $target in
-    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux*)
+    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*)
       enable_decimal_float=yes
       ;;
     *)
@@ -103,7 +103,7 @@
 # For the sake of simplicity, just use the default format in this directory
 if test x$enable_decimal_float = xyes -o x$enable_decimal_float = xno; then
   case $target in
-    i?86*-*-linux* | x86_64*-*-linux*)
+    i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*)
       enable_decimal_float=bid
       ;;
     *)
Index: libdecnumber/configure
===================================================================
--- libdecnumber/configure	(revision 163517)
+++ libdecnumber/configure	(working copy)
@@ -4600,7 +4600,7 @@
 else
 
   case $target in
-    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux*)
+    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*)
       enable_decimal_float=yes
       ;;
     *)
@@ -4616,7 +4616,7 @@
 # For the sake of simplicity, just use the default format in this directory
 if test x$enable_decimal_float = xyes -o x$enable_decimal_float = xno; then
   case $target in
-    i?86*-*-linux* | x86_64*-*-linux*)
+    i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*)
       enable_decimal_float=bid
       ;;
     *)
Index: libgcc/configure.ac
===================================================================
--- libgcc/configure.ac	(revision 163517)
+++ libgcc/configure.ac	(working copy)
@@ -139,7 +139,7 @@
 ],
 [
   case $host in
-    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux*)
+    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*)
       enable_decimal_float=yes
       ;;
     *)
@@ -151,7 +151,7 @@
 # x86's use BID format instead of DPD
 if test x$enable_decimal_float = xyes; then
   case $host in
-    i?86*-*-linux* | x86_64*-*-linux*)
+    i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*)
       enable_decimal_float=bid
       ;;
     *)
Index: libgcc/configure
===================================================================
--- libgcc/configure	(revision 163517)
+++ libgcc/configure	(working copy)
@@ -3646,7 +3646,7 @@
 else
 
   case $host in
-    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux*)
+    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*)
       enable_decimal_float=yes
       ;;
     *)
@@ -3660,7 +3660,7 @@
 # x86's use BID format instead of DPD
 if test x$enable_decimal_float = xyes; then
   case $host in
-    i?86*-*-linux* | x86_64*-*-linux*)
+    i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*)
       enable_decimal_float=bid
       ;;
     *)

Re: [PATCH] Allow decimal floats for mingw-w64

[JonY]

[-- Attachment #1: Type: text/plain, Size: 750 bytes --]

On 8/24/2010 22:57, JonY wrote:
> On 8/24/2010 23:05, Joseph S. Myers wrote:
>> On Tue, 24 Aug 2010, JonY wrote:
>>
>>> Hi,
>>>
>>> Attached patch enables i?86-w64-mingw32 and x86_64-w64-mingw32
>>> decimal float
>>> support with bid.
>>
>> My previous comments about the several places to keep in sync
>> <http://gcc.gnu.org/ml/gcc-patches/2010-02/msg00933.html> apply
>> equally to
>> this patch (see also followups to the previous comments).
>>
>
> Thanks for the heads up. New patch with quick fixes attached.
>
> Do you want the GCC_AC_ENABLE_DECIMAL_FLOAT version instead?

Here is a new attached patch based on the link above. It mostly copies 
the existing logic and consolidates them into a single file.

Bootstrap tested on i686-pc-cygwin.

[-- Attachment #2: dfp.patch --]
[-- Type: text/plain, Size: 19396 bytes --]

Index: gcc/configure
===================================================================
--- gcc/configure	(revision 163756)
+++ gcc/configure	(working copy)
@@ -1577,9 +1577,9 @@
   --enable-multilib       enable library support for multiple ABIs
   --enable-__cxa_atexit   enable __cxa_atexit for C++
   --enable-decimal-float={no,yes,bid,dpd}
-			enable decimal float extension to C.  Selecting 'bid'
-			or 'dpd' choses which decimal floating point format
-			to use
+                          enable decimal float extension to C.  Selecting 'bid'
+                          or 'dpd' choses which decimal floating point format
+                          to use
   --enable-fixed-point    enable fixed-point arithmetic extension to C
   --enable-threads        enable thread usage for target GCC
   --enable-threads=LIB    use LIB thread package for target GCC
@@ -6649,65 +6649,77 @@
 
 
 # Enable C extension for decimal float if target supports it.
-# Check whether --enable-decimal-float was given.
+
+  # Enable C extension for decimal float if target supports it.
+  # Check whether --enable-decimal-float was given.
 if test "${enable_decimal_float+set}" = set; then :
   enableval=$enable_decimal_float;
-  case $enable_decimal_float in
-    yes | no | bid | dpd) ;;
-    *) as_fn_error "'$enable_decimal_float' is an invalid value for --enable-decimal-float.
-Valid choices are 'yes', 'bid', 'dpd', and 'no'." "$LINENO" 5 ;;
-  esac
+    case $enable_decimal_float in
+      yes | no | bid | dpd) ;;
+      *) as_fn_error "'$enable_decimal_float' is an invalid value for --enable-decimal-float.
+  Valid choices are 'yes', 'bid', 'dpd', and 'no'." "$LINENO" 5 ;;
+    esac
 
 else
 
-  case $target in
-    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux*)
-      enable_decimal_float=yes
-      ;;
-    *)
-      { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: decimal float is not supported for this target" >&5
+    case $target in
+      powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | \
+      i?86*-*-mingw* | x86_64*-*-mingw* | \
+      i?86*-*-cygwin*)
+        enable_decimal_float=yes
+        ;;
+      *)
+        { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: decimal float is not supported for this target" >&5
 $as_echo "$as_me: WARNING: decimal float is not supported for this target" >&2;}
-      enable_decimal_float=no
-      ;;
-  esac
+        enable_decimal_float=no
+        ;;
+    esac
 
 fi
 
 
-dfp=`if test $enable_decimal_float != no; then echo 1; else echo 0; fi`
+  dfp=`if test $enable_decimal_float != no; then echo 1; else echo 0; fi`
 
 cat >>confdefs.h <<_ACEOF
 #define ENABLE_DECIMAL_FLOAT $dfp
 _ACEOF
 
+  { $as_echo "$as_me:${as_lineno-$LINENO}: checking for decimal floating point" >&5
+$as_echo_n "checking for decimal floating point... " >&6; }
+  { $as_echo "$as_me:${as_lineno-$LINENO}: result: $enable_decimal_float" >&5
+$as_echo "$enable_decimal_float" >&6; }
 
-# x86's use BID format instead of DPD
-case x$enable_decimal_float in
-  xyes)
-    case $target in
-      i?86*-*-linux* | x86_64*-*-linux*)
-	enable_decimal_float=bid
-	;;
-      *)
-	enable_decimal_float=dpd
-	;;
-    esac
+  # x86's use BID format instead of DPD
+  case x$enable_decimal_float in
+    xyes)
+      case $target in
+        i?86*-*-linux* | x86_64*-*-linux* | \
+        i?86*-*-mingw* | x86_64*-*-mingw* | \
+        i?86*-*-cygwin*)
+    enable_decimal_float=bid
     ;;
-  xno)
-    # ENABLE_DECIMAL_FLOAT is set to 0. But we have to have proper
-    # dependency on libdecnumber.
+        *)
     enable_decimal_float=dpd
     ;;
-esac
+      esac
+      ;;
+    xno)
+      # ENABLE_DECIMAL_FLOAT is set to 0. But we have to have proper
+      # dependency on libdecnumber.
+      enable_decimal_float=dpd
+      ;;
+  esac
 
+  bid=`if test $enable_decimal_float = bid; then echo 1; else echo 0; fi`
 
-bid=`if test $enable_decimal_float = bid; then echo 1; else echo 0; fi`
-
 cat >>confdefs.h <<_ACEOF
 #define ENABLE_DECIMAL_BID_FORMAT $bid
 _ACEOF
 
 
+
+
+
 # Enable C extension for fixed-point arithmetic.
 # Check whether --enable-fixed-point was given.
 if test "${enable_fixed_point+set}" = set; then :
@@ -17130,7 +17142,7 @@
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 17133 "configure"
+#line 17145 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H
@@ -17236,7 +17248,7 @@
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 17239 "configure"
+#line 17251 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H
Index: gcc/aclocal.m4
===================================================================
--- gcc/aclocal.m4	(revision 163756)
+++ gcc/aclocal.m4	(working copy)
@@ -106,6 +106,7 @@
 m4_include([../lt~obsolete.m4])
 m4_include([../config/acx.m4])
 m4_include([../config/codeset.m4])
+m4_include([../config/dfp.m4])
 m4_include([../config/gettext-sister.m4])
 m4_include([../config/iconv.m4])
 m4_include([../config/lcmessage.m4])
Index: gcc/configure.ac
===================================================================
--- gcc/configure.ac	(revision 163756)
+++ gcc/configure.ac	(working copy)
@@ -606,59 +606,8 @@
 [], [])
 
 # Enable C extension for decimal float if target supports it.
-AC_ARG_ENABLE(decimal-float,
-[  --enable-decimal-float={no,yes,bid,dpd}
-			enable decimal float extension to C.  Selecting 'bid'
-			or 'dpd' choses which decimal floating point format
-			to use],
-[
-  case $enable_decimal_float in
-    yes | no | bid | dpd) ;;
-    *) AC_MSG_ERROR(['$enable_decimal_float' is an invalid value for --enable-decimal-float.
-Valid choices are 'yes', 'bid', 'dpd', and 'no'.]) ;;
-  esac
-],
-[
-  case $target in
-    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux*)
-      enable_decimal_float=yes
-      ;;
-    *)
-      AC_MSG_WARN(decimal float is not supported for this target, ignored)
-      enable_decimal_float=no
-      ;;
-  esac
-])
+GCC_DFP_TARGET
 
-dfp=`if test $enable_decimal_float != no; then echo 1; else echo 0; fi`
-AC_DEFINE_UNQUOTED(ENABLE_DECIMAL_FLOAT, $dfp,
-[Define to 1 to enable decimal float extension to C.])
-
-# x86's use BID format instead of DPD
-case x$enable_decimal_float in
-  xyes)
-    case $target in
-      i?86*-*-linux* | x86_64*-*-linux*)
-	enable_decimal_float=bid
-	;;
-      *)
-	enable_decimal_float=dpd
-	;;
-    esac
-    ;;
-  xno)
-    # ENABLE_DECIMAL_FLOAT is set to 0. But we have to have proper
-    # dependency on libdecnumber.
-    enable_decimal_float=dpd
-    ;;
-esac
-AC_SUBST(enable_decimal_float)
-
-bid=`if test $enable_decimal_float = bid; then echo 1; else echo 0; fi`
-AC_DEFINE_UNQUOTED(ENABLE_DECIMAL_BID_FORMAT, $bid,
-[Define to 1 to specify that we are using the BID decimal floating
-point format instead of DPD])
-
 # Enable C extension for fixed-point arithmetic.
 AC_ARG_ENABLE(fixed-point,
 [  --enable-fixed-point    enable fixed-point arithmetic extension to C],
Index: libdecnumber/configure
===================================================================
--- libdecnumber/configure	(revision 163756)
+++ libdecnumber/configure	(working copy)
@@ -1298,9 +1298,9 @@
   --enable-werror-always  enable -Werror despite compiler version
   --enable-maintainer-mode enable rules only needed by maintainers
   --enable-decimal-float={no,yes,bid,dpd}
-			enable decimal float extension to C.  Selecting 'bid'
-			or 'dpd' choses which decimal floating point format
-			to use
+                          enable decimal float extension to C.  Selecting 'bid'
+                          or 'dpd' choses which decimal floating point format
+                          to use
 
 Some influential environment variables:
   CC          C compiler command
@@ -4584,47 +4584,77 @@
     NONENONEs,x,x, &&
   program_prefix=${target_alias}-
 
-# Default decimal format
-# If you change the defaults here, be sure to change them in the GCC directory also
-{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for decimal floating point" >&5
-$as_echo_n "checking for decimal floating point... " >&6; }
-# Check whether --enable-decimal-float was given.
+
+  # Enable C extension for decimal float if target supports it.
+  # Check whether --enable-decimal-float was given.
 if test "${enable_decimal_float+set}" = set; then :
   enableval=$enable_decimal_float;
-  case $enable_decimal_float in
-    yes | no | bid | dpd) ;;
-    *) as_fn_error "'$enable_decimal_float' is an invalid value for --enable-decimal-float.
-Valid choices are 'yes', 'bid', 'dpd', and 'no'." "$LINENO" 5 ;;
-  esac
+    case $enable_decimal_float in
+      yes | no | bid | dpd) ;;
+      *) as_fn_error "'$enable_decimal_float' is an invalid value for --enable-decimal-float.
+  Valid choices are 'yes', 'bid', 'dpd', and 'no'." "$LINENO" 5 ;;
+    esac
 
 else
 
-  case $target in
-    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux*)
-      enable_decimal_float=yes
-      ;;
-    *)
-      enable_decimal_float=no
-      ;;
-  esac
+    case $target in
+      powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | \
+      i?86*-*-mingw* | x86_64*-*-mingw* | \
+      i?86*-*-cygwin*)
+        enable_decimal_float=yes
+        ;;
+      *)
+        { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: decimal float is not supported for this target" >&5
+$as_echo "$as_me: WARNING: decimal float is not supported for this target" >&2;}
+        enable_decimal_float=no
+        ;;
+    esac
 
 fi
 
 
-# x86's use BID format instead of DPD
-# In theory --enable-decimal-float=no should not compile anything
-# For the sake of simplicity, just use the default format in this directory
-if test x$enable_decimal_float = xyes -o x$enable_decimal_float = xno; then
-  case $target in
-    i?86*-*-linux* | x86_64*-*-linux*)
-      enable_decimal_float=bid
+  dfp=`if test $enable_decimal_float != no; then echo 1; else echo 0; fi`
+
+cat >>confdefs.h <<_ACEOF
+#define ENABLE_DECIMAL_FLOAT $dfp
+_ACEOF
+
+  { $as_echo "$as_me:${as_lineno-$LINENO}: checking for decimal floating point" >&5
+$as_echo_n "checking for decimal floating point... " >&6; }
+  { $as_echo "$as_me:${as_lineno-$LINENO}: result: $enable_decimal_float" >&5
+$as_echo "$enable_decimal_float" >&6; }
+
+  # x86's use BID format instead of DPD
+  case x$enable_decimal_float in
+    xyes)
+      case $target in
+        i?86*-*-linux* | x86_64*-*-linux* | \
+        i?86*-*-mingw* | x86_64*-*-mingw* | \
+        i?86*-*-cygwin*)
+    enable_decimal_float=bid
+    ;;
+        *)
+    enable_decimal_float=dpd
+    ;;
+      esac
       ;;
-    *)
+    xno)
+      # ENABLE_DECIMAL_FLOAT is set to 0. But we have to have proper
+      # dependency on libdecnumber.
       enable_decimal_float=dpd
       ;;
   esac
-fi
 
+  bid=`if test $enable_decimal_float = bid; then echo 1; else echo 0; fi`
+
+cat >>confdefs.h <<_ACEOF
+#define ENABLE_DECIMAL_BID_FORMAT $bid
+_ACEOF
+
+
+
+
+
 # If BID is being used, additional objects should be linked in.
 if test x$enable_decimal_float = xbid; then
   ADDITIONAL_OBJS="$ADDITIONAL_OBJS \$(bid_OBJS)"
@@ -4632,11 +4662,8 @@
   ADDITIONAL_OBJS=
 fi
 
-{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $enable_decimal_float" >&5
-$as_echo "$enable_decimal_float" >&6; }
 
 
-
  { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether byte ordering is bigendian" >&5
 $as_echo_n "checking whether byte ordering is bigendian... " >&6; }
 if test "${ac_cv_c_bigendian+set}" = set; then :
Index: libdecnumber/configure.ac
===================================================================
--- libdecnumber/configure.ac	(revision 163756)
+++ libdecnumber/configure.ac	(working copy)
@@ -72,46 +72,8 @@
 
 AC_CANONICAL_TARGET
 
-# Default decimal format
-# If you change the defaults here, be sure to change them in the GCC directory also
-AC_MSG_CHECKING([for decimal floating point])
-AC_ARG_ENABLE(decimal-float,
-[  --enable-decimal-float={no,yes,bid,dpd}
-			enable decimal float extension to C.  Selecting 'bid'
-			or 'dpd' choses which decimal floating point format
-			to use],
-[
-  case $enable_decimal_float in
-    yes | no | bid | dpd) ;;
-    *) AC_MSG_ERROR(['$enable_decimal_float' is an invalid value for --enable-decimal-float.
-Valid choices are 'yes', 'bid', 'dpd', and 'no'.]) ;;
-  esac
-],
-[
-  case $target in
-    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux*)
-      enable_decimal_float=yes
-      ;;
-    *)
-      enable_decimal_float=no
-      ;;
-  esac
-])
+GCC_DFP_TARGET
 
-# x86's use BID format instead of DPD
-# In theory --enable-decimal-float=no should not compile anything
-# For the sake of simplicity, just use the default format in this directory
-if test x$enable_decimal_float = xyes -o x$enable_decimal_float = xno; then
-  case $target in
-    i?86*-*-linux* | x86_64*-*-linux*)
-      enable_decimal_float=bid
-      ;;
-    *)
-      enable_decimal_float=dpd
-      ;;
-  esac
-fi
-
 # If BID is being used, additional objects should be linked in.
 if test x$enable_decimal_float = xbid; then
   ADDITIONAL_OBJS="$ADDITIONAL_OBJS \$(bid_OBJS)"
@@ -119,8 +81,6 @@
   ADDITIONAL_OBJS=
 fi
 
-AC_MSG_RESULT($enable_decimal_float)
-AC_SUBST(enable_decimal_float)
 AC_SUBST(ADDITIONAL_OBJS)
 
 AC_C_BIGENDIAN
Index: libdecnumber/config.in
===================================================================
--- libdecnumber/config.in	(revision 163756)
+++ libdecnumber/config.in	(working copy)
@@ -3,6 +3,13 @@
 /* Define if building universal (internal helper macro) */
 #undef AC_APPLE_UNIVERSAL_BUILD
 
+/* Define to 1 to specify that we are using the BID decimal floating point
+   format instead of DPD */
+#undef ENABLE_DECIMAL_BID_FORMAT
+
+/* Define to 1 to enable decimal float extension to C. */
+#undef ENABLE_DECIMAL_FLOAT
+
 /* Define to 1 if you have the <ctype.h> header file. */
 #undef HAVE_CTYPE_H
 
Index: libdecnumber/aclocal.m4
===================================================================
--- libdecnumber/aclocal.m4	(revision 163756)
+++ libdecnumber/aclocal.m4	(working copy)
@@ -11,6 +11,7 @@
 # even the implied warranty of MERCHANTABILITY or FITNESS FOR A
 # PARTICULAR PURPOSE.
 
+m4_include([../config/dfp.m4])
 m4_include([../config/override.m4])
 m4_include([../config/stdint.m4])
 m4_include([../config/warnings.m4])
Index: libgcc/configure
===================================================================
--- libgcc/configure	(revision 163756)
+++ libgcc/configure	(working copy)
@@ -1278,9 +1278,9 @@
                           enable make rules and dependencies not useful (and
                           sometimes confusing) to the casual installer
   --enable-decimal-float={no,yes,bid,dpd}
-			enable decimal float extension to C.  Selecting 'bid'
-			or 'dpd' choses which decimal floating point format
-			to use
+                          enable decimal float extension to C.  Selecting 'bid'
+                          or 'dpd' choses which decimal floating point format
+                          to use
   --enable-tls            Use thread-local storage [default=yes]
 
 Optional Packages:
@@ -3634,42 +3634,77 @@
 decimal_float=$libgcc_cv_dfp
 
 
-# Check whether --enable-decimal-float was given.
+
+  # Enable C extension for decimal float if target supports it.
+  # Check whether --enable-decimal-float was given.
 if test "${enable_decimal_float+set}" = set; then :
   enableval=$enable_decimal_float;
-  case $enable_decimal_float in
-    yes | no | bid | dpd) ;;
-    *) as_fn_error "'$enable_decimal_float' is an invalid value for --enable-decimal-float.
-Valid choices are 'yes', 'bid', 'dpd', and 'no'." "$LINENO" 5 ;;
-  esac
+    case $enable_decimal_float in
+      yes | no | bid | dpd) ;;
+      *) as_fn_error "'$enable_decimal_float' is an invalid value for --enable-decimal-float.
+  Valid choices are 'yes', 'bid', 'dpd', and 'no'." "$LINENO" 5 ;;
+    esac
 
 else
 
-  case $host in
-    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux*)
-      enable_decimal_float=yes
-      ;;
-    *)
-      enable_decimal_float=no
-      ;;
-  esac
+    case $target in
+      powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | \
+      i?86*-*-mingw* | x86_64*-*-mingw* | \
+      i?86*-*-cygwin*)
+        enable_decimal_float=yes
+        ;;
+      *)
+        { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: decimal float is not supported for this target" >&5
+$as_echo "$as_me: WARNING: decimal float is not supported for this target" >&2;}
+        enable_decimal_float=no
+        ;;
+    esac
 
 fi
 
 
-# x86's use BID format instead of DPD
-if test x$enable_decimal_float = xyes; then
-  case $host in
-    i?86*-*-linux* | x86_64*-*-linux*)
-      enable_decimal_float=bid
+  dfp=`if test $enable_decimal_float != no; then echo 1; else echo 0; fi`
+
+cat >>confdefs.h <<_ACEOF
+#define ENABLE_DECIMAL_FLOAT $dfp
+_ACEOF
+
+  { $as_echo "$as_me:${as_lineno-$LINENO}: checking for decimal floating point" >&5
+$as_echo_n "checking for decimal floating point... " >&6; }
+  { $as_echo "$as_me:${as_lineno-$LINENO}: result: $enable_decimal_float" >&5
+$as_echo "$enable_decimal_float" >&6; }
+
+  # x86's use BID format instead of DPD
+  case x$enable_decimal_float in
+    xyes)
+      case $target in
+        i?86*-*-linux* | x86_64*-*-linux* | \
+        i?86*-*-mingw* | x86_64*-*-mingw* | \
+        i?86*-*-cygwin*)
+    enable_decimal_float=bid
+    ;;
+        *)
+    enable_decimal_float=dpd
+    ;;
+      esac
       ;;
-    *)
+    xno)
+      # ENABLE_DECIMAL_FLOAT is set to 0. But we have to have proper
+      # dependency on libdecnumber.
       enable_decimal_float=dpd
       ;;
   esac
-fi
 
+  bid=`if test $enable_decimal_float = bid; then echo 1; else echo 0; fi`
 
+cat >>confdefs.h <<_ACEOF
+#define ENABLE_DECIMAL_BID_FORMAT $bid
+_ACEOF
+
+
+
+
+
 # Check for fixed-point support.
 { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether fixed-point is supported" >&5
 $as_echo_n "checking whether fixed-point is supported... " >&6; }
Index: libgcc/configure.ac
===================================================================
--- libgcc/configure.ac	(revision 163756)
+++ libgcc/configure.ac	(working copy)
@@ -125,42 +125,8 @@
 decimal_float=$libgcc_cv_dfp
 AC_SUBST(decimal_float)
 
-AC_ARG_ENABLE(decimal-float,
-[  --enable-decimal-float={no,yes,bid,dpd}
-			enable decimal float extension to C.  Selecting 'bid'
-			or 'dpd' choses which decimal floating point format
-			to use],
-[
-  case $enable_decimal_float in
-    yes | no | bid | dpd) ;;
-    *) AC_MSG_ERROR(['$enable_decimal_float' is an invalid value for --enable-decimal-float.
-Valid choices are 'yes', 'bid', 'dpd', and 'no'.]) ;;
-  esac
-],
-[
-  case $host in
-    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux*)
-      enable_decimal_float=yes
-      ;;
-    *)
-      enable_decimal_float=no
-      ;;
-  esac
-])
+GCC_DFP_TARGET
 
-# x86's use BID format instead of DPD
-if test x$enable_decimal_float = xyes; then
-  case $host in
-    i?86*-*-linux* | x86_64*-*-linux*)
-      enable_decimal_float=bid
-      ;;
-    *)
-      enable_decimal_float=dpd
-      ;;
-  esac
-fi
-AC_SUBST(enable_decimal_float)
-
 # Check for fixed-point support.
 AC_CACHE_CHECK([whether fixed-point is supported], [libgcc_cv_fixed_point],
 	       [AC_COMPILE_IFELSE([_Sat _Fract x;], [libgcc_cv_fixed_point=yes],

Re: [PATCH] Allow decimal floats for mingw-w64

[Dave Korn]

On 24/08/2010 16:06, Kai Tietz wrote:
> 2010/8/24 JonY <jon_y@users.sourceforge.net>:
>> Hi,
>>
>> Attached patch enables i?86-w64-mingw32 and x86_64-w64-mingw32 decimal float
>> support with bid.
>>
>> Tested with x86_64-w64-mingw32. Is attached patch OK for trunk?
>>
>>
>>
>> 2010-08-24  Jonathan Yong <jon_y@users.sourceforge.net>
>>
>>        * configure.ac: Allow w64 targets to use bid decimal floats.
>>        * configure: Regenerated.
>>
>>
> 
> Patch is from my side ok. I added Dave to CC. Maybe he wants that it
> gets added for cygwin, too?

  I'm currently testing a build that I did with Uros' patch and manually
configuring with '--enable-decimal-float' and it seems to be going pretty
well, so yes please Jon, if you don't mind spinning another respin.

  BTW, re Ralf's earlier point: for preference please actually /omit/ the
diffs of the generated configure files altogether, we only need to see the
change to the .ac file, because autoconf is very deterministic, and the actual
configure file diffs often contain tons of uninformative noise from the
expansions of all the macros and the changes in error line number reporting(*).

    cheers,
      DaveK

-- 
(*) - Same goes for makefile.am vs. makefile.in, although it's not relevant in
this particular case.

Re: [PATCH] Allow decimal floats for mingw-w64

[JonY]

[-- Attachment #1: Type: text/plain, Size: 1427 bytes --]

On 9/3/2010 08:26, Dave Korn wrote:
> On 24/08/2010 16:06, Kai Tietz wrote:
>> 2010/8/24 JonY<jon_y@users.sourceforge.net>:
>>> Hi,
>>>
>>> Attached patch enables i?86-w64-mingw32 and x86_64-w64-mingw32 decimal float
>>> support with bid.
>>>
>>> Tested with x86_64-w64-mingw32. Is attached patch OK for trunk?
>>>
>>>
>>>
>>> 2010-08-24  Jonathan Yong<jon_y@users.sourceforge.net>
>>>
>>>         * configure.ac: Allow w64 targets to use bid decimal floats.
>>>         * configure: Regenerated.
>>>
>>>
>>
>> Patch is from my side ok. I added Dave to CC. Maybe he wants that it
>> gets added for cygwin, too?
>
>    I'm currently testing a build that I did with Uros' patch and manually
> configuring with '--enable-decimal-float' and it seems to be going pretty
> well, so yes please Jon, if you don't mind spinning another respin.
>

Spinning another respin? I thought --enable-decimal-float was ignored
for cygwin and mingw?

>    BTW, re Ralf's earlier point: for preference please actually /omit/ the
> diffs of the generated configure files altogether, we only need to see the
> change to the .ac file, because autoconf is very deterministic, and the actual
> configure file diffs often contain tons of uninformative noise from the
> expansions of all the macros and the changes in error line number reporting(*).
>

Yes, I was wondering about that. New patch attached, this time only
configure.ac and the new m4 file.

[-- Attachment #2: dfp2.patch --]
[-- Type: text/plain, Size: 7819 bytes --]

Index: config/dfp.m4
===================================================================
--- config/dfp.m4	(revision 0)
+++ config/dfp.m4	(revision 0)
@@ -0,0 +1,73 @@
+dnl Copyright (C) 2010 Free Software Foundation, Inc.
+dnl This file is free software, distributed under the terms of the GNU
+dnl General Public License.  As a special exception to the GNU General
+dnl Public License, this file may be distributed as part of a program
+dnl that contains a configuration script generated by Autoconf, under
+dnl the same distribution terms as the rest of that program.
+
+dnl AC_SUBSTs and defines enable_decimal_float depending on $target and
+dnl ENABLE_DECIMAL_BID_FORMAT and ENABLE_DECIMAL_FLOAT where appropriate.
+
+AC_DEFUN([GCC_DFP_TARGET],
+[
+  # Enable C extension for decimal float if target supports it.
+  AC_ARG_ENABLE(decimal-float,
+  [  --enable-decimal-float={no,yes,bid,dpd}
+                          enable decimal float extension to C.  Selecting 'bid'
+                          or 'dpd' choses which decimal floating point format
+                          to use],
+  [
+    case $enable_decimal_float in
+      yes | no | bid | dpd) ;;
+      *) AC_MSG_ERROR(['$enable_decimal_float' is an invalid value for --enable-decimal-float.
+  Valid choices are 'yes', 'bid', 'dpd', and 'no'.]) ;;
+    esac
+  ],
+  [
+    case $target in
+      powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | \
+      i?86*-*-mingw* | x86_64*-*-mingw* | \
+      i?86*-*-cygwin*)
+        enable_decimal_float=yes
+        ;;
+      *)
+        AC_MSG_WARN(decimal float is not supported for this target, ignored)
+        enable_decimal_float=no
+        ;;
+    esac
+  ])
+
+  dfp=`if test $enable_decimal_float != no; then echo 1; else echo 0; fi`
+  AC_DEFINE_UNQUOTED(ENABLE_DECIMAL_FLOAT, $dfp,
+  [Define to 1 to enable decimal float extension to C.])
+  AC_MSG_CHECKING([for decimal floating point])
+  AC_MSG_RESULT($enable_decimal_float)
+
+  # x86's use BID format instead of DPD
+  case x$enable_decimal_float in
+    xyes)
+      case $target in
+        i?86*-*-linux* | x86_64*-*-linux* | \
+        i?86*-*-mingw* | x86_64*-*-mingw* | \
+        i?86*-*-cygwin*)
+    enable_decimal_float=bid
+    ;;
+        *)
+    enable_decimal_float=dpd
+    ;;
+      esac
+      ;;
+    xno)
+      # ENABLE_DECIMAL_FLOAT is set to 0. But we have to have proper
+      # dependency on libdecnumber.
+      enable_decimal_float=dpd
+      ;;
+  esac
+
+  bid=`if test $enable_decimal_float = bid; then echo 1; else echo 0; fi`
+  AC_DEFINE_UNQUOTED(ENABLE_DECIMAL_BID_FORMAT, $bid,
+  [Define to 1 to specify that we are using the BID decimal floating
+  point format instead of DPD])
+
+  AC_SUBST(enable_decimal_float)
+])
Index: libdecnumber/configure.ac
===================================================================
--- libdecnumber/configure.ac	(revision 163756)
+++ libdecnumber/configure.ac	(working copy)
@@ -72,46 +72,8 @@
 
 AC_CANONICAL_TARGET
 
-# Default decimal format
-# If you change the defaults here, be sure to change them in the GCC directory also
-AC_MSG_CHECKING([for decimal floating point])
-AC_ARG_ENABLE(decimal-float,
-[  --enable-decimal-float={no,yes,bid,dpd}
-			enable decimal float extension to C.  Selecting 'bid'
-			or 'dpd' choses which decimal floating point format
-			to use],
-[
-  case $enable_decimal_float in
-    yes | no | bid | dpd) ;;
-    *) AC_MSG_ERROR(['$enable_decimal_float' is an invalid value for --enable-decimal-float.
-Valid choices are 'yes', 'bid', 'dpd', and 'no'.]) ;;
-  esac
-],
-[
-  case $target in
-    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux*)
-      enable_decimal_float=yes
-      ;;
-    *)
-      enable_decimal_float=no
-      ;;
-  esac
-])
+GCC_DFP_TARGET
 
-# x86's use BID format instead of DPD
-# In theory --enable-decimal-float=no should not compile anything
-# For the sake of simplicity, just use the default format in this directory
-if test x$enable_decimal_float = xyes -o x$enable_decimal_float = xno; then
-  case $target in
-    i?86*-*-linux* | x86_64*-*-linux*)
-      enable_decimal_float=bid
-      ;;
-    *)
-      enable_decimal_float=dpd
-      ;;
-  esac
-fi
-
 # If BID is being used, additional objects should be linked in.
 if test x$enable_decimal_float = xbid; then
   ADDITIONAL_OBJS="$ADDITIONAL_OBJS \$(bid_OBJS)"
@@ -119,8 +81,6 @@
   ADDITIONAL_OBJS=
 fi
 
-AC_MSG_RESULT($enable_decimal_float)
-AC_SUBST(enable_decimal_float)
 AC_SUBST(ADDITIONAL_OBJS)
 
 AC_C_BIGENDIAN
Index: libgcc/configure.ac
===================================================================
--- libgcc/configure.ac	(revision 163756)
+++ libgcc/configure.ac	(working copy)
@@ -125,42 +125,8 @@
 decimal_float=$libgcc_cv_dfp
 AC_SUBST(decimal_float)
 
-AC_ARG_ENABLE(decimal-float,
-[  --enable-decimal-float={no,yes,bid,dpd}
-			enable decimal float extension to C.  Selecting 'bid'
-			or 'dpd' choses which decimal floating point format
-			to use],
-[
-  case $enable_decimal_float in
-    yes | no | bid | dpd) ;;
-    *) AC_MSG_ERROR(['$enable_decimal_float' is an invalid value for --enable-decimal-float.
-Valid choices are 'yes', 'bid', 'dpd', and 'no'.]) ;;
-  esac
-],
-[
-  case $host in
-    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux*)
-      enable_decimal_float=yes
-      ;;
-    *)
-      enable_decimal_float=no
-      ;;
-  esac
-])
+GCC_DFP_TARGET
 
-# x86's use BID format instead of DPD
-if test x$enable_decimal_float = xyes; then
-  case $host in
-    i?86*-*-linux* | x86_64*-*-linux*)
-      enable_decimal_float=bid
-      ;;
-    *)
-      enable_decimal_float=dpd
-      ;;
-  esac
-fi
-AC_SUBST(enable_decimal_float)
-
 # Check for fixed-point support.
 AC_CACHE_CHECK([whether fixed-point is supported], [libgcc_cv_fixed_point],
 	       [AC_COMPILE_IFELSE([_Sat _Fract x;], [libgcc_cv_fixed_point=yes],
Index: gcc/configure.ac
===================================================================
--- gcc/configure.ac	(revision 163756)
+++ gcc/configure.ac	(working copy)
@@ -606,59 +606,8 @@
 [], [])
 
 # Enable C extension for decimal float if target supports it.
-AC_ARG_ENABLE(decimal-float,
-[  --enable-decimal-float={no,yes,bid,dpd}
-			enable decimal float extension to C.  Selecting 'bid'
-			or 'dpd' choses which decimal floating point format
-			to use],
-[
-  case $enable_decimal_float in
-    yes | no | bid | dpd) ;;
-    *) AC_MSG_ERROR(['$enable_decimal_float' is an invalid value for --enable-decimal-float.
-Valid choices are 'yes', 'bid', 'dpd', and 'no'.]) ;;
-  esac
-],
-[
-  case $target in
-    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux*)
-      enable_decimal_float=yes
-      ;;
-    *)
-      AC_MSG_WARN(decimal float is not supported for this target, ignored)
-      enable_decimal_float=no
-      ;;
-  esac
-])
+GCC_DFP_TARGET
 
-dfp=`if test $enable_decimal_float != no; then echo 1; else echo 0; fi`
-AC_DEFINE_UNQUOTED(ENABLE_DECIMAL_FLOAT, $dfp,
-[Define to 1 to enable decimal float extension to C.])
-
-# x86's use BID format instead of DPD
-case x$enable_decimal_float in
-  xyes)
-    case $target in
-      i?86*-*-linux* | x86_64*-*-linux*)
-	enable_decimal_float=bid
-	;;
-      *)
-	enable_decimal_float=dpd
-	;;
-    esac
-    ;;
-  xno)
-    # ENABLE_DECIMAL_FLOAT is set to 0. But we have to have proper
-    # dependency on libdecnumber.
-    enable_decimal_float=dpd
-    ;;
-esac
-AC_SUBST(enable_decimal_float)
-
-bid=`if test $enable_decimal_float = bid; then echo 1; else echo 0; fi`
-AC_DEFINE_UNQUOTED(ENABLE_DECIMAL_BID_FORMAT, $bid,
-[Define to 1 to specify that we are using the BID decimal floating
-point format instead of DPD])
-
 # Enable C extension for fixed-point arithmetic.
 AC_ARG_ENABLE(fixed-point,
 [  --enable-fixed-point    enable fixed-point arithmetic extension to C],

Re: [PATCH] Allow decimal floats for cygming (was: [PATCH] Allow decimal floats for mingw-w64)

[JonY]

On 9/2/2010 22:38, JonY wrote:
> On 8/24/2010 22:57, JonY wrote:
>> On 8/24/2010 23:05, Joseph S. Myers wrote:
>>> On Tue, 24 Aug 2010, JonY wrote:
>>>
>>>> Hi,
>>>>
>>>> Attached patch enables i?86-w64-mingw32 and x86_64-w64-mingw32
>>>> decimal float
>>>> support with bid.
>>>
>>> My previous comments about the several places to keep in sync
>>> <http://gcc.gnu.org/ml/gcc-patches/2010-02/msg00933.html> apply
>>> equally to
>>> this patch (see also followups to the previous comments).
>>>
>>
>> Thanks for the heads up. New patch with quick fixes attached.
>>
>> Do you want the GCC_AC_ENABLE_DECIMAL_FLOAT version instead?
>
> Here is a new attached patch based on the link above. It mostly copies
> the existing logic and consolidates them into a single file.
>
> Bootstrap tested on i686-pc-cygwin.

Ping.

Re: [PATCH] Allow decimal floats for mingw-w64

[Kai Tietz]

2010/9/3 JonY <jon_y@users.sourceforge.net>:
> On 9/3/2010 08:26, Dave Korn wrote:
>>
>> On 24/08/2010 16:06, Kai Tietz wrote:
>>>
>>> 2010/8/24 JonY<jon_y@users.sourceforge.net>:
>>>>
>>>> Hi,
>>>>
>>>> Attached patch enables i?86-w64-mingw32 and x86_64-w64-mingw32 decimal
>>>> float
>>>> support with bid.
>>>>
>>>> Tested with x86_64-w64-mingw32. Is attached patch OK for trunk?
>>>>
>>>>
>>>>
>>>> 2010-08-24  Jonathan Yong<jon_y@users.sourceforge.net>
>>>>
>>>>        * configure.ac: Allow w64 targets to use bid decimal floats.
>>>>        * configure: Regenerated.
>>>>
>>>>
>>>
>>> Patch is from my side ok. I added Dave to CC. Maybe he wants that it
>>> gets added for cygwin, too?
>>
>>   I'm currently testing a build that I did with Uros' patch and manually
>> configuring with '--enable-decimal-float' and it seems to be going pretty
>> well, so yes please Jon, if you don't mind spinning another respin.
>>
>
> Spinning another respin? I thought --enable-decimal-float was ignored
> for cygwin and mingw?
>
>>   BTW, re Ralf's earlier point: for preference please actually /omit/ the
>> diffs of the generated configure files altogether, we only need to see the
>> change to the .ac file, because autoconf is very deterministic, and the
>> actual
>> configure file diffs often contain tons of uninformative noise from the
>> expansions of all the macros and the changes in error line number
>> reporting(*).
>>
>
> Yes, I was wondering about that. New patch attached, this time only
> configure.ac and the new m4 file.
>

Hello,

Patch is ok. Thanks for reworking this but I would like that Paolo
takes a look on it, too.

Thanks,
Kai

-- 
|  (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination

Re: [PATCH] Allow decimal floats for mingw-w64

[H.J. Lu]

On Tue, Sep 7, 2010 at 1:51 AM, Kai Tietz <ktietz70@googlemail.com> wrote:
> 2010/9/3 JonY <jon_y@users.sourceforge.net>:
>> On 9/3/2010 08:26, Dave Korn wrote:
>>>
>>> On 24/08/2010 16:06, Kai Tietz wrote:
>>>>
>>>> 2010/8/24 JonY<jon_y@users.sourceforge.net>:
>>>>>
>>>>> Hi,
>>>>>
>>>>> Attached patch enables i?86-w64-mingw32 and x86_64-w64-mingw32 decimal
>>>>> float
>>>>> support with bid.
>>>>>
>>>>> Tested with x86_64-w64-mingw32. Is attached patch OK for trunk?
>>>>>
>>>>>
>>>>>
>>>>> 2010-08-24  Jonathan Yong<jon_y@users.sourceforge.net>
>>>>>
>>>>>        * configure.ac: Allow w64 targets to use bid decimal floats.
>>>>>        * configure: Regenerated.
>>>>>
>>>>>
>>>>
>>>> Patch is from my side ok. I added Dave to CC. Maybe he wants that it
>>>> gets added for cygwin, too?
>>>
>>>   I'm currently testing a build that I did with Uros' patch and manually
>>> configuring with '--enable-decimal-float' and it seems to be going pretty
>>> well, so yes please Jon, if you don't mind spinning another respin.
>>>
>>
>> Spinning another respin? I thought --enable-decimal-float was ignored
>> for cygwin and mingw?
>>
>>>   BTW, re Ralf's earlier point: for preference please actually /omit/ the
>>> diffs of the generated configure files altogether, we only need to see the
>>> change to the .ac file, because autoconf is very deterministic, and the
>>> actual
>>> configure file diffs often contain tons of uninformative noise from the
>>> expansions of all the macros and the changes in error line number
>>> reporting(*).
>>>
>>
>> Yes, I was wondering about that. New patch attached, this time only
>> configure.ac and the new m4 file.
>>
>
> Hello,
>
> Patch is ok. Thanks for reworking this but I would like that Paolo
> takes a look on it, too.
>

Does this patch apply to trunk?


-- 
H.J.

Re: [PATCH] Allow decimal floats for mingw-w64

[JonY]

On 9/7/2010 22:06, H.J. Lu wrote:
> On Tue, Sep 7, 2010 at 1:51 AM, Kai Tietz<ktietz70@googlemail.com>  wrote:
>> 2010/9/3 JonY<jon_y@users.sourceforge.net>:
>>> On 9/3/2010 08:26, Dave Korn wrote:
>>>>
>>>> On 24/08/2010 16:06, Kai Tietz wrote:
>>>>>
>>>>> 2010/8/24 JonY<jon_y@users.sourceforge.net>:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Attached patch enables i?86-w64-mingw32 and x86_64-w64-mingw32 decimal
>>>>>> float
>>>>>> support with bid.
>>>>>>
>>>>>> Tested with x86_64-w64-mingw32. Is attached patch OK for trunk?
>>>>>>
>>>>>>
>>>>>>
>>>>>> 2010-08-24  Jonathan Yong<jon_y@users.sourceforge.net>
>>>>>>
>>>>>>         * configure.ac: Allow w64 targets to use bid decimal floats.
>>>>>>         * configure: Regenerated.
>>>>>>
>>>>>>
>>>>>
>>>>> Patch is from my side ok. I added Dave to CC. Maybe he wants that it
>>>>> gets added for cygwin, too?
>>>>
>>>>    I'm currently testing a build that I did with Uros' patch and manually
>>>> configuring with '--enable-decimal-float' and it seems to be going pretty
>>>> well, so yes please Jon, if you don't mind spinning another respin.
>>>>
>>>
>>> Spinning another respin? I thought --enable-decimal-float was ignored
>>> for cygwin and mingw?
>>>
>>>>    BTW, re Ralf's earlier point: for preference please actually /omit/ the
>>>> diffs of the generated configure files altogether, we only need to see the
>>>> change to the .ac file, because autoconf is very deterministic, and the
>>>> actual
>>>> configure file diffs often contain tons of uninformative noise from the
>>>> expansions of all the macros and the changes in error line number
>>>> reporting(*).
>>>>
>>>
>>> Yes, I was wondering about that. New patch attached, this time only
>>> configure.ac and the new m4 file.
>>>
>>
>> Hello,
>>
>> Patch is ok. Thanks for reworking this but I would like that Paolo
>> takes a look on it, too.
>>
>
> Does this patch apply to trunk?
>
>

Well, its supposed to be for gcc trunk.

I did make another patch without the autoreconf stuff added, did it get 
lost?

Re: [PATCH] Allow decimal floats for mingw-w64

[H.J. Lu]

On Tue, Sep 7, 2010 at 8:29 AM, JonY <jon_y@users.sourceforge.net> wrote:
> On 9/7/2010 22:06, H.J. Lu wrote:
>>
>> On Tue, Sep 7, 2010 at 1:51 AM, Kai Tietz<ktietz70@googlemail.com>  wrote:
>>>
>>> 2010/9/3 JonY<jon_y@users.sourceforge.net>:
>>>>
>>>> On 9/3/2010 08:26, Dave Korn wrote:
>>>>>
>>>>> On 24/08/2010 16:06, Kai Tietz wrote:
>>>>>>
>>>>>> 2010/8/24 JonY<jon_y@users.sourceforge.net>:
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> Attached patch enables i?86-w64-mingw32 and x86_64-w64-mingw32
>>>>>>> decimal
>>>>>>> float
>>>>>>> support with bid.
>>>>>>>
>>>>>>> Tested with x86_64-w64-mingw32. Is attached patch OK for trunk?
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> 2010-08-24  Jonathan Yong<jon_y@users.sourceforge.net>
>>>>>>>
>>>>>>>        * configure.ac: Allow w64 targets to use bid decimal floats.
>>>>>>>        * configure: Regenerated.
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> Patch is from my side ok. I added Dave to CC. Maybe he wants that it
>>>>>> gets added for cygwin, too?
>>>>>
>>>>>   I'm currently testing a build that I did with Uros' patch and
>>>>> manually
>>>>> configuring with '--enable-decimal-float' and it seems to be going
>>>>> pretty
>>>>> well, so yes please Jon, if you don't mind spinning another respin.
>>>>>
>>>>
>>>> Spinning another respin? I thought --enable-decimal-float was ignored
>>>> for cygwin and mingw?
>>>>
>>>>>   BTW, re Ralf's earlier point: for preference please actually /omit/
>>>>> the
>>>>> diffs of the generated configure files altogether, we only need to see
>>>>> the
>>>>> change to the .ac file, because autoconf is very deterministic, and the
>>>>> actual
>>>>> configure file diffs often contain tons of uninformative noise from the
>>>>> expansions of all the macros and the changes in error line number
>>>>> reporting(*).
>>>>>
>>>>
>>>> Yes, I was wondering about that. New patch attached, this time only
>>>> configure.ac and the new m4 file.
>>>>
>>>
>>> Hello,
>>>
>>> Patch is ok. Thanks for reworking this but I would like that Paolo
>>> takes a look on it, too.
>>>
>>
>> Does this patch apply to trunk?
>>
>>
>
> Well, its supposed to be for gcc trunk.
>
> I did make another patch without the autoreconf stuff added, did it get
> lost?
>

Where is it? Have you tried it on today's trunk?


-- 
H.J.

Re: [PATCH] Allow decimal floats for mingw-w64

[H.J. Lu]

On Tue, Sep 7, 2010 at 8:29 AM, JonY <jon_y@users.sourceforge.net> wrote:
> On 9/7/2010 22:06, H.J. Lu wrote:
>>
>> On Tue, Sep 7, 2010 at 1:51 AM, Kai Tietz<ktietz70@googlemail.com>  wrote:
>>>
>>> 2010/9/3 JonY<jon_y@users.sourceforge.net>:
>>>>
>>>> On 9/3/2010 08:26, Dave Korn wrote:
>>>>>
>>>>> On 24/08/2010 16:06, Kai Tietz wrote:
>>>>>>
>>>>>> 2010/8/24 JonY<jon_y@users.sourceforge.net>:
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> Attached patch enables i?86-w64-mingw32 and x86_64-w64-mingw32
>>>>>>> decimal
>>>>>>> float
>>>>>>> support with bid.
>>>>>>>
>>>>>>> Tested with x86_64-w64-mingw32. Is attached patch OK for trunk?
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> 2010-08-24  Jonathan Yong<jon_y@users.sourceforge.net>
>>>>>>>
>>>>>>>        * configure.ac: Allow w64 targets to use bid decimal floats.
>>>>>>>        * configure: Regenerated.
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> Patch is from my side ok. I added Dave to CC. Maybe he wants that it
>>>>>> gets added for cygwin, too?
>>>>>
>>>>>   I'm currently testing a build that I did with Uros' patch and
>>>>> manually
>>>>> configuring with '--enable-decimal-float' and it seems to be going
>>>>> pretty
>>>>> well, so yes please Jon, if you don't mind spinning another respin.
>>>>>
>>>>
>>>> Spinning another respin? I thought --enable-decimal-float was ignored
>>>> for cygwin and mingw?
>>>>
>>>>>   BTW, re Ralf's earlier point: for preference please actually /omit/
>>>>> the
>>>>> diffs of the generated configure files altogether, we only need to see
>>>>> the
>>>>> change to the .ac file, because autoconf is very deterministic, and the
>>>>> actual
>>>>> configure file diffs often contain tons of uninformative noise from the
>>>>> expansions of all the macros and the changes in error line number
>>>>> reporting(*).
>>>>>
>>>>
>>>> Yes, I was wondering about that. New patch attached, this time only
>>>> configure.ac and the new m4 file.
>>>>
>>>
>>> Hello,
>>>
>>> Patch is ok. Thanks for reworking this but I would like that Paolo
>>> takes a look on it, too.
>>>
>>
>> Does this patch apply to trunk?
>>
>>
>
> Well, its supposed to be for gcc trunk.
>
> I did make another patch without the autoreconf stuff added, did it get
> lost?
>

Where is it? Have you tried it on today's trunk?


-- 
H.J.

Re: [PATCH] Allow decimal floats for mingw-w64

[JonY]

On 9/7/2010 23:57, H.J. Lu wrote:
> On Tue, Sep 7, 2010 at 8:29 AM, JonY<jon_y@users.sourceforge.net>  wrote:
>> On 9/7/2010 22:06, H.J. Lu wrote:
>>>
>>> On Tue, Sep 7, 2010 at 1:51 AM, Kai Tietz<ktietz70@googlemail.com>    wrote:
>>>>
>>>> 2010/9/3 JonY<jon_y@users.sourceforge.net>:
>>>>>
>>>>> On 9/3/2010 08:26, Dave Korn wrote:
>>>>>>
>>>>>> On 24/08/2010 16:06, Kai Tietz wrote:
>>>>>>>
>>>>>>> 2010/8/24 JonY<jon_y@users.sourceforge.net>:
>>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> Attached patch enables i?86-w64-mingw32 and x86_64-w64-mingw32
>>>>>>>> decimal
>>>>>>>> float
>>>>>>>> support with bid.
>>>>>>>>
>>>>>>>> Tested with x86_64-w64-mingw32. Is attached patch OK for trunk?
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> 2010-08-24  Jonathan Yong<jon_y@users.sourceforge.net>
>>>>>>>>
>>>>>>>>         * configure.ac: Allow w64 targets to use bid decimal floats.
>>>>>>>>         * configure: Regenerated.
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>> Patch is from my side ok. I added Dave to CC. Maybe he wants that it
>>>>>>> gets added for cygwin, too?
>>>>>>
>>>>>>    I'm currently testing a build that I did with Uros' patch and
>>>>>> manually
>>>>>> configuring with '--enable-decimal-float' and it seems to be going
>>>>>> pretty
>>>>>> well, so yes please Jon, if you don't mind spinning another respin.
>>>>>>
>>>>>
>>>>> Spinning another respin? I thought --enable-decimal-float was ignored
>>>>> for cygwin and mingw?
>>>>>
>>>>>>    BTW, re Ralf's earlier point: for preference please actually /omit/
>>>>>> the
>>>>>> diffs of the generated configure files altogether, we only need to see
>>>>>> the
>>>>>> change to the .ac file, because autoconf is very deterministic, and the
>>>>>> actual
>>>>>> configure file diffs often contain tons of uninformative noise from the
>>>>>> expansions of all the macros and the changes in error line number
>>>>>> reporting(*).
>>>>>>
>>>>>
>>>>> Yes, I was wondering about that. New patch attached, this time only
>>>>> configure.ac and the new m4 file.
>>>>>
>>>>
>>>> Hello,
>>>>
>>>> Patch is ok. Thanks for reworking this but I would like that Paolo
>>>> takes a look on it, too.
>>>>
>>>
>>> Does this patch apply to trunk?
>>>
>>>
>>
>> Well, its supposed to be for gcc trunk.
>>
>> I did make another patch without the autoreconf stuff added, did it get
>> lost?
>>
>
> Where is it? Have you tried it on today's trunk?
>
>

I seems somebody has already committed a somewhat related patch, I'll 
need to rework mine.

Re: [PATCH] Allow decimal floats for mingw-w64

[JonY]

On 9/7/2010 23:56, JonY wrote:
> On 9/7/2010 23:57, H.J. Lu wrote:
>> On Tue, Sep 7, 2010 at 8:29 AM, JonY<jon_y@users.sourceforge.net> wrote:
>>> On 9/7/2010 22:06, H.J. Lu wrote:
>>>>
>>>> On Tue, Sep 7, 2010 at 1:51 AM, Kai Tietz<ktietz70@googlemail.com> 
>>>> wrote:
>>>>>
>>>>> 2010/9/3 JonY<jon_y@users.sourceforge.net>:
>>>>>>
>>>>>> On 9/3/2010 08:26, Dave Korn wrote:
>>>>>>>
>>>>>>> On 24/08/2010 16:06, Kai Tietz wrote:
>>>>>>>>
>>>>>>>> 2010/8/24 JonY<jon_y@users.sourceforge.net>:
>>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> Attached patch enables i?86-w64-mingw32 and x86_64-w64-mingw32
>>>>>>>>> decimal
>>>>>>>>> float
>>>>>>>>> support with bid.
>>>>>>>>>
>>>>>>>>> Tested with x86_64-w64-mingw32. Is attached patch OK for trunk?
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> 2010-08-24 Jonathan Yong<jon_y@users.sourceforge.net>
>>>>>>>>>
>>>>>>>>> * configure.ac: Allow w64 targets to use bid decimal floats.
>>>>>>>>> * configure: Regenerated.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>> Patch is from my side ok. I added Dave to CC. Maybe he wants 
>>>>>>>> that it
>>>>>>>> gets added for cygwin, too?
>>>>>>>
>>>>>>> I'm currently testing a build that I did with Uros' patch and
>>>>>>> manually
>>>>>>> configuring with '--enable-decimal-float' and it seems to be going
>>>>>>> pretty
>>>>>>> well, so yes please Jon, if you don't mind spinning another respin.
>>>>>>>
>>>>>>
>>>>>> Spinning another respin? I thought --enable-decimal-float was ignored
>>>>>> for cygwin and mingw?
>>>>>>
>>>>>>> BTW, re Ralf's earlier point: for preference please actually /omit/
>>>>>>> the
>>>>>>> diffs of the generated configure files altogether, we only need 
>>>>>>> to see
>>>>>>> the
>>>>>>> change to the .ac file, because autoconf is very deterministic, 
>>>>>>> and the
>>>>>>> actual
>>>>>>> configure file diffs often contain tons of uninformative noise 
>>>>>>> from the
>>>>>>> expansions of all the macros and the changes in error line number
>>>>>>> reporting(*).
>>>>>>>
>>>>>>
>>>>>> Yes, I was wondering about that. New patch attached, this time only
>>>>>> configure.ac and the new m4 file.
>>>>>>
>>>>>
>>>>> Hello,
>>>>>
>>>>> Patch is ok. Thanks for reworking this but I would like that Paolo
>>>>> takes a look on it, too.
>>>>>
>>>>
>>>> Does this patch apply to trunk?
>>>>
>>>>
>>>
>>> Well, its supposed to be for gcc trunk.
>>>
>>> I did make another patch without the autoreconf stuff added, did it get
>>> lost?
>>>
>>
>> Where is it? Have you tried it on today's trunk?
>>
>>
> 
> I seems somebody has already committed a somewhat related patch, I'll 
> need to rework mine.

Looks like most of the changes are in, the only parts needed changing was:

Index: config/dfp.m4
===================================================================
--- config/dfp.m4       (revision 163959)
+++ config/dfp.m4       (working copy)
@@ -20,7 +20,9 @@
 ],
 [
   case $1 in
-    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | s390*-*-linux*)
+    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | s390*-*-linux* | \
+    i?86*-*-mingw* | x86_64*-*-mingw* |\
+    i?86*-*-cygwin* )
       enable_decimal_float=yes
       ;;
     *)

Re: [PATCH] Allow decimal floats for mingw-w64

[Paolo Bonzini]

On 09/07/2010 06:12 PM, JonY wrote:
> Looks like most of the changes are in, the only parts needed changing was:
>
> Index: config/dfp.m4
> ===================================================================
> --- config/dfp.m4       (revision 163959)
> +++ config/dfp.m4       (working copy)
> @@ -20,7 +20,9 @@
>   ],
>   [
>     case $1 in
> -    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | s390*-*-linux*)
> +    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | s390*-*-linux* | \
> +    i?86*-*-mingw* | x86_64*-*-mingw* |\
> +    i?86*-*-cygwin* )
>         enable_decimal_float=yes
>         ;;
>       *)
>

This looks fine, thanks.  Dave/Kai?

Paolo

Re: [PATCH] Allow decimal floats for mingw-w64

[Kai Tietz]

2010/9/7 Paolo Bonzini <bonzini@gnu.org>:
> On 09/07/2010 06:12 PM, JonY wrote:
>>
>> Looks like most of the changes are in, the only parts needed changing was:
>>
>> Index: config/dfp.m4
>> ===================================================================
>> --- config/dfp.m4       (revision 163959)
>> +++ config/dfp.m4       (working copy)
>> @@ -20,7 +20,9 @@
>>  ],
>>  [
>>    case $1 in
>> -    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* |
>> s390*-*-linux*)
>> +    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* |
>> s390*-*-linux* | \
>> +    i?86*-*-mingw* | x86_64*-*-mingw* |\
>> +    i?86*-*-cygwin* )
>>        enable_decimal_float=yes
>>        ;;
>>      *)
>>
>
> This looks fine, thanks.  Dave/Kai?
>
> Paolo
>

Yes, this is ok by me. Paolo, will you commit it, or should I do?

Thanks,
Kai

-- 
|  (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination

Re: [PATCH] Allow decimal floats for mingw-w64

[Paolo Bonzini]

On 09/07/2010 07:25 PM, Kai Tietz wrote:
> 2010/9/7 Paolo Bonzini<bonzini@gnu.org>:
>> On 09/07/2010 06:12 PM, JonY wrote:
>>>
>>> Looks like most of the changes are in, the only parts needed changing was:
>>>
>>> Index: config/dfp.m4
>>> ===================================================================
>>> --- config/dfp.m4       (revision 163959)
>>> +++ config/dfp.m4       (working copy)
>>> @@ -20,7 +20,9 @@
>>>   ],
>>>   [
>>>     case $1 in
>>> -    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* |
>>> s390*-*-linux*)
>>> +    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* |
>>> s390*-*-linux* | \
>>> +    i?86*-*-mingw* | x86_64*-*-mingw* |\
>>> +    i?86*-*-cygwin* )
>>>         enable_decimal_float=yes
>>>         ;;
>>>       *)
>>>
>>
>> This looks fine, thanks.  Dave/Kai?
>>
>> Paolo
>>
>
> Yes, this is ok by me. Paolo, will you commit it, or should I do?

Please do it for both gcc and src.

Paolo

Re: [PATCH] Allow decimal floats for mingw-w64

[Dave Korn]

[-- Attachment #1: Type: text/plain, Size: 1727 bytes --]

On 07/09/2010 18:25, Kai Tietz wrote:
> 2010/9/7 Paolo Bonzini <bonzini@gnu>:
>> On 09/07/2010 06:12 PM, JonY wrote:
>>> Looks like most of the changes are in, the only parts needed changing was:
>>>
>>> Index: config/dfp.m4
>>> ===================================================================
>>> --- config/dfp.m4       (revision 163959)
>>> +++ config/dfp.m4       (working copy)
>>> @@ -20,7 +20,9 @@
>>>  ],
>>>  [
>>>    case $1 in
>>> -    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* |
>>> s390*-*-linux*)
>>> +    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* |
>>> s390*-*-linux* | \
>>> +    i?86*-*-mingw* | x86_64*-*-mingw* |\
>>> +    i?86*-*-cygwin* )
>>>        enable_decimal_float=yes
>>>        ;;
>>>      *)
>>>
>> This looks fine, thanks.  Dave/Kai?
>>
>> Paolo
>>
> 
> Yes, this is ok by me. 

  Me too, in principle.  The final piece of the puzzle AFAICT is that we still
need to enable libbid in libgcc by adding the t-dfprules make frag. I'm
testing the attached patch on Cygwin; I've attached an untested (but hopefully
correct) equivalent for MinGW.

  I can't apply this for Cygwin yet because it needs fenv.h support to build,
but MinGW should be OK (someone had still better test it though, I'm not set
up for testing on MinGW right now).

  (I've got a patch to contribute fenv support to Cygwin that's about 90%
done, and I'll apply the Cygwin patch once that's been sent upstream and
incorporated.)

  Until this is done, there will still be regressions in the testsuite owing
to link failures, but that's not a reason not to start enabling DFP by
default; the compiler side of it all works even if the libc side isn't
complete at the Cygwin end.

    cheers,
      DaveK


[-- Attachment #2: enable-cygwin-libgcc-dfp.diff --]
[-- Type: text/x-c, Size: 570 bytes --]

Index: gcc/config.gcc
===================================================================
--- gcc/config.gcc	(revision 164046)
+++ gcc/config.gcc	(working copy)
@@ -1384,7 +1384,7 @@ i[34567]86-*-pe | i[34567]86-*-cygwin*)
 	else
 		tmake_eh_file="i386/t-sjlj-eh"
 	fi
-	tmake_file="${tmake_file} ${tmake_eh_file} i386/t-cygming i386/t-cygwin"
+	tmake_file="${tmake_file} ${tmake_eh_file} i386/t-cygming i386/t-cygwin t-dfprules"
 	target_gtfiles="\$(srcdir)/config/i386/winnt.c"
 	extra_options="${extra_options} i386/cygming.opt"
 	extra_objs="winnt.o winnt-stubs.o"


[-- Attachment #3: enable-mingw-libgcc-dfp.diff --]
[-- Type: text/x-c, Size: 521 bytes --]

Index: gcc/config.gcc
===================================================================
--- gcc/config.gcc	(revision 164046)
+++ gcc/config.gcc	(working copy)
@@ -1442,7 +1442,7 @@ i[34567]86-*-mingw* | x86_64-*-mingw*)
 	else
 		tmake_eh_file="i386/t-sjlj-eh"
 	fi
-	tmake_file="${tmake_file} ${tmake_eh_file} i386/t-cygming"
+	tmake_file="${tmake_file} ${tmake_eh_file} i386/t-cygming t-dfprules"
         case ${target} in
                x86_64-w64-*)
                		tmake_file="${tmake_file} i386/t-mingw-w64"

Re: [PATCH] Allow decimal floats for mingw-w64

[Kai Tietz]

2010/9/9 Dave Korn <dave.korn.cygwin@gmail.com>:
> On 07/09/2010 18:25, Kai Tietz wrote:
>> 2010/9/7 Paolo Bonzini <bonzini@gnu>:
>>> On 09/07/2010 06:12 PM, JonY wrote:
>>>> Looks like most of the changes are in, the only parts needed changing was:
>>>>
>>>> Index: config/dfp.m4
>>>> ===================================================================
>>>> --- config/dfp.m4       (revision 163959)
>>>> +++ config/dfp.m4       (working copy)
>>>> @@ -20,7 +20,9 @@
>>>>  ],
>>>>  [
>>>>    case $1 in
>>>> -    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* |
>>>> s390*-*-linux*)
>>>> +    powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* |
>>>> s390*-*-linux* | \
>>>> +    i?86*-*-mingw* | x86_64*-*-mingw* |\
>>>> +    i?86*-*-cygwin* )
>>>>        enable_decimal_float=yes
>>>>        ;;
>>>>      *)
>>>>
>>> This looks fine, thanks.  Dave/Kai?
>>>
>>> Paolo
>>>
>>
>> Yes, this is ok by me.
>
>  Me too, in principle.  The final piece of the puzzle AFAICT is that we still
> need to enable libbid in libgcc by adding the t-dfprules make frag. I'm
> testing the attached patch on Cygwin; I've attached an untested (but hopefully
> correct) equivalent for MinGW.
>
>  I can't apply this for Cygwin yet because it needs fenv.h support to build,
> but MinGW should be OK (someone had still better test it though, I'm not set
> up for testing on MinGW right now).
>
>  (I've got a patch to contribute fenv support to Cygwin that's about 90%
> done, and I'll apply the Cygwin patch once that's been sent upstream and
> incorporated.)
>
>  Until this is done, there will still be regressions in the testsuite owing
> to link failures, but that's not a reason not to start enabling DFP by
> default; the compiler side of it all works even if the libc side isn't
> complete at the Cygwin end.
>
>    cheers,
>      DaveK
>
>

Yeah, I found the same issue about the original patch. I was just
bootstrapping mingw's 32-bit and 64-bit version (for the latter I
found some fallout by the .cfi enabling for windows targets together
with HWINT=64-bit).

When my tests are through, I am fine with this additional
configuration patch. If you prefer I can remove i?86*-*-cygwin* for
dfp.m4, so you won't have failures here.

Cheers,
Kai

-- 
|  (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination

Re: [PATCH] Allow decimal floats for mingw-w64

[Dave Korn]

On 09/09/2010 21:20, Kai Tietz wrote:

> When my tests are through, I am fine with this additional
> configuration patch. If you prefer I can remove i?86*-*-cygwin* for
> dfp.m4, so you won't have failures here.

  Nah, as long as I don't add the libgcc configuration before Cygwin supports
fenv.h, the build won't break; people just won't be able to fully use the dfp
support yet.  But since the compiler side will work, and they could always in
theory supply their own libbid routines to link against, I think it's OK to
have it enabled.  The support will be in Cygwin before 4.6.0 gets released.

    cheers,
      DaveK

Re: [PATCH] Allow decimal floats for mingw-w64

[Kai Tietz]

2010/9/9 Dave Korn <dave.korn.cygwin@gmail.com>:
> On 09/09/2010 21:20, Kai Tietz wrote:
>
>> When my tests are through, I am fine with this additional
>> configuration patch. If you prefer I can remove i?86*-*-cygwin* for
>> dfp.m4, so you won't have failures here.
>
>  Nah, as long as I don't add the libgcc configuration before Cygwin supports
> fenv.h, the build won't break; people just won't be able to fully use the dfp
> support yet.  But since the compiler side will work, and they could always in
> theory supply their own libbid routines to link against, I think it's OK to
> have it enabled.  The support will be in Cygwin before 4.6.0 gets released.
>
>    cheers,
>      DaveK
>
>

So committed after bootstrap test for x86_64-w64-mingw32 and i686-w64-mingw32.

ChangeLog config

2010-09-10  Jonathan Yong  <jon_y@users.sourceforge.net>

	* dfp.m4: Enable decimal float for i?86 cygwin
	and mingw, and for x86_64 mingw.

ChangeLog libgcc

2010-09-10  Kai Tietz  <kai.tietz@onevision.com>

       * configure: Regenerated.

ChangeLog libdecnumber

2010-09-10  Kai Tietz  <kai.tietz@onevision.com>

       * configure: Regenerated.


ChangeLog gcc

2010-09-10  Kai Tietz  <kai.tietz@onevision.com>

	* configure: Regenerated.
	* config.gcc: Add for x86_64 and i?86 mingw t-dfprule.

At revision 164167.

Regards,
Kai

PS: Yes, fenv.h isn't an issue for mingw as we provide it already.



-- 
|  (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination