public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Mike Stump <mikestump@comcast.net>
To: Andrew Pinski <pinskia@gmail.com>
Cc: Thomas Preudhomme <thomas.preudhomme@foss.arm.com>,
	Rainer Orth <ro@cebitec.uni-bielefeld.de>,
	"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, GCC/testsuite] Fix dump-noaddr dumpbase
Date: Tue, 05 Dec 2017 19:25:00 -0000	[thread overview]
Message-ID: <4C8BBDFE-8711-40D2-96D3-06F3C8BEB50A@comcast.net> (raw)
In-Reply-To: <CA+=Sn1=TPkVh_oRvQJg-ntBHr5o_2bR1UyKirM7=e=y9-xkbng@mail.gmail.com>

On Dec 5, 2017, at 9:54 AM, Andrew Pinski <pinskia@gmail.com> wrote:
> 
> On Tue, Dec 5, 2017 at 9:50 AM, Thomas Preudhomme
> <thomas.preudhomme@foss.arm.com> wrote:
>> Hi,
>> 
>> dump-noaddr test FAILS when $tmpdir is not the same as the directory
>> where runtest is called from. Note that this does not happen when
>> running make check because tmpdir is set to srcdir.
>> 
>> In that case, file mkdir will create the directory in the current
>> directory while GCC is invoked from tmpdir and hence -dumpbase look
>> for dump1 and dump2 relative to tmpdir. This patch forces dumpbase to
>> be relative to tmpdir which will work in all case.
>> 
>> ChangeLog entry is as follows:
>> 
>> *** gcc/testsuite/ChangeLog ***
>> 
>> 2017-12-05  Thomas Preud'homme  <thomas.preudhomme@arm.com>
>> 
>>        * gcc.c-torture/unsorted/dump-noaddr.x (dump_compare): Set dump base
>>        relative to tmpdir.
>> 
>> Testing: Successfully ran unsorted.exp via make check and out of tree
>> testing using runtest from <path>/test with tmpdir set in
>> <path>/test/site.exp to <path>.
>> 
>> Is this ok for stage3?
> 
> https://gcc.gnu.org/ml/gcc-patches/2012-06/msg01752.html
> I don't remember where this discussion went last time.

I approved his patch last time in:

  https://gcc.gnu.org/ml/gcc-patches/2012-06/msg01752.html

I've not seen anyone argue against it.

> Maybe this time there will be a resolution :).

A resolution would be for someone to check in the approved patch, or ask for it to be installed.  :-o

I've checked it in.  It might not work for canadian crosses, but we can punt that to the next poor soul.

Give it a try and let us know if that cures the problem.  Feel free to just fix it, if you notice anything wrong.  I'm thinking it will cure all the problems people have seen.

  parent reply	other threads:[~2017-12-05 19:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05 17:50 Thomas Preudhomme
2017-12-05 17:54 ` Andrew Pinski
2017-12-05 19:11   ` Thomas Preudhomme
2017-12-05 19:27     ` Mike Stump
2017-12-05 20:56       ` Thomas Preudhomme
2017-12-05 21:26         ` Mike Stump
2018-03-01 16:41           ` Thomas Preudhomme
2019-12-02  4:52       ` Andrew Pinski
2017-12-05 19:25   ` Mike Stump [this message]
2022-11-10  3:00 ` Andrew Pinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C8BBDFE-8711-40D2-96D3-06F3C8BEB50A@comcast.net \
    --to=mikestump@comcast.net \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=pinskia@gmail.com \
    --cc=ro@cebitec.uni-bielefeld.de \
    --cc=thomas.preudhomme@foss.arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).