From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10970 invoked by alias); 3 Oct 2010 11:33:16 -0000 Received: (qmail 10958 invoked by uid 22791); 3 Oct 2010 11:33:15 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 03 Oct 2010 11:33:11 +0000 Received: (qmail 14686 invoked from network); 3 Oct 2010 11:33:09 -0000 Received: from unknown (HELO ?84.152.217.200?) (bernds@127.0.0.2) by mail.codesourcery.com with ESMTPA; 3 Oct 2010 11:33:09 -0000 Message-ID: <4CA86A32.9010603@codesourcery.com> Date: Sun, 03 Oct 2010 11:33:00 -0000 From: Bernd Schmidt User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.9) Gecko/20100911 Lightning/1.0b3pre Thunderbird/3.1.3 MIME-Version: 1.0 To: "H.J. Lu" CC: Jeff Law , Eric Botcazou , gcc-patches@gcc.gnu.org, Steven Bosscher , Jim Wilson Subject: Re: ifcvt/crossjump patch: Fix PR 42496, 21803 References: <4BB3CCCA.7000600@codesourcery.com> <201004101235.54302.ebotcazou@adacore.com> <4BC62EB2.40609@codesourcery.com> <201004200005.53901.ebotcazou@adacore.com> <4C460A1F.4000509@codesourcery.com> <4C56EABB.4030401@redhat.com> <4C56EB55.7010408@codesourcery.com> <4C56ECB1.9060302@redhat.com> <4C56EF21.1060801@codesourcery.com> <4C58232D.8090805@codesourcery.com> <4C58329F.6010902@redhat.com> <4C583639.9070704@codesourcery.com> <4C584E0E.2040408@redhat.com> <4C596CA5.2060207@codesourcery.com> In-Reply-To: Content-Type: multipart/mixed; boundary="------------010700060307030607060504" Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-10/txt/msg00127.txt.bz2 This is a multi-part message in MIME format. --------------010700060307030607060504 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-length: 655 On 10/02/2010 03:07 PM, H.J. Lu wrote: > On Wed, Aug 4, 2010 at 6:35 AM, Bernd Schmidt wrote: >> On 08/03/2010 07:12 PM, Jeff Law wrote: >>> OK. WRT the comment, we might want to just say that BB_MODIFIED is set >>> at the same time as a block is marked dirty, but is not cleared during a >>> df_analyze allowing a pass to update the DF information and still know >>> what blocks were modified. >> >> New patch below. >> > > This caused: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45865 This should fix it, refusing to move NOTE_EPILOGUE_BEGIN and anything beyond it. Bootstrapped and tested on i686-linux, ok? Bernd --------------010700060307030607060504 Content-Type: text/plain; name="epilogue.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="epilogue.diff" Content-length: 496 * df-problems.c (can_move_insns_across): Stop at NOTE_INSN_EPILOGUE_BEG. Index: df-problems.c =================================================================== --- df-problems.c (revision 164552) +++ df-problems.c (working copy) @@ -3915,6 +3915,8 @@ can_move_insns_across (rtx from, rtx to, { if (CALL_P (insn)) break; + if (NOTE_P (insn) && NOTE_KIND (insn) == NOTE_INSN_EPILOGUE_BEG) + break; if (NONDEBUG_INSN_P (insn)) { if (may_trap_p (PATTERN (insn)) --------------010700060307030607060504--