From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27417 invoked by alias); 11 Oct 2010 15:31:18 -0000 Received: (qmail 27404 invoked by uid 22791); 11 Oct 2010 15:31:16 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mail-ew0-f47.google.com (HELO mail-ew0-f47.google.com) (209.85.215.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Oct 2010 15:31:09 +0000 Received: by ewy1 with SMTP id 1so563126ewy.20 for ; Mon, 11 Oct 2010 08:31:07 -0700 (PDT) Received: by 10.213.13.142 with SMTP id c14mr3362682eba.84.1286811066912; Mon, 11 Oct 2010 08:31:06 -0700 (PDT) Received: from [192.168.2.99] (cpc2-cmbg8-0-0-cust61.5-4.cable.virginmedia.com [82.6.108.62]) by mx.google.com with ESMTPS id q54sm7261992eeh.18.2010.10.11.08.31.04 (version=SSLv3 cipher=RC4-MD5); Mon, 11 Oct 2010 08:31:05 -0700 (PDT) Message-ID: <4CB3331F.9020507@gmail.com> Date: Mon, 11 Oct 2010 15:34:00 -0000 From: Dave Korn User-Agent: Thunderbird 2.0.0.17 (Windows/20080914) MIME-Version: 1.0 To: Andi Kleen CC: gcc-patches@gcc.gnu.org, hubicka@ucw.cz, Andi Kleen Subject: Re: [PATCH 1/3] Add native ELF and LTO support in collect2 References: <1286792263-9244-1-git-send-email-andi@firstfloor.org> In-Reply-To: <1286792263-9244-1-git-send-email-andi@firstfloor.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-10/txt/msg00925.txt.bz2 On 11/10/2010 11:17, Andi Kleen wrote: > From: Andi Kleen > > Change collect2 to read the symbol table directly on ELF systems > using libelf. Also add support for the LTO symbol table. > This way collect2 can resolve symbols in a object file > that only has LTO information. > > The LTO parser is closely patterned after the code > in the lto-plugin. Rather than duplicating that code, did you consider implementing the plugin API into collect2? I think this might be quite easy (based on the partial implementation in lto-plugin/lto-symtab.c), and I think if you did it that way you would gain object file format neutrality "for free" as a side-effect. + /* REMOVEME */ You didn't removeme that one! cheers, DaveK