On 10/23/2010 10:56 PM, Eric Botcazou wrote:
>> With this patch, GCC will not combine instructions if they can't be
>> copied. Tested on arm-linux-gnueabi with c,c++,lto. No regressions are
>> found.
>>
>> Is it OK?
>
>  From the above description, as well as the ChangeLog, I would have said no,
> this is too broad.  But the implementation is actually more fine-grained and
> looks sensible to me.  So OK for mainline if (1) you add a comment to the code
> explaining its purpose, e.g. "We are about to copy insns for the case where
> they need to be kept around.  Check that..." and (2) you fix the ChangeLog.
>
> No need to resubmit.
>
Thanks for review. I'm going to commit the attached patch soon with the 
above two points addressed.


Regards,
-- 
Jie Zhang
CodeSourcery