From: Tom de Vries <tom@codesourcery.com>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: Paolo Bonzini <bonzini@gnu.org>,
gcc-patches@gcc.gnu.org, Bernd Schmidt <bernds@codesourcery.com>
Subject: Re: new sign/zero extension elimination pass
Date: Fri, 12 Nov 2010 08:29:00 -0000 [thread overview]
Message-ID: <4CDCF947.1030008@codesourcery.com> (raw)
In-Reply-To: <AANLkTinJtmMZ0vhyP0B0fSkvYuTv-3DuZr0G5WwLZx44@mail.gmail.com>
Eric,
Paolo Bonzini wrote:
> On Mon, Nov 8, 2010 at 22:21, Tom de Vries <tom@codesourcery.com> wrote:
>> I just looked into using DF_INSN_USES, and I'm not sure that using that is a
>> good idea. There is a difference between using note_uses and DF_INSN_USES.
>>
>> If there is an insn
>> ...
>> (set
>> (reg:SI 1)
>> (plus:SI (reg:SI 2)
>> (reg:SI 3)))
>> ...
>>
>> the note_uses helper function will be visited with the plus expression,
>> something that is used in the pass (see note_use in ee.c).
>
> This is an interesting point, thanks.
>
>> Furthermore, I would like to know whether there is a problem with checking in
>> the pass into trunk in its current form. My understanding of the discussion up
>> until now is that the consensus is that the pass is useful, but not fully efficient.
>> I agree with the fact that it's possible to improve it, but I also think that
>> the runtime is negligible (it's an O(n) pass currently) and the benefit of
>> improving the pass will not be worth the effort. I will try to confirm this with
>> a profiling run on spec2000. If the profiling run confirms that the runtime is
>> negligible, is the pass (in principle) ok for trunk?
>
> I am not an RTL reviewer, so my opinion doesn't weigh too much.
>
> Paolo
I profiled the pass on spec2000:
-mabi=32 -mabi=64
ee-pass (usr time): 0.70 1.16
total (usr time): 919.30 879.26
ee-pass (%): 0.08 0.13
The pass takes 0.13% or less of the total usr runtime. Is it necessary to
improve the runtime of this pass?
Thanks,
- Tom
next prev parent reply other threads:[~2010-11-12 8:23 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-18 15:54 Tom de Vries
2010-10-18 16:03 ` Andrew Pinski
2010-10-18 16:59 ` Richard Guenther
2010-10-21 10:06 ` Tom de Vries
2010-10-21 10:44 ` Paolo Bonzini
2010-10-21 11:00 ` Paolo Bonzini
2010-10-21 17:21 ` Paolo Bonzini
2010-10-22 9:05 ` Tom de Vries
2010-10-22 9:24 ` Paolo Bonzini
2010-10-22 9:15 ` Eric Botcazou
2010-10-28 20:45 ` Tom de Vries
2010-10-29 2:11 ` Paolo Bonzini
2010-10-29 2:42 ` Paolo Bonzini
2010-10-31 19:30 ` Tom de Vries
2010-10-31 20:58 ` Joseph S. Myers
2010-10-31 21:11 ` Paolo Bonzini
2010-11-03 18:49 ` Eric Botcazou
2010-10-29 1:04 ` Paolo Bonzini
2010-10-29 1:33 ` Paolo Bonzini
2010-11-03 18:50 ` Eric Botcazou
2010-11-08 21:29 ` Tom de Vries
2010-11-08 22:11 ` Paolo Bonzini
2010-11-12 8:29 ` Tom de Vries [this message]
2010-11-13 10:41 ` Eric Botcazou
2012-07-11 10:31 ` Tom de Vries
2012-07-11 11:42 ` Jakub Jelinek
2012-07-11 13:01 ` Tom de Vries
2012-07-12 1:52 ` Kenneth Zadeck
[not found] ` <4FFE2ADF.2060806@naturalbridge.com>
[not found] ` <4FFE9346.2070806@mentor.com>
2012-07-12 9:21 ` Tom de Vries
2012-07-12 12:05 ` Kenneth Zadeck
2012-07-13 7:54 ` Tom de Vries
2012-07-13 11:39 ` Kenneth Zadeck
2012-07-13 12:58 ` Tom de Vries
2012-07-17 15:17 ` Kenneth Zadeck
2012-07-20 18:41 ` Tom de Vries
2012-08-20 13:40 ` Tom de Vries
2010-10-28 20:55 ` Andrew Pinski
2010-10-28 21:00 ` Andrew Pinski
2010-10-28 21:12 ` Tom de Vries
2010-10-28 22:58 ` Andrew Pinski
2010-10-29 15:06 ` Tom de Vries
2010-10-29 0:34 ` Paolo Bonzini
2010-11-08 21:32 ` Andrew Pinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CDCF947.1030008@codesourcery.com \
--to=tom@codesourcery.com \
--cc=bernds@codesourcery.com \
--cc=bonzini@gnu.org \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).