[Patch] Add HANDLE_PRAGMA_PACK_PUSH_POP to the i386-elf gcc target

[Patch] Add HANDLE_PRAGMA_PACK_PUSH_POP to the i386-elf gcc target

[Marc Jones]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

Hi,

This small patch adds HANDLE_PRAGMA_PACK_PUSH_POP to the i386-elf gcc
target. We use the i386-elf-gcc for the coreboot cross compiler. I
have some code that builds under several compilers and uses #pragma
pack to save ROM space. By adding the HANDLE_PRAGMA_PACK_PUSH_POP, I
can build in coreboot without the #pragma pack warnings.

Signed-off-by: Marc Jones <marcj303@gmail.com>

Marc
-- 
http://se-eng.com

[-- Attachment #2: gcc-4.5.1_pragma.patch --]
[-- Type: application/octet-stream, Size: 530 bytes --]

diff -ur gcc-4.5.1.orig/gcc/config/i386/i386elf.h gcc-4.5.1/gcc/config/i386/i386elf.h
--- gcc-4.5.1.orig/gcc/config/i386/i386elf.h	2010-11-17 19:48:16.184401200 -0700
+++ gcc-4.5.1/gcc/config/i386/i386elf.h	2010-11-17 20:52:54.443969900 -0700
@@ -123,3 +123,6 @@
 #undef ASM_OUTPUT_ALIGNED_BSS
 #define ASM_OUTPUT_ALIGNED_BSS(FILE, DECL, NAME, SIZE, ALIGN) \
   asm_output_aligned_bss (FILE, DECL, NAME, SIZE, ALIGN)
+
+/* Enable parsing of #pragma pack(push,<n>) and #pragma pack(pop).  */
+#define HANDLE_PRAGMA_PACK_PUSH_POP 1

Re: [Patch] Add HANDLE_PRAGMA_PACK_PUSH_POP to the i386-elf gcc target

[Joseph S. Myers]

I think we should just enable HANDLE_PRAGMA_PACK_PUSH_POP unconditionally.  
That eliminates a target macro - one used in front ends, where we would 
particularly like to eliminate them - and simplifies the testsuite (no 
need for tests of this pragma to be conditional), as well as improving 
portability of code between supported targets; I don't see any reason to 
restrict this feature to some targets only.  This in turn obsoletes 
HANDLE_SYSV_PRAGMA as well (the documentation claiming it also affects 
#pragma weak is wrong), so two target macros can die.

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: [Patch] Add HANDLE_PRAGMA_PACK_PUSH_POP to the i386-elf gcc target

[Mike Stump]

On Nov 18, 2010, at 5:15 PM, Joseph S. Myers wrote:
> I think we should just enable HANDLE_PRAGMA_PACK_PUSH_POP unconditionally.  
> That eliminates a target macro - one used in front ends, where we would 
> particularly like to eliminate them - and simplifies the testsuite (no 
> need for tests of this pragma to be conditional), as well as improving 
> portability of code between supported targets; I don't see any reason to 
> restrict this feature to some targets only.  This in turn obsoletes 
> HANDLE_SYSV_PRAGMA as well (the documentation claiming it also affects 
> #pragma weak is wrong), so two target macros can die.

I endorse this as well.

Re: [Patch] Add HANDLE_PRAGMA_PACK_PUSH_POP to the i386-elf gcc target

[Dave Korn]

On 19/11/2010 02:20, Mike Stump wrote:
> On Nov 18, 2010, at 5:15 PM, Joseph S. Myers wrote:
>> I think we should just enable HANDLE_PRAGMA_PACK_PUSH_POP unconditionally.  
>> That eliminates a target macro - one used in front ends, where we would 
>> particularly like to eliminate them - and simplifies the testsuite (no 
>> need for tests of this pragma to be conditional), as well as improving 
>> portability of code between supported targets; I don't see any reason to 
>> restrict this feature to some targets only.  This in turn obsoletes 
>> HANDLE_SYSV_PRAGMA as well (the documentation claiming it also affects 
>> #pragma weak is wrong), so two target macros can die.
> 
> I endorse this as well.

  Thirded!

    cheers,
      DaveK