From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17517 invoked by alias); 4 Dec 2010 08:49:47 -0000 Received: (qmail 17501 invoked by uid 22791); 4 Dec 2010 08:49:46 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mx02.qsc.de (HELO mx02.qsc.de) (213.148.130.14) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 04 Dec 2010 08:49:41 +0000 Received: from [192.168.178.22] (port-92-204-53-80.dynamic.qsc.de [92.204.53.80]) by mx02.qsc.de (Postfix) with ESMTP id 0B8421E294; Sat, 4 Dec 2010 09:49:37 +0100 (CET) Message-ID: <4CFA00A1.6020101@net-b.de> Date: Sat, 04 Dec 2010 08:49:00 -0000 From: Tobias Burnus User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.2.12) Gecko/20101026 SUSE/3.1.6 Thunderbird/3.1.6 MIME-Version: 1.0 To: Daniel Kraft CC: Fortran List , gcc-patches Subject: Re: [Patch, Fortran] PR fortran/46794: Fix ICE with powers of integers References: <4CF97314.4000206@domob.eu> In-Reply-To: <4CF97314.4000206@domob.eu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-12/txt/msg00365.txt.bz2 Dear Daniel, Daniel Kraft wrote: > I do not entirely like the way this is done in the patch (with the two > variables and "special casing"), but don't see a better implementation > -- what do you think? I think it is OK - at least I have trouble finding a better solution. > Regression-tested on x86_64-unknown-linux-gnu without failures -- > though the run somehow looked strange to me (on the compile-farm); > I'll try again to be sure. Ok for trunk? OK for the trunk. Can you check whether one needs to likewise for the 4.5 and 4.4 branch? (I think one should check on source level - the verify_tree might not always catch it. For some reasons, it ICEs here with 4.4 and 4.6 but not with 4.5; however, I think that's rather by chance and not because of a proper casting.) Tobias