From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9928 invoked by alias); 23 Dec 2010 16:54:42 -0000 Received: (qmail 9909 invoked by uid 22791); 23 Dec 2010 16:54:40 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_CF,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 23 Dec 2010 16:54:35 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oBNGsYb5009719 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 23 Dec 2010 11:54:34 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id oBNGsXd9014310; Thu, 23 Dec 2010 11:54:34 -0500 Received: from 1005.home (ovpn-113-20.phx2.redhat.com [10.3.113.20]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id oBNGsUd0005231; Thu, 23 Dec 2010 11:54:32 -0500 Message-ID: <4D137F34.90107@redhat.com> Date: Thu, 23 Dec 2010 20:00:00 -0000 From: Vladimir Makarov User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Thunderbird/3.1.7 MIME-Version: 1.0 To: Andrey Belevantsev CC: Alexander Monakov , gcc-patches@gcc.gnu.org Subject: Re: [PR47036] sel-sched: don't attempt to move up unconditional jumps References: <4D12676E.5030003@ispras.ru> In-Reply-To: <4D12676E.5030003@ispras.ru> Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-12/txt/msg01787.txt.bz2 On 12/22/2010 04:02 PM, Andrey Belevantsev wrote: > On 22.12.2010 20:57, Alexander Monakov wrote: >> Hi, >> >> This patch drops bits of support for moving up unconditional jumps. >> The rest >> of the scheduler does not handle it anyway, and most of the time >> dependencies >> would prohibit such motion (in the testcase it's possible because >> other insns >> are nops). > While I'm happy with this patch, I would like to note that I'm rather > tired of fixing various corner cases that are only seen in the > scheduler when running it with -O0. I do believe that we need to > force cleanup_cfg and DCE when not optimizing and stop caring. > I don't think it is a good solution, Andrey. It is practically the same solution as preventing insn scheduling for -O0. While the passes are separate and have options to switch them on/off, the pass should work independently of the other passes work. >> >> I've verified that the patch does not affect code generation on >> several cc1 .i >> files at -O3 (targeting ia64). Bootstrapped on x86-64-linux, ia64-linux >> (testsuite running). OK for trunk? > I would also suggest to go further and check codegen differences on > SPEC2k. > Yes, it would be interesting to see differences.