From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.hosts.co.uk (smtp.hosts.co.uk [85.233.160.19]) by sourceware.org (Postfix) with ESMTPS id F274E3858D35 for ; Wed, 22 Nov 2023 15:13:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F274E3858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=pushface.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=pushface.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F274E3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=85.233.160.19 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700666026; cv=none; b=GZpFDDuGLuoSnbCkX1w/tYXc4IJq6iNzvn35u6lZzjZ85AfKmAxdHupSb7Jy9wJmYZ92LxBzDKyHziTM/mlRVUvaxlYpt7hIRUS4QbBqslOjmrZ0XteSYP7Z0JirAWppxsHOKFWao0qP1SiM0Ww6QEFdUAdCGKNozpRZN2kcbzI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700666026; c=relaxed/simple; bh=AdJEu32GiRaJw3B5kR3kWvsTiGDQT4tcD0ItF8PC48o=; h=From:Message-Id:Mime-Version:Subject:Date:To; b=PNREAFWbPPi5Fg6KW5+gEaXrpGI1TWYNbCF7pLRqcGdU/jXbb7fp9iW4X1MK8gkAmu/fG6vIDuih+e87x8Yb1KUmQnsJtZm9ARZyD5wIe5m++Fy3vWBme5dAWg3pKpP0LLRlD6T7nijBsyKKoZYVDtKZtyoKCm6x+7QRmJbHLM8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from host-80-43-112-170.as13285.net ([80.43.112.170] helo=smtpclient.apple) by smtp.hosts.co.uk with esmtpa (Exim) (envelope-from ) id 1r5ov9-000AwA-Ej; Wed, 22 Nov 2023 15:13:44 +0000 From: Simon Wright Message-Id: <4D16812A-4FBC-49FE-8F90-7B503E781176@pushface.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_70DDD8AC-C94C-47A4-9C2C-929AD655821A" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.200.91.1.1\)) Subject: Re: [PATCH] Fix PR ada/111909 On Darwin, determine filesystem case sensitivity at runtime Date: Wed, 22 Nov 2023 15:13:33 +0000 In-Reply-To: <114C2592-804C-4678-BE0A-16AF8E2C7969@sandoe.co.uk> Cc: GCC Patches , Arnaud Charlet To: Iain Sandoe References: <20231117083749.GB3688470@adacore.com> <91AF9F8B-7D2E-455A-96AA-02BE299E4968@pushface.org> <20231117092931.GA2219177@adacore.com> <640DEA70-FE25-41CD-A69B-B361DFC463D5@pushface.org> <20231117133610.GA2814215@adacore.com> <314257A9-5692-4938-8D68-B2AA85B5B725@sandoe.co.uk> <8D91765E-9338-49E8-A8FE-345448248181@pushface.org> <0CB99833-18CF-4179-BE02-DC1D0684BFA1@sandoe.co.uk> <7AE1B756-4497-4484-92AE-2D15B07B2564@pushface.org> <20231122135553.GA4051961@adacore.com> <114C2592-804C-4678-BE0A-16AF8E2C7969@sandoe.co.uk> X-Mailer: Apple Mail (2.3774.200.91.1.1) X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,BODY_8BITS,HTML_MESSAGE,KAM_DMARC_STATUS,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --Apple-Mail=_70DDD8AC-C94C-47A4-9C2C-929AD655821A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 22 Nov 2023, at 15:03, Iain Sandoe wrote: >=20 >=20 >=20 >> On 22 Nov 2023, at 14:48, Iain Sandoe wrote: >>=20 >>=20 >>=20 >>> On 22 Nov 2023, at 13:55, Arnaud Charlet wrote: >>>=20 >>>>>> #if defined (__APPLE__) >>>>>> -#include >>>>>=20 >>>>> If removing unistd.h is intentional (i.e. you determined that it=E2= =80=99s no longer >>>>> needed for Darwin), then we should make that a separate patch. >>>>=20 >>>> I thought that I=E2=80=99d had to include unistd.h for the first patch= in this thread; clearly not! >>>>=20 >>>> What I hope will be the final version: >>>=20 >>> OK here. >>=20 >> also OK here, thanks >=20 > I think this fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D111909 ? > if you agree then please add that to the commit. > Iain git format-patch does so much, I forgot this, sorry: gcc/ada/Changelog: 2023-11-22 Simon Wright > PR ada/111909 >=20 >> Iain >>=20 >>>=20 >>>> =E2=80=94=E2=80=94=E2=80=94 8< .=E2=80=94=E2=80=94=E2=80=94 >>>>=20 >>>> In gcc/ada/adaint.c(__gnat_get_file_names_case_sensitive), the current >>>> assumption for __APPLE__ is that file names are case-insensitive >>>> unless __arm__ or __arm64__ are defined, in which case file names are >>>> declared case-sensitive. >>>>=20 >>>> The associated comment is >>>> "By default, we suppose filesystems aren't case sensitive on >>>> Windows and Darwin (but they are on arm-darwin)." >>>>=20 >>>> This means that on aarch64-apple-darwin, file names are treated as >>>> case-sensitive, which is not the default case. >>>>=20 >>>> The true default position is that macOS file systems are >>>> case-insensitive, iOS file systems are case-sensitive. >>>>=20 >>>> Apple provide a header file which permits a >>>> compile-time check for the compiler target (e.g. OSX vs IOS); if >>>> TARGET_OS_IOS is defined as 1, this is a build for iOS. >>>>=20 >>>> * gcc/ada/adaint.c >>>> (__gnat_get_file_names_case_sensitive): Split out the __APPLE__ >>>> check and remove the checks for __arm__, __arm64__. >>>> For Apple, file names are by default case-insensitive unless >>>> TARGET_OS_IOS is set. >>>>=20 >>>> Signed-off-by: Simon Wright >=20 --Apple-Mail=_70DDD8AC-C94C-47A4-9C2C-929AD655821A--