From: Jerry DeLisle <jvdelisle@frontier.com>
To: Janne Blomqvist <blomqvist.janne@gmail.com>
Cc: Fortran List <fortran@gcc.gnu.org>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, libfortran] PR47296 Segfault when running out of file descriptors
Date: Mon, 17 Jan 2011 05:50:00 -0000 [thread overview]
Message-ID: <4D33AB6E.3050508@frontier.com> (raw)
In-Reply-To: <AANLkTi=R6qTThJs6eo05PqNR+cowFwyU=ON90QWEY3Hu@mail.gmail.com>
On 01/16/2011 12:11 PM, Janne Blomqvist wrote:
> Hello,
>
> the attached patch fixes the PR, the reason for the segfault was that
> even if opening a temporary file fails we still access the file name
> info. Thus don't free it in the unix.c:tempfile() function; freeing
> opp->file is taken care of by the cleanup in open.c:new_unit() which
> is the only caller. Thus this does not cause a memory leak (checked
> with valgrind).
>
> Regtested on x86_64-unknown-linux-gnu, Ok for trunk?
>
yes, this is fine. Go ahead and commit. I am still doing some testing on
cygwin, but my initial tests are OK. The only thing that has been holding me up
is some build issues plus the time it takes to even try a build.
Thanks,
Jerry
next prev parent reply other threads:[~2011-01-17 2:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-16 20:56 Janne Blomqvist
2011-01-17 5:50 ` Jerry DeLisle [this message]
2011-01-17 7:51 ` Janne Blomqvist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D33AB6E.3050508@frontier.com \
--to=jvdelisle@frontier.com \
--cc=blomqvist.janne@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).