public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Mark Mitchell <mark@codesourcery.com>
To: Nathan Froyd <froydnj@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org, jason@redhat.com
Subject: Re: [PATCH,c++] describe reasons for function template overload resolution failure
Date: Tue, 15 Feb 2011 03:34:00 -0000	[thread overview]
Message-ID: <4D59E294.207@codesourcery.com> (raw)
In-Reply-To: <20110202210501.GB12787@nightcrawler>

On 2/2/2011 1:05 PM, Nathan Froyd wrote:

> In my patch for PR 45329, diagnostics for overload resolution failure, I
> overlooked one very important class of failures: failures when dealing
> with overload candidates that are function templates.  Specifically, we
> ought to diagnose any reasons why template argument deduction failed.
> The patch below attempts to rectify that situation.  It's a bit big for
> stage 4; it'd be great if it went in to 4.6, but I expect this to go in
> for the 4.7 timeframe.  It's also not quite done, so I'd appreciate
> feedback on whether the idea and implementation are sound.

I think the idea is sound and the improved diagnostics valuable.

I do think that, though, this is 4.7 material -- it just doesn't seem
bug-fixy enough for 4.6.

> I chose to permit NULL unification_infos to be passed around; I think
> it'd be just as valid to require the unification_info to be non-NULL,
> though.

I don't have an opinion on this -- I think either way is perfectly
reasonable.  I guess, in general, requiring a non-NULL input is a bit
less error-prone, though, so I might tend that way.  A caller that
doesn't want the info can always just ignore the result...

Thank you,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713

  reply	other threads:[~2011-02-15  2:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-02 21:05 Nathan Froyd
2011-02-15  3:34 ` Mark Mitchell [this message]
2011-05-10  6:36 Nathan Froyd
2011-05-10 23:29 ` Jason Merrill
2011-05-16 20:28   ` Nathan Froyd
2011-05-18 18:36     ` Jason Merrill
2011-05-18 20:04       ` Nathan Froyd
2011-05-18 20:34         ` Jason Merrill
2011-05-25 19:40           ` Nathan Froyd
2011-05-26 16:52             ` Jason Merrill
2011-05-26 20:53               ` Nathan Froyd
2011-05-27 20:23                 ` Jason Merrill
2011-05-28  0:44                   ` Nathan Froyd
2011-05-28 14:03                     ` Jason Merrill
2011-07-17  7:56                       ` Jason Merrill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D59E294.207@codesourcery.com \
    --to=mark@codesourcery.com \
    --cc=froydnj@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jason@redhat.com \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).