From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id D03383851C34 for ; Thu, 20 Oct 2022 09:18:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D03383851C34 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=googlemail.com Received: by mail-wm1-x333.google.com with SMTP id az22-20020a05600c601600b003c6b72797fdso1708602wmb.5 for ; Thu, 20 Oct 2022 02:18:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hCs+v+zH3rHz3tCU91kJ7ZYMnZiNbEsRxfMOjauMD0k=; b=OAmdDjKmtLti7dPvmLOMxt5BCM6SvWXyMC9my3Ds6HoiOI+i5bMwDeMclr+XDo/Aag jc6OmgKVVbgl6tMScUT2SESfsadACkEkn7xYv9fFgmNRQeFtv+0Kpiw1SOmpeZxP66HD QMU8JzNwQNDiiHaMkGNlT7ZRzuvp9SNgyPwKR8d4DNEmejWfQwmPkNi3GbFAllT0IHw0 DudnFSqXkob1n9OqBvQTaMCNlMXUPfT2S0YjvMFASII3izh1yG4QHA1z6V8E87FObc6L 5FOw4S4OxU19ECn0aUibXUAG8qtHeOgoHW7uDNuE20E/9RL9nWL/Mejxl20r/BjoE+6N DAMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hCs+v+zH3rHz3tCU91kJ7ZYMnZiNbEsRxfMOjauMD0k=; b=P026dN82edLyKW3+RXXav97XIZO33IkOqnYP2+sf8sCI6htoJOtMutO5qlXaQQAGf1 OqMhOxJl99UE2pNF7kPCcN5Tiw1PTgdrcN9zCGmryFmi3xLc3C8q8ayaNPwNhPMYXhWv NhJ/CzjY4xegXNlN/bN21VbhoYaR+LgpU48E9SKHZChvOFUS4ARxlG2GKX11Dl8VuZIP /rjNN0mVpp1Pkyk4Jn7Zib5vwzGeaXFbhzXytZDmofZoNdZ/dGavsFPu/bwctTJJt4np Eg9DQU2fSxxmabe83+vM6Kr1dqtBE/hhph5nl/rH8mBZWBCnJO2ix5340amVc6hgpBkv gsgQ== X-Gm-Message-State: ACrzQf0DA6HOf9VFzBExnYV6wUcA2ME5VDjuPhgwhhP0bRo2KbJbI1bO qmdx6VSgHGylBzd3fxsaLPI= X-Google-Smtp-Source: AMsMyM4DOdsT8Y69Oh+97bmRAzQFWz2D8oqacWDmaZFercyp35X82CBQ93f05xzBCavLbu4sQSShhw== X-Received: by 2002:a05:600c:3b99:b0:3c6:8b8e:a624 with SMTP id n25-20020a05600c3b9900b003c68b8ea624mr8619235wms.113.1666257479435; Thu, 20 Oct 2022 02:17:59 -0700 (PDT) Received: from [192.168.1.95] (host81-138-1-83.in-addr.btopenworld.com. [81.138.1.83]) by smtp.googlemail.com with ESMTPSA id c1-20020a5d4141000000b002238ea5750csm19262006wrq.72.2022.10.20.02.17.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Oct 2022 02:17:58 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Subject: Re: [PATCH 0/6] Add Intel Sierra Forest Instructions From: Iain Sandoe In-Reply-To: Date: Thu, 20 Oct 2022 10:17:57 +0100 Cc: "Lu, Hongjiu" , hongtao.liu@intel.com, GCC Patches Content-Transfer-Encoding: quoted-printable Message-Id: <4D6C9639-D637-454C-82DF-925830604EEC@googlemail.com> References: <20221014075445.7938-1-haochen.jiang@intel.com> <59C4B6AD-CC12-4D2A-9F9E-E44404BDF41A@googlemail.com> To: Hongtao Liu X-Mailer: Apple Mail (2.3608.120.23.2.7) X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On 20 Oct 2022, at 10:09, Hongtao Liu via Gcc-patches = wrote: >=20 > On Thu, Oct 20, 2022 at 9:11 AM Hongtao Liu = wrote: >>=20 >> On Wed, Oct 19, 2022 at 7:09 PM Iain Sandoe = wrote: >>>=20 >>> Hi Hongtao >>>=20 >>>> On 17 Oct 2022, at 02:56, Hongtao Liu wrote: >>>>=20 >>>> On Mon, Oct 17, 2022 at 9:30 AM Bernhard Reutner-Fischer >>>> wrote: >>>>>=20 >>>>> On 17 October 2022 03:02:22 CEST, Hongtao Liu via Gcc-patches >>>>>=20 >>>>>>>>> Do you have this series as a branch somewhere that I can try = on one of the >>>>>>>>> like affected platforms? >>>>>>>>=20 >>>>>>>> Not yet. >>>>>>>> Do we have any external place to put those patches so folks = from the >>>>>>>> community can validate before it's committed, HJ? >>>>>=20 >>>>>=20 >>>>> https://gcc.gnu.org/gitwrite.html#vendor >>>>>=20 >>>>> Not sure where in cgit the user branches are visible, though? But = they can certainly be cloned and worked with. >>>> Thanks for the reminder, I've pushed to = remotes/vendors/ix86/ise046. >>>> * [new ref] refs/vendors/ix86/heads/ise046 -> >>>> vendors/ix86/ise046 >>>=20 >>> thanks for pushing this branch, much better to test these things = before committing rather than a panic >>> to fix after=E2=80=A6 >>>=20 >>>=20 >>> with >>> f90df941532 (HEAD -> ise046, vendors/ix86/ise046) Add m_CORE_ATOM = for atom cores >>>=20 >>> - on x86_64 Darwin19 I get the following bootstrap fail: >>>=20 >>> In file included from = /src-local/gcc-master/gcc/config/i386/driver-i386.cc:31: >>> /src-local/gcc-master/gcc/common/config/i386/cpuinfo.h: In function = =E2=80=98const char* get_intel_cpu(__processor_model*, = __processor_model2*, unsigned int*)=E2=80=99: >>> /src-local/gcc-master/gcc/common/config/i386/cpuinfo.h:532:32: = error: this statement may fall through [-Werror=3Dimplicit-fallthrough=3D]= >>> 532 | cpu_model->__cpu_subtype =3D = INTEL_COREI7_GRANITERAPIDS; >>> | ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> /src-local/gcc-master/gcc/common/config/i386/cpuinfo.h:533:5: note: = here >>> 533 | case 0xb6: >>> | ^~~~ >>> cc1plus: all warnings being treated as errors >>>=20 >>> =3D=3D=3D=3D >>> Will try to look later, if that does not immediately ring some bell. >> This should a bug, thanks! > I've updated the branch, please try that. I had made the same fix locally (adding the =E2=80=9Cbreak=E2=80=9D, = right?) and testing is ongoing it would not be surprising if some tests failed (asm matches for = different ABIs are rarely identical) - a few tests to be fixed in stage 3 is fine ... ... but what I wanted to avoid was the case like the bf16 changes where = every single new test fails (I have a draft patch to fix the bf16 stuff to be = posted soon). thanks Iain