From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22388 invoked by alias); 11 Mar 2011 17:17:12 -0000 Received: (qmail 22375 invoked by uid 22791); 11 Mar 2011 17:17:10 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_CX,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Mar 2011 17:16:57 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2BHGlZL001135 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 11 Mar 2011 12:16:47 -0500 Received: from [127.0.0.1] (ovpn-113-58.phx2.redhat.com [10.3.113.58]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p2BHGkCX030927; Fri, 11 Mar 2011 12:16:46 -0500 Message-ID: <4D7A58FE.5080007@redhat.com> Date: Fri, 11 Mar 2011 17:17:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b2 Thunderbird/3.1.7 MIME-Version: 1.0 To: Nathan Froyd CC: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 15/18] move REAL_IDENTIFIER_TYPE_VALUE to be a field of lang_identifier References: <1299817406-16745-1-git-send-email-froydnj@codesourcery.com> <1299817406-16745-16-git-send-email-froydnj@codesourcery.com> <4D7A2648.40005@redhat.com> <20110311140444.GI23686@codesourcery.com> <20110311141956.GJ23686@codesourcery.com> <4D7A39CF.1010909@redhat.com> <20110311162348.GM23686@codesourcery.com> In-Reply-To: <20110311162348.GM23686@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-03/txt/msg00648.txt.bz2 On 03/11/2011 11:23 AM, Nathan Froyd wrote: > Hm. OK. Just as a light sketch of how this would all work, where do > DEPENDENT_NAME_EXPRs get introduced into the AST? During parsing, or > someplace else? During parsing, yes, wherever we look up a name and currently return the plain identifier rather than a decl. > What about those cases where the FE does TREE_TYPE > (DECL_NAME (X))--are those supposed to be REAL_IDENTIFIER_TYPE_VALUE Kind of. It seems like there are two uses: 1) Remembering that we've seen a declaration of a type with this name. 2) Remembering which type a particular tinfo or conversion op name corresponds to. It probably makes sense for #2 to use a new and different macro. > There's also cases like: > > --- a/gcc/cp/error.c > +++ b/gcc/cp/error.c > @@ -1011,7 +1011,7 @@ dump_decl (tree t, int flags) > { > pp_cxx_ws_string (cxx_pp, "operator"); > /* Not exactly IDENTIFIER_TYPE_VALUE. */ > - dump_type (TREE_TYPE (t), flags); > + dump_type (REAL_IDENTIFIER_TYPE_VALUE (t), flags); > break; > } > else That's #2. Jason