public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* Fix for PR target/47951
@ 2011-03-14 12:10 Henderson, Stuart
  2011-03-15 10:02 ` Bernd Schmidt
  0 siblings, 1 reply; 3+ messages in thread
From: Henderson, Stuart @ 2011-03-14 12:10 UTC (permalink / raw)
  To: gcc-patches

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

Hi,
The attached patch is an attempt to fix PR 47951, however I'm fairly new to GCC and have little confidence in it.  I've done some testing with it and it avoids the problem and doesn't appear to cause any new problems, but I'd appreciate more experienced eyes looking over it and giving pointers.
Thanks,
Stu

[-- Attachment #2: 47951.patch --]
[-- Type: application/octet-stream, Size: 827 bytes --]

Index: gcc/config/bfin/bfin.md
===================================================================
--- gcc/config/bfin/bfin.md	(revision 170814)
+++ gcc/config/bfin/bfin.md	(working copy)
@@ -1961,15 +1961,15 @@
 
 (define_insn "loop_end"
   [(set (pc)
-	(if_then_else (ne (match_operand:SI 0 "nonimmediate_operand" "+a*d,*b*v*f,m")
+	(if_then_else (ne (match_operand:SI 2 "nonimmediate_operand" "0,0,0")
 			  (const_int 1))
 		      (label_ref (match_operand 1 "" ""))
 		      (pc)))
-   (set (match_dup 0)
-	(plus (match_dup 0)
+   (set (match_operand:SI 0 "nonimmediate_operand" "=a*d,*b*v*f,m")
+	(plus (match_dup 2)
 	      (const_int -1)))
    (unspec [(const_int 0)] UNSPEC_LSETUP_END)
-   (clobber (match_scratch:SI 2 "=X,&r,&r"))]
+   (clobber (match_scratch:SI 3 "=X,&r,&r"))]
   ""
   "@
    /* loop end %0 %l1 */

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Fix for PR target/47951
  2011-03-14 12:10 Fix for PR target/47951 Henderson, Stuart
@ 2011-03-15 10:02 ` Bernd Schmidt
  2011-03-16 11:22   ` Henderson, Stuart
  0 siblings, 1 reply; 3+ messages in thread
From: Bernd Schmidt @ 2011-03-15 10:02 UTC (permalink / raw)
  To: Henderson, Stuart; +Cc: gcc-patches

On 03/14/2011 01:10 PM, Henderson, Stuart wrote:
> Hi, The attached patch is an attempt to fix PR 47951, however I'm
> fairly new to GCC and have little confidence in it.  I've done some
> testing with it and it avoids the problem and doesn't appear to cause
> any new problems, but I'd appreciate more experienced eyes looking
> over it and giving pointers. Thanks, Stu

Looks ok.


Bernd

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: Fix for PR target/47951
  2011-03-15 10:02 ` Bernd Schmidt
@ 2011-03-16 11:22   ` Henderson, Stuart
  0 siblings, 0 replies; 3+ messages in thread
From: Henderson, Stuart @ 2011-03-16 11:22 UTC (permalink / raw)
  To: Bernd Schmidt; +Cc: gcc-patches

Thanks.  I don't have write privileges.  If no-one objects, can someone apply the patch to trunk/appropriate branches?

2011-03-16  Stuart Henderson <Stuart.Henderson@analog.com>

PR target/47951
* config/bfin/bfin.md (loop_end): Update constraints to ensure inputs match output.


-----Original Message-----
From: Bernd Schmidt [mailto:bernds@codesourcery.com]
Sent: 15 March 2011 10:02
To: Henderson, Stuart
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Fix for PR target/47951

On 03/14/2011 01:10 PM, Henderson, Stuart wrote:
> Hi, The attached patch is an attempt to fix PR 47951, however I'm
> fairly new to GCC and have little confidence in it.  I've done some
> testing with it and it avoids the problem and doesn't appear to cause
> any new problems, but I'd appreciate more experienced eyes looking
> over it and giving pointers. Thanks, Stu

Looks ok.


Bernd

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-03-16 11:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-14 12:10 Fix for PR target/47951 Henderson, Stuart
2011-03-15 10:02 ` Bernd Schmidt
2011-03-16 11:22   ` Henderson, Stuart

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).