From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4958 invoked by alias); 18 Mar 2011 14:04:30 -0000 Received: (qmail 4948 invoked by uid 22791); 18 Mar 2011 14:04:29 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Mar 2011 14:04:26 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2IE4J40029440 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 18 Mar 2011 10:04:19 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p2IE4Ipf008689; Fri, 18 Mar 2011 10:04:18 -0400 Received: from [10.3.113.13] ([10.3.113.13]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p2IE4HDA003850; Fri, 18 Mar 2011 10:04:17 -0400 Message-ID: <4D836660.4060603@redhat.com> Date: Fri, 18 Mar 2011 14:04:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.9 MIME-Version: 1.0 To: Maxim Kuvyrkov CC: gcc-patches Subject: Re: [PATCH][PR48170] Remove bogus asserts from gcse.c References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-03/txt/msg01097.txt.bz2 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 03/18/11 05:09, Maxim Kuvyrkov wrote: > PR48170 is about an ICE in code hoisting when using non-default parameter value. The ICE is due to an outdated assert; the attached patch simply removes it. I will commit the patch under the trivial rule if no one objects in 24 hours. > > The asserts used to verify an invariant that held true before a subsequent improvement to code hoisting was committed. The asserts were active only when a non-default value is used for the max-hoist-depth parameter, so no one noticed the outdated sanity checks before now. > OK. jeff -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJNg2ZgAAoJEBRtltQi2kC7et8H/jksKM/N+A6ckuS7eQiYeILX m7AsYYwuk0x7zKzEXXUAwMJJNMxWW1OWdF0TSh9KaC9rTLvSIiC/riO2qJYS82ty k2TfaTWOMNNBHzHAoDe5HeNW36QCAdwL/pkcmWrR0Kxx1VxE3JAJXD8m5ZbUOJyO 32EEAHCxGfv8LTI1ueItN3XznxmDlNnD82YZAFi/o5rJPNFzTdj07AptRHpCvjby PE6R2ls7DK1+U0Npl/kVdGiZy9k4IVN7qecFLdQ0bGDd6vuhhMS/mLhtXqivvSTE u9d2xELYEtBeRya1wAucAdH7kH5eH4H5TQWjXZ1GxaNElxVPm3FUSVR/Z5PrBDI= =Kv2/ -----END PGP SIGNATURE-----