public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <richard.guenther@gmail.com>
To: Nathan Sidwell <nathan@acm.org>,Jonathan Wakely <jwakely@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [libibery PATCH] Fix bootstrap
Date: Thu, 25 May 2017 13:01:00 -0000	[thread overview]
Message-ID: <4D87E4F6-E8BE-466B-873B-A614902FF8D6@gmail.com> (raw)
In-Reply-To: <199d22bb-7fa3-e8ff-60dc-ddcaa1d3240a@acm.org>

On May 25, 2017 1:38:36 PM GMT+02:00, Nathan Sidwell <nathan@acm.org> wrote:
>On 05/25/2017 07:21 AM, Jonathan Wakely wrote:
>
>> I don't mind removing the warning again if preferred. I thought it
>was
>> useful (as we already warn for ignored const in return types).
>
>Oh yeah, I recall noticing we did that (and noting we didn't warn 
>elsewhere).  This new warning seems consistent.
>
>I say leave it in unless the grumbling gets too much for you :)

I wonder if we can somehow default to -Wno-error=xyz for such kind of 'style' warnings...  Adding const can't possibly break anything or result in wrong expectations, can it?

Richard.

>nathan

  reply	other threads:[~2017-05-25 12:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-25  0:56 Nathan Sidwell
2017-05-25  1:13 ` Nathan Sidwell
2017-05-25  1:22   ` Nathan Sidwell
2017-05-25  1:42     ` Nathan Sidwell
2017-05-25  6:25       ` Richard Biener
2017-05-25 10:58         ` Nathan Sidwell
2017-05-25 11:21           ` Jonathan Wakely
2017-05-25 11:22             ` Jonathan Wakely
2017-05-25 12:35               ` Nathan Sidwell
2017-05-25 13:01                 ` Richard Biener [this message]
2017-05-25 13:03                   ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D87E4F6-E8BE-466B-873B-A614902FF8D6@gmail.com \
    --to=richard.guenther@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jwakely@redhat.com \
    --cc=nathan@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).