From: Bernd Schmidt <bernds@codesourcery.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: [PATCH 1/6] Disallow predicating the prologue
Date: Wed, 23 Mar 2011 14:46:00 -0000 [thread overview]
Message-ID: <4D8A0786.4060509@codesourcery.com> (raw)
In-Reply-To: <4D8A0703.9090306@codesourcery.com>
[-- Attachment #1: Type: text/plain, Size: 208 bytes --]
With prologues appearing in blocks other than the entry block, ifcvt can
decide to predicate them. This is not a good idea, as dwarf2out will
blow up trying to handle predicated frame-related things.
Bernd
[-- Attachment #2: no-ifcvt-prologue.diff --]
[-- Type: text/plain, Size: 1305 bytes --]
* ifcvt.c (cond_exec_process_insns): Disallow converting a block
that contains the prologue.
* gcc.c-torture/compile/20110322-1.c: New test.
Index: gcc/ifcvt.c
===================================================================
--- gcc.orig/ifcvt.c
+++ gcc/ifcvt.c
@@ -304,6 +304,10 @@ cond_exec_process_insns (ce_if_block_t *
for (insn = start; ; insn = NEXT_INSN (insn))
{
+ /* dwarf2out can't cope with conditional prologues. */
+ if (NOTE_P (insn) && NOTE_KIND (insn) == NOTE_INSN_PROLOGUE_END)
+ return FALSE;
+
if (NOTE_P (insn) || DEBUG_INSN_P (insn))
goto insn_done;
Index: gcc/testsuite/gcc.c-torture/compile/20110322-1.c
===================================================================
--- /dev/null
+++ gcc/testsuite/gcc.c-torture/compile/20110322-1.c
@@ -0,0 +1,22 @@
+void asn1_length_der (unsigned long int len, unsigned char *ans, int *ans_len)
+{
+ int k;
+ unsigned char temp[4];
+ if (len < 128) {
+ if (ans != ((void *) 0))
+ ans[0] = (unsigned char) len;
+ *ans_len = 1;
+ } else {
+ k = 0;
+ while (len) {
+ temp[k++] = len & 0xFF;
+ len = len >> 8;
+ }
+ *ans_len = k + 1;
+ if (ans != ((void *) 0)) {
+ ans[0] = ((unsigned char) k & 0x7F) + 128;
+ while (k--)
+ ans[*ans_len - 1 - k] = temp[k];
+ }
+ }
+}
next prev parent reply other threads:[~2011-03-23 14:46 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 14:44 Shrink-wrapping: Introduction Bernd Schmidt
2011-03-23 14:46 ` Bernd Schmidt [this message]
2011-03-31 13:20 ` [PATCH 1/6] Disallow predicating the prologue Jeff Law
2011-04-01 18:59 ` H.J. Lu
2011-04-01 21:08 ` Bernd Schmidt
2011-03-23 14:48 ` [PATCH 2/6] Unique return rtx Bernd Schmidt
2011-03-31 13:23 ` Jeff Law
2011-05-03 11:54 ` Bernd Schmidt
2011-03-23 14:51 ` [PATCH 3/6] Allow jumps in epilogues Bernd Schmidt
2011-03-23 16:46 ` Richard Henderson
2011-03-23 16:49 ` Bernd Schmidt
2011-03-23 17:19 ` Richard Henderson
2011-03-23 17:24 ` Bernd Schmidt
2011-03-23 17:27 ` Richard Henderson
2011-03-24 10:30 ` Bernd Schmidt
2011-03-25 17:51 ` Bernd Schmidt
2011-03-26 5:33 ` Richard Henderson
2011-03-31 20:09 ` Bernd Schmidt
2011-03-31 21:51 ` Richard Henderson
2011-03-31 22:36 ` Bernd Schmidt
2011-03-31 23:57 ` Richard Henderson
2011-04-05 21:59 ` Bernd Schmidt
2011-04-11 17:10 ` Richard Henderson
2011-04-13 14:16 ` Bernd Schmidt
2011-04-13 15:14 ` Bernd Schmidt
2011-04-13 15:16 ` Bernd Schmidt
2011-04-13 15:17 ` Bernd Schmidt
2011-04-13 15:28 ` Bernd Schmidt
2011-04-13 14:44 ` Richard Henderson
2011-04-13 14:54 ` Jakub Jelinek
2011-04-15 16:29 ` Bernd Schmidt
2011-03-23 14:56 ` [PATCH 4/6] Shrink-wrapping Bernd Schmidt
2011-07-07 14:51 ` Richard Sandiford
2011-07-07 15:40 ` Bernd Schmidt
2011-07-07 17:00 ` Paul Koning
2011-07-07 17:02 ` Jeff Law
2011-07-07 17:05 ` Paul Koning
2011-07-07 17:08 ` Jeff Law
2011-07-07 17:30 ` Bernd Schmidt
2011-07-08 22:59 ` [pdp11] Emit prologue as rtl Richard Henderson
2011-07-09 13:46 ` Paul Koning
2011-07-09 16:53 ` Richard Henderson
2011-07-07 15:57 ` [PATCH 4/6] Shrink-wrapping Richard Earnshaw
2011-07-07 20:19 ` Richard Sandiford
2011-07-08 8:30 ` Richard Earnshaw
2011-07-08 13:57 ` Bernd Schmidt
2011-07-11 11:24 ` Richard Sandiford
2011-07-11 11:42 ` Bernd Schmidt
2011-07-21 3:57 ` Bernd Schmidt
2011-07-21 11:25 ` Richard Sandiford
2011-07-28 11:48 ` Bernd Schmidt
2011-07-28 12:45 ` Richard Sandiford
2011-07-28 23:30 ` Richard Earnshaw
2011-07-29 12:40 ` Bernd Schmidt
2011-08-03 10:42 ` Alan Modra
2011-08-03 11:19 ` Bernd Schmidt
2011-08-02 8:40 ` Bernd Schmidt
2011-08-03 15:39 ` Richard Sandiford
2011-08-24 19:23 ` Bernd Schmidt
2011-08-24 20:48 ` Richard Sandiford
2011-08-24 20:55 ` Bernd Schmidt
2011-08-26 14:49 ` Ramana Radhakrishnan
2011-08-26 14:58 ` Bernd Schmidt
2011-08-26 15:06 ` Ramana Radhakrishnan
2011-08-28 10:58 ` H.J. Lu
2011-07-07 21:41 ` Michael Hope
2011-03-23 14:56 ` [PATCH 5/6] Generate more shrink-wrapping opportunities Bernd Schmidt
2011-03-23 15:03 ` Jeff Law
2011-03-23 15:05 ` Bernd Schmidt
2011-03-23 15:18 ` Jeff Law
2011-03-31 13:26 ` Jeff Law
2011-03-31 13:34 ` Bernd Schmidt
2011-03-23 14:57 ` [PATCH 6/6] A testcase Bernd Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8A0786.4060509@codesourcery.com \
--to=bernds@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).