From: Richard Henderson <rth@redhat.com>
To: Georg-Johann Lay <avr@gjlay.de>,
gcc-patches@gcc.gnu.org, richard.sandiford@linaro.org
Subject: Re: Cleaning up expand optabs code
Date: Fri, 25 Mar 2011 19:23:00 -0000 [thread overview]
Message-ID: <4D8CE3B6.1060606@redhat.com> (raw)
In-Reply-To: <g4ipv7t7fc.fsf@linaro.org>
On 03/25/2011 10:51 AM, Richard Sandiford wrote:
> Thanks. I think it needs to be s/!= 4/>= 6/ though, so that
> match_scratches still work when 6 operands really are passed in.
For the record, I audited all setmem and movmem patterns.
There are is only one that uses 6 operands: i386.
There are two that use 4 operands, but have 1 scratch: avr, pdp11.
All the rest have exactly 4 operands.
I'll leave the test as == 6 for now.
> Fully agreed on the optional args thing. Or maybe insn_data should
> have a separate "num_args" field.
This is sounds like a good thing.
It's probably worth doing some checking in some genfoo (opinit?) that
the named patterns have exactly the number of operands expected.
r~
next prev parent reply other threads:[~2011-03-25 18:49 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 16:33 Richard Sandiford
2011-03-17 19:20 ` Richard Henderson
2011-03-19 19:53 ` Richard Sandiford
2011-03-21 19:27 ` Richard Henderson
2011-03-21 21:39 ` Richard Sandiford
2011-03-22 15:09 ` Richard Sandiford
2011-03-22 17:49 ` Richard Henderson
2011-03-23 18:01 ` Anatoly Sokolov
2011-03-24 10:04 ` Richard Sandiford
2011-03-24 12:01 ` Andreas Krebbel
2011-03-24 12:13 ` Richard Sandiford
2011-03-24 15:09 ` Richard Sandiford
2011-03-24 17:09 ` Richard Henderson
2011-03-29 12:26 ` Mikael Pettersson
2011-03-29 13:27 ` Richard Sandiford
2011-03-29 14:27 ` Mikael Pettersson
2011-03-29 22:01 ` Richard Sandiford
2011-03-29 22:14 ` Richard Henderson
2011-03-30 9:13 ` Richard Sandiford
2011-03-30 15:23 ` Richard Henderson
2011-03-25 12:58 ` Georg-Johann Lay
2011-03-25 13:00 ` Georg-Johann Lay
2011-03-25 17:35 ` Richard Henderson
2011-03-25 17:56 ` Richard Sandiford
2011-03-25 18:30 ` Richard Sandiford
2011-03-25 18:31 ` Richard Sandiford
2011-03-25 19:23 ` Richard Henderson [this message]
2011-03-26 2:51 ` Richard Henderson
2011-03-31 10:00 ` Georg-Johann Lay
2011-03-31 12:57 ` Richard Sandiford
2011-04-01 12:54 ` Georg-Johann Lay
2011-03-24 15:14 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8CE3B6.1060606@redhat.com \
--to=rth@redhat.com \
--cc=avr@gjlay.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.sandiford@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).