From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32300 invoked by alias); 31 Mar 2011 19:47:23 -0000 Received: (qmail 32291 invoked by uid 22791); 31 Mar 2011 19:47:22 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 31 Mar 2011 19:47:18 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2VJlH08024585 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 31 Mar 2011 15:47:18 -0400 Received: from anchor.twiddle.home (ovpn-113-141.phx2.redhat.com [10.3.113.141]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p2VJlG94016864; Thu, 31 Mar 2011 15:47:17 -0400 Message-ID: <4D94DA43.10108@redhat.com> Date: Thu, 31 Mar 2011 20:02:00 -0000 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Thunderbird/3.1.9 MIME-Version: 1.0 To: gcc-patches@gcc.gnu.org, patches@linaro.org, richard.sandiford@linaro.org Subject: Re: [3/3] Record the number of generator arguments in insn_data References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-03/txt/msg02271.txt.bz2 On 03/31/2011 09:23 AM, Richard Sandiford wrote: > +++ gcc/expr.c 2011-03-31 16:49:06.000000000 +0100 > @@ -1293,11 +1293,7 @@ emit_block_move_via_movmem (rtx x, rtx y > nice if there were some way to inform the backend, so > that it doesn't fail the expansion because it thinks > emitting the libcall would be more efficient. */ > - nops = insn_data[(int) code].n_operands; > - /* ??? n_operands includes match_scratches; find some other > - way to select the 6 operand variant, or force all targets > - to have exactly 6 operands. */ > - gcc_assert (nops >= 4 && nops <= 6); > + nops = insn_data[(int) code].n_generator_args; I think the assert should be retained (for now) as gcc_assert (nops == 4 || nops == 6); at least until we add such verification to some genfoo. Also, you've forgotten the setmem hunk. r~