From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19040 invoked by alias); 31 Mar 2011 23:04:49 -0000 Received: (qmail 19028 invoked by uid 22791); 31 Mar 2011 23:04:48 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 31 Mar 2011 23:04:42 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2VN4Y3W014914 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 31 Mar 2011 19:04:34 -0400 Received: from anchor.twiddle.home (ovpn-113-141.phx2.redhat.com [10.3.113.141]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p2VN4XT4025173; Thu, 31 Mar 2011 19:04:33 -0400 Message-ID: <4D950881.1020109@redhat.com> Date: Thu, 31 Mar 2011 23:57:00 -0000 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Thunderbird/3.1.9 MIME-Version: 1.0 To: Bernd Schmidt CC: GCC Patches Subject: Re: [PATCH 3/6] Allow jumps in epilogues References: <4D8A0703.9090306@codesourcery.com> <4D8A089D.7020507@codesourcery.com> <4D8A23E8.4090802@redhat.com> <4D8A245A.20701@codesourcery.com> <4D8A2B86.4080402@redhat.com> <4D8CD227.5090205@codesourcery.com> <4D8D5CCC.10705@redhat.com> <4D94DD06.9030507@codesourcery.com> <4D94F1E2.8000906@redhat.com> <4D94FB21.1080606@codesourcery.com> In-Reply-To: <4D94FB21.1080606@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-03/txt/msg02305.txt.bz2 On 03/31/2011 03:07 PM, Bernd Schmidt wrote: > No, it's used - but it looks like I forgot to quilt refresh and the > final.c changes weren't included. New patch below. After this patch, the > whole function is processed before final, and rather than emitting cfi > directives immediately, we create these notes which cause the directives > to be emitted during final. Ah, much better. I had wondered what I was missing. > This probably shouldn't be committed separately when these changes go > in, as (I think) it breaks -freorder-blocks-and-partition as well as the > code in i386.c; it's split out simply to show an intermediate stage. Sure. > Yes, this falls under "inefficient CFI insns". I wanted to post a > preliminary proof-of-concept patch set now which generates > correct(-looking) output, but not necessarily optimized output. Not > quite sure yet how to tackle this but I'll think of something. Ok, I'll go ahead and apply all the patches locally and see what the output actually looks like. Perhaps I'll have more suggestions. r~